mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: John Meneghini <jmeneghi@redhat.com>
To: kbusch@kernel.org, hch@lst.de, sagi@grimberg.me
Cc: loberman@redhat.com, linux-nvme@lists.infradead.org,
	linux-kernel@vger.kernel.org, emilne@redhat.com,
	jmeneghi@redhat.com, bgurney@redhat.com
Subject: [PATCH 3/4] nvme: update the multipath warning in nvme_init_ns_head
Date: Thu, 27 Feb 2025 22:25:40 -0500	[thread overview]
Message-ID: <20250228032541.369804-4-jmeneghi@redhat.com> (raw)
In-Reply-To: <20250228032541.369804-1-jmeneghi@redhat.com>

The new NVME_MULTIPATH_PARAM config option requires updates
to the warning message in nvme_init_ns_head(). Remove
the old warning message and add new ones.

Signed-off-by: John Meneghini <jmeneghi@redhat.com>
---
 drivers/nvme/host/core.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 818d4e49aab5..c2b7e6834535 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -3823,8 +3823,16 @@ static int nvme_init_ns_head(struct nvme_ns *ns, struct nvme_ns_info *info)
 			dev_warn(ctrl->device,
 				"Found shared namespace %d, but multipathing not supported.\n",
 				info->nsid);
+#ifdef CONFIG_NVME_MULTIPATH
+#ifdef CONFIG_NVME_MULTIPATH_PARAM
+			dev_warn_once(ctrl->device,
+				"Shared namespace support requires core.nvme_multipath=Y.\n");
+
+#endif
+#else
 			dev_warn_once(ctrl->device,
-				"Support for shared namespaces without CONFIG_NVME_MULTIPATH is deprecated and will be removed in Linux 6.0.\n");
+				"Shared namespace support requires CONFIG_NVME_MULTIPATH.\n");
+#endif
 		}
 	}
 
-- 
2.48.1


  parent reply	other threads:[~2025-02-28  3:26 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-28  3:25 [PATCH 0/4] nvme: make core.nvme_multipath configurable John Meneghini
2025-02-28  3:25 ` [PATCH 1/4] nvme-multipath: change the NVME_MULTIPATH config option John Meneghini
2025-03-05 14:33   ` Christoph Hellwig
2025-02-28  3:25 ` [PATCH 2/4] nvme-multipath: add the NVME_MULTIPATH_PARAM " John Meneghini
2025-02-28  6:28   ` Nilay Shroff
2025-02-28 13:07     ` John Meneghini
2025-03-05 14:33   ` Christoph Hellwig
2025-03-12  2:35     ` John Meneghini
2025-03-12  5:19       ` Christoph Hellwig
2025-03-13 21:46         ` John Meneghini
2025-03-17 18:00           ` Keith Busch
2025-02-28  3:25 ` John Meneghini [this message]
2025-02-28  6:28   ` [PATCH 3/4] nvme: update the multipath warning in nvme_init_ns_head Nilay Shroff
2025-02-28 13:14     ` John Meneghini
2025-03-02 17:28       ` Nilay Shroff
2025-02-28  3:25 ` [PATCH 4/4] nvme: add mulitipath warning to nvme_alloc_ns John Meneghini
2025-03-05 14:37   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250228032541.369804-4-jmeneghi@redhat.com \
    --to=jmeneghi@redhat.com \
    --cc=bgurney@redhat.com \
    --cc=emilne@redhat.com \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=loberman@redhat.com \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®