From: Dietmar Eggemann <dietmar.eggemann@arm.com>
To: Vincent Guittot <vincent.guittot@linaro.org>,
Qais Yousef <qyousef@layalina.io>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Valentin Schneider <vschneid@redhat.com>,
Christian Loehle <christian.loehle@arm.com>,
Hongyan Xia <hongyan.xia2@arm.com>,
John Stultz <jstultz@google.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6] sched: Consolidate cpufreq updates
Date: Wed, 10 Jul 2024 18:22:40 +0200 [thread overview]
Message-ID: <03f3bdd8-d3c1-448c-ba46-7be2289d75ae@arm.com> (raw)
In-Reply-To: <CAKfTPtBQnTJQaU6iYCz3JhZ0Y=MjyM7oZ3Ug_SNfyZ0AwVPXJQ@mail.gmail.com>
On 09/07/2024 09:48, Vincent Guittot wrote:
> On Wed, 19 Jun 2024 at 22:14, Qais Yousef <qyousef@layalina.io> wrote:
[...]
>> @@ -811,7 +818,14 @@ int __sched_setscheduler(struct task_struct *p,
>> if (running)
>> set_next_task(rq, p);
>>
>> - check_class_changed(rq, p, prev_class, oldprio);
>> + update_cpufreq |= check_class_changed(rq, p, prev_class, oldprio);
>> +
>> + /*
>> + * Changing class or uclamp value implies requiring to send cpufreq
>> + * update.
>> + */
>> + if (update_cpufreq && running)
>
> Why running ? it should be queued as we are max aggregating
Also wondering ... IMHO, this has been discussed in v4 already:
https://lkml.kernel.org/r/20240529011144.smuq6dbaxvulxy4e@airbuntu
[...]
next prev parent reply other threads:[~2024-07-10 16:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-19 20:14 Qais Yousef
2024-06-25 12:58 ` Dietmar Eggemann
2024-06-28 1:52 ` Qais Yousef
2024-07-04 10:12 ` Dietmar Eggemann
2024-07-05 0:22 ` Qais Yousef
2024-07-05 11:50 ` Dietmar Eggemann
2024-07-09 7:49 ` Vincent Guittot
2024-07-24 21:10 ` Qais Yousef
2024-07-27 8:15 ` Dietmar Eggemann
2024-07-28 19:29 ` Qais Yousef
2024-07-09 7:48 ` Vincent Guittot
2024-07-10 16:22 ` Dietmar Eggemann [this message]
2024-07-24 21:22 ` Qais Yousef
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03f3bdd8-d3c1-448c-ba46-7be2289d75ae@arm.com \
--to=dietmar.eggemann@arm.com \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=christian.loehle@arm.com \
--cc=hongyan.xia2@arm.com \
--cc=jstultz@google.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=qyousef@layalina.io \
--cc=rafael@kernel.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®