mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Maxime Ripard" <mripard@kernel.org>
To: "Jim Cromie" <jim.cromie@gmail.com>
Cc: amd-gfx@lists.freedesktop.org, daniel.vetter@ffwll.ch,
	daniel@ffwll.ch, dri-devel@lists.freedesktop.org,
	intel-gfx@lists.freedesktop.org,
	intel-gvt-dev@lists.freedesktop.org, jani.nikula@intel.com,
	linux-kernel@vger.kernel.org, robdclark@gmail.com,
	seanpaul@chromium.org, ville.syrjala@linux.intel.com,
	"David Airlie" <airlied@gmail.com>,
	"Emma Anholt" <emma@anholt.net>,
	"Maxime Ripard" <mripard@kernel.org>
Subject: Re: [PATCH v3 4/5] drm/vc4: add trailing newlines to drm_dbg msgs
Date: Thu, 07 Sep 2023 06:51:59 +0000	[thread overview]
Message-ID: <040b316aae533abac3d3fa9c1eaff3d1.mripard@kernel.org> (raw)
In-Reply-To: <20230906190224.583577-5-jim.cromie@gmail.com>

On Wed, 6 Sep 2023 13:02:22 -0600, Jim Cromie wrote:
> By at least strong convention, a print-buffer's trailing newline says
> "message complete, send it".  The exception (no TNL, followed by a call
> to pr_cont) proves the general rule.
> 
> Most DRM.debug calls already comport with this: 207 DRM_DEV_DEBUG,
> 
> [ ... ]

Acked-by: Maxime Ripard <mripard@kernel.org>

Thanks!
Maxime

  reply	other threads:[~2023-09-07 16:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-06 19:02 [PATCH v3 0/5] drm/drm_dbg: add trailing newlines where missing Jim Cromie
2023-09-06 19:02 ` [PATCH v3 1/5] drm/connector: add trailing newlines to drm_dbg msgs Jim Cromie
2023-09-07  6:51   ` Maxime Ripard
2023-09-06 19:02 ` [PATCH v3 2/5] drm/kmb: " Jim Cromie
2023-09-07  0:12   ` Chrisanthus, Anitha
2023-09-06 19:02 ` [PATCH v3 3/5] drm/msm: " Jim Cromie
2023-09-06 20:29   ` Abhinav Kumar
2023-09-06 19:02 ` [PATCH v3 4/5] drm/vc4: " Jim Cromie
2023-09-07  6:51   ` Maxime Ripard [this message]
2023-09-06 19:02 ` [PATCH v3 5/5] drm/Makefile: use correct ccflags-y syntax Jim Cromie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=040b316aae533abac3d3fa9c1eaff3d1.mripard@kernel.org \
    --to=mripard@kernel.org \
    --cc=airlied@gmail.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=daniel.vetter@ffwll.ch \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=emma@anholt.net \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-gvt-dev@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=jim.cromie@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robdclark@gmail.com \
    --cc=seanpaul@chromium.org \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®