From: Abhinav Kumar <quic_abhinavk@quicinc.com>
To: Jim Cromie <jim.cromie@gmail.com>, <linux-kernel@vger.kernel.org>,
<dri-devel@lists.freedesktop.org>,
<amd-gfx@lists.freedesktop.org>,
<intel-gvt-dev@lists.freedesktop.org>,
<intel-gfx@lists.freedesktop.org>
Cc: <daniel.vetter@ffwll.ch>, <daniel@ffwll.ch>,
<jani.nikula@intel.com>, <ville.syrjala@linux.intel.com>,
<seanpaul@chromium.org>, <robdclark@gmail.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Sean Paul <sean@poorly.run>,
Marijn Suijten <marijn.suijten@somainline.org>,
David Airlie <airlied@gmail.com>, <linux-arm-msm@vger.kernel.org>,
<freedreno@lists.freedesktop.org>
Subject: Re: [PATCH v3 3/5] drm/msm: add trailing newlines to drm_dbg msgs
Date: Wed, 6 Sep 2023 13:29:54 -0700 [thread overview]
Message-ID: <b3871c05-7cab-57ae-592c-1cfcba4e61af@quicinc.com> (raw)
In-Reply-To: <20230906190224.583577-4-jim.cromie@gmail.com>
Hi Jim
On 9/6/2023 12:02 PM, Jim Cromie wrote:
> By at least strong convention, a print-buffer's trailing newline says
> "message complete, send it". The exception (no TNL, followed by a call
> to pr_cont) proves the general rule.
>
> Most DRM.debug calls already comport with this: 207 DRM_DEV_DEBUG,
> 1288 drm_dbg. Clean up the remainders, in maintainer sized chunks.
May I know what 207, 1288 mean here? Is it the number of callers already
having \n?
If so, this might be a big confusing as its subjective to the code-base
you are referring to. So I will just stop with "Most DRM.debug calls
already comport with this".
>
> No functional changes.
>
> Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
> ---
> drivers/gpu/drm/msm/msm_fb.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
The change itself LGTM, hence
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
next prev parent reply other threads:[~2023-09-06 20:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-06 19:02 [PATCH v3 0/5] drm/drm_dbg: add trailing newlines where missing Jim Cromie
2023-09-06 19:02 ` [PATCH v3 1/5] drm/connector: add trailing newlines to drm_dbg msgs Jim Cromie
2023-09-07 6:51 ` Maxime Ripard
2023-09-06 19:02 ` [PATCH v3 2/5] drm/kmb: " Jim Cromie
2023-09-07 0:12 ` Chrisanthus, Anitha
2023-09-06 19:02 ` [PATCH v3 3/5] drm/msm: " Jim Cromie
2023-09-06 20:29 ` Abhinav Kumar [this message]
2023-09-06 19:02 ` [PATCH v3 4/5] drm/vc4: " Jim Cromie
2023-09-07 6:51 ` Maxime Ripard
2023-09-06 19:02 ` [PATCH v3 5/5] drm/Makefile: use correct ccflags-y syntax Jim Cromie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3871c05-7cab-57ae-592c-1cfcba4e61af@quicinc.com \
--to=quic_abhinavk@quicinc.com \
--cc=airlied@gmail.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel@ffwll.ch \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=jim.cromie@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=seanpaul@chromium.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®