* [PATCH][media-next] media: qcom: camss: Make function vfe_set_selection static
@ 2017-08-29 10:21 Colin King
2017-08-29 11:49 ` Todor Tomov
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2017-08-29 10:21 UTC (permalink / raw)
To: Todor Tomov, Mauro Carvalho Chehab, linux-media
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The function vfe_set_selection is local to the source and does
not need to be in global scope, so make it static.
Cleans up sparse warning:
warning: symbol 'vfe_set_selection' was not declared. Should it be static?
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/media/platform/qcom/camss-8x16/camss-vfe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/qcom/camss-8x16/camss-vfe.c b/drivers/media/platform/qcom/camss-8x16/camss-vfe.c
index b21b3c2dc77f..b22d2dfcd3c2 100644
--- a/drivers/media/platform/qcom/camss-8x16/camss-vfe.c
+++ b/drivers/media/platform/qcom/camss-8x16/camss-vfe.c
@@ -2660,7 +2660,7 @@ static int vfe_get_selection(struct v4l2_subdev *sd,
*
* Return -EINVAL or zero on success
*/
-int vfe_set_selection(struct v4l2_subdev *sd,
+static int vfe_set_selection(struct v4l2_subdev *sd,
struct v4l2_subdev_pad_config *cfg,
struct v4l2_subdev_selection *sel)
{
--
2.14.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH][media-next] media: qcom: camss: Make function vfe_set_selection static
2017-08-29 10:21 [PATCH][media-next] media: qcom: camss: Make function vfe_set_selection static Colin King
@ 2017-08-29 11:49 ` Todor Tomov
0 siblings, 0 replies; 2+ messages in thread
From: Todor Tomov @ 2017-08-29 11:49 UTC (permalink / raw)
To: Colin King
Cc: Todor Tomov, Mauro Carvalho Chehab, linux-media, kernel-janitors,
linux-kernel
On 29.08.2017 13:21, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The function vfe_set_selection is local to the source and does
> not need to be in global scope, so make it static.
>
> Cleans up sparse warning:
> warning: symbol 'vfe_set_selection' was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Thank you!
Acked-by: Todor Tomov <todor.tomov@linaro.org>
> ---
> drivers/media/platform/qcom/camss-8x16/camss-vfe.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/qcom/camss-8x16/camss-vfe.c b/drivers/media/platform/qcom/camss-8x16/camss-vfe.c
> index b21b3c2dc77f..b22d2dfcd3c2 100644
> --- a/drivers/media/platform/qcom/camss-8x16/camss-vfe.c
> +++ b/drivers/media/platform/qcom/camss-8x16/camss-vfe.c
> @@ -2660,7 +2660,7 @@ static int vfe_get_selection(struct v4l2_subdev *sd,
> *
> * Return -EINVAL or zero on success
> */
> -int vfe_set_selection(struct v4l2_subdev *sd,
> +static int vfe_set_selection(struct v4l2_subdev *sd,
> struct v4l2_subdev_pad_config *cfg,
> struct v4l2_subdev_selection *sel)
> {
>
--
Best regards,
Todor Tomov
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-29 11:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-29 10:21 [PATCH][media-next] media: qcom: camss: Make function vfe_set_selection static Colin King
2017-08-29 11:49 ` Todor Tomov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®