From: Ivan Vecera <ivecera@redhat.com>
To: Petr Oros <poros@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
Donald Hunter <donald.hunter@gmail.com>,
Jiri Pirko <jiri@resnulli.us>,
Vadim Fedorenko <vadim.fedorenko@linux.dev>,
Milena Olech <milena.olech@intel.com>,
Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>,
Michal Michalik <michal.michalik@intel.com>,
"open list:NETWORKING [GENERAL]" <netdev@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Cc: mschmidt@redhat.com
Subject: Re: [PATCH net] dpll: spec: add missing module-name and clock-id to pin-get reply
Date: Mon, 27 Oct 2025 10:04:34 +0100 [thread overview]
Message-ID: <0466a326-5e0b-4099-a2b9-5c5a6baaadfb@redhat.com> (raw)
In-Reply-To: <20251024185512.363376-1-poros@redhat.com>
On 10/24/25 8:55 PM, Petr Oros wrote:
> The dpll.yaml spec incorrectly omitted module-name and clock-id from the
> pin-get operation reply specification, even though the kernel DPLL
> implementation has always included these attributes in pin-get responses
> since the initial implementation.
>
> This spec inconsistency caused issues with the C YNL code generator.
> The generated dpll_pin_get_rsp structure was missing these fields.
>
> Fix the spec by adding module-name and clock-id to the pin-attrs reply
> specification to match the actual kernel behavior.
>
> Fixes: 3badff3a25d8 ("dpll: spec: Add Netlink spec in YAML")
> Signed-off-by: Petr Oros <poros@redhat.com>
> ---
> Documentation/netlink/specs/dpll.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/netlink/specs/dpll.yaml b/Documentation/netlink/specs/dpll.yaml
> index cafb4ec20447e1..80728f6f9bc876 100644
> --- a/Documentation/netlink/specs/dpll.yaml
> +++ b/Documentation/netlink/specs/dpll.yaml
> @@ -605,6 +605,8 @@ operations:
> reply: &pin-attrs
> attributes:
> - id
> + - module-name
> + - clock-id
> - board-label
> - panel-label
> - package-label
Reviewed-by: Ivan Vecera <ivecera@redhat.com>
next prev parent reply other threads:[~2025-10-27 9:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-24 18:55 Petr Oros
2025-10-27 9:04 ` Ivan Vecera [this message]
2025-10-28 1:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0466a326-5e0b-4099-a2b9-5c5a6baaadfb@redhat.com \
--to=ivecera@redhat.com \
--cc=arkadiusz.kubalewski@intel.com \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.michalik@intel.com \
--cc=milena.olech@intel.com \
--cc=mschmidt@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=poros@redhat.com \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®