From: Jens Axboe <axboe@fb.com>
To: Wouter Verhelst <w@uter.be>
Cc: Josef Bacik <jbacik@fb.com>, <linux-block@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <kernel-team@fb.com>,
<mpa@pengutronix.de>, <nbd-general@lists.sourceforge.net>
Subject: Re: [Nbd] [PATCH 0/5] nbd improvements
Date: Fri, 9 Sep 2016 14:26:21 -0600 [thread overview]
Message-ID: <046ee110-1951-be3b-9251-fbd03bef9f53@fb.com> (raw)
In-Reply-To: <20160909200816.spdbyericjehvmcq@grep.be>
On 09/09/2016 02:08 PM, Wouter Verhelst wrote:
> Hi Jens,
>
> On Thu, Sep 08, 2016 at 02:13:46PM -0600, Jens Axboe wrote:
>> Not only are these nice performance improvements, it also cleans up the
>> code a lot and kills crufty old driver code in favor of using the proper
>> APIs instead. I have applied the series for 4.9.
>
> Please ensure that the comments I made in my other mail are addressed
> before you push this to Linus; otherwise this will result in significant
> problems for userspace (that it would then be my responsibility to deal
> with).
We've got some time to hash this out, before it goes upstream. I agree
on the 'pid' file being an issue, we need to bring that back to avoid
breaking userspace.
For the other part, Josef, did you test the multiple connection setup
against re-connection?
--
Jens Axboe
next prev parent reply other threads:[~2016-09-09 20:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1473363221-142264-1-git-send-email-jbacik@fb.com>
2016-09-08 20:13 ` Jens Axboe
2016-09-09 20:08 ` [Nbd] " Wouter Verhelst
2016-09-09 20:26 ` Jens Axboe [this message]
2016-09-15 18:53 ` Markus Pargmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=046ee110-1951-be3b-9251-fbd03bef9f53@fb.com \
--to=axboe@fb.com \
--cc=jbacik@fb.com \
--cc=kernel-team@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpa@pengutronix.de \
--cc=nbd-general@lists.sourceforge.net \
--cc=w@uter.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®