From: Richard Weinberger <richard@nod.at>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-mtd@lists.infradead.org, david@sigma-star.at,
dedekind1@gmail.com, adrian.hunter@intel.com,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
adilger.kernel@dilger.ca, akpm@linux-foundation.org,
linux-ext4@vger.kernel.org, bfields@redhat.com,
marcus.folkesson@gmail.com, hyc.lee@gmail.com,
rockdotlee@gmail.com, leon.pollak@gmail.com
Subject: Re: [PATCH 5/6] ubifs: Implement export_operations
Date: Tue, 23 May 2017 10:41:16 +0200 [thread overview]
Message-ID: <04af5127-e8f3-a2e9-4d2f-af5ef9fc1531@nod.at> (raw)
In-Reply-To: <20170523083932.GC4107@infradead.org>
Christoph,
Am 23.05.2017 um 10:39 schrieb Christoph Hellwig:
>> +static struct inode *ubifs_nfs_get_inode(struct super_block *sb, uint64_t ino,
>> + uint32_t generation)
>> +{
>> + return ubifs_iget(sb, ino);
>> +}
>
> You need to maintain and check an inode generation counter for this
> to be safe.
UBIFS has no inode generations, inodes simply can't wrap around.
We "handle" it like JFF2 does, we assumes that the NAND is long dead
before we reach the maximum inode number.
Thanks,
//richard
next prev parent reply other threads:[~2017-05-23 8:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-21 20:20 [PATCH 0/6] UBIFS NFS export support v2 Richard Weinberger
2017-05-21 20:20 ` [PATCH 1/6] ext4: Move is_32bit_api() to generic code Richard Weinberger
2017-05-23 8:36 ` Christoph Hellwig
2017-05-21 20:20 ` [PATCH 2/6] ubifs: Provide a custom llseek for directories Richard Weinberger
2017-05-21 20:20 ` [PATCH 3/6] ubifs: Use 64bit readdir cookies Richard Weinberger
2017-05-21 20:20 ` [PATCH 4/6] ubifs: Maintain a parent pointer Richard Weinberger
2017-05-22 4:30 ` Hyunchul Lee
2017-05-22 8:45 ` Richard Weinberger
2017-05-22 23:50 ` Hyunchul Lee
2017-05-23 7:16 ` Richard Weinberger
2017-05-23 8:37 ` Christoph Hellwig
2017-05-23 8:42 ` Richard Weinberger
2017-05-21 20:20 ` [PATCH 5/6] ubifs: Implement export_operations Richard Weinberger
2017-05-23 8:39 ` Christoph Hellwig
2017-05-23 8:41 ` Richard Weinberger [this message]
2017-05-23 8:48 ` Christoph Hellwig
2017-05-23 8:50 ` Richard Weinberger
2017-05-21 20:20 ` [PATCH 6/6] ubifs: Wire up NFS support Richard Weinberger
-- strict thread matches above, loose matches on Subject: below --
2016-12-01 22:02 [PATCH 0/6] UBIFS NFS export support Richard Weinberger
2016-12-01 22:02 ` [PATCH 5/6] ubifs: Implement export_operations Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04af5127-e8f3-a2e9-4d2f-af5ef9fc1531@nod.at \
--to=richard@nod.at \
--cc=adilger.kernel@dilger.ca \
--cc=adrian.hunter@intel.com \
--cc=akpm@linux-foundation.org \
--cc=bfields@redhat.com \
--cc=david@sigma-star.at \
--cc=dedekind1@gmail.com \
--cc=hch@infradead.org \
--cc=hyc.lee@gmail.com \
--cc=leon.pollak@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marcus.folkesson@gmail.com \
--cc=rockdotlee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®