mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-mtd@lists.infradead.org, david@sigma-star.at,
	dedekind1@gmail.com, adrian.hunter@intel.com,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	adilger.kernel@dilger.ca, akpm@linux-foundation.org,
	linux-ext4@vger.kernel.org, bfields@redhat.com,
	marcus.folkesson@gmail.com, hyc.lee@gmail.com,
	rockdotlee@gmail.com, leon.pollak@gmail.com
Subject: Re: [PATCH 4/6] ubifs: Maintain a parent pointer
Date: Tue, 23 May 2017 10:42:31 +0200	[thread overview]
Message-ID: <99b3f295-be4e-14a1-a21d-e9055949a8ef@nod.at> (raw)
In-Reply-To: <20170523083758.GB4107@infradead.org>

Christoph,

Am 23.05.2017 um 10:37 schrieb Christoph Hellwig:
> On Sun, May 21, 2017 at 10:20:49PM +0200, Richard Weinberger wrote:
>> The new feature UBIFS_FLG_PARENTPOINTER allows looking
>> up the parent. Usually the Linux VFS walks down the filesystem
>> and no parent pointers are needed. But when a filesystem
>> is exportable via NFS such a lookup is needed.
>> We can use a padding field in struct ubifs_ino_node to
>> maintain a pointer to the parent inode.
> 
> Note that nfsd/exportfs will only do this for directories, and beacause
> we hardlinks for other objects that is an important distinction.
> 
> I think the ubifs code should make sure to only maintain the parent
> pointers for directories, otherwise confusion and abuses will happen.

Thanks for the info, I'll massage the code in that direction.

Thanks,
//richard

  reply	other threads:[~2017-05-23  8:42 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-21 20:20 [PATCH 0/6] UBIFS NFS export support v2 Richard Weinberger
2017-05-21 20:20 ` [PATCH 1/6] ext4: Move is_32bit_api() to generic code Richard Weinberger
2017-05-23  8:36   ` Christoph Hellwig
2017-05-21 20:20 ` [PATCH 2/6] ubifs: Provide a custom llseek for directories Richard Weinberger
2017-05-21 20:20 ` [PATCH 3/6] ubifs: Use 64bit readdir cookies Richard Weinberger
2017-05-21 20:20 ` [PATCH 4/6] ubifs: Maintain a parent pointer Richard Weinberger
2017-05-22  4:30   ` Hyunchul Lee
2017-05-22  8:45     ` Richard Weinberger
2017-05-22 23:50       ` Hyunchul Lee
2017-05-23  7:16         ` Richard Weinberger
2017-05-23  8:37   ` Christoph Hellwig
2017-05-23  8:42     ` Richard Weinberger [this message]
2017-05-21 20:20 ` [PATCH 5/6] ubifs: Implement export_operations Richard Weinberger
2017-05-23  8:39   ` Christoph Hellwig
2017-05-23  8:41     ` Richard Weinberger
2017-05-23  8:48       ` Christoph Hellwig
2017-05-23  8:50         ` Richard Weinberger
2017-05-21 20:20 ` [PATCH 6/6] ubifs: Wire up NFS support Richard Weinberger
  -- strict thread matches above, loose matches on Subject: below --
2016-12-01 22:02 [PATCH 0/6] UBIFS NFS export support Richard Weinberger
2016-12-01 22:02 ` [PATCH 4/6] ubifs: Maintain a parent pointer Richard Weinberger
2016-12-02  9:28   ` Marcus Folkesson
2016-12-02 10:36     ` Richard Weinberger
2017-04-28  8:31   ` Hyunchul Lee
2017-04-28  9:09     ` Richard Weinberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=99b3f295-be4e-14a1-a21d-e9055949a8ef@nod.at \
    --to=richard@nod.at \
    --cc=adilger.kernel@dilger.ca \
    --cc=adrian.hunter@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=bfields@redhat.com \
    --cc=david@sigma-star.at \
    --cc=dedekind1@gmail.com \
    --cc=hch@infradead.org \
    --cc=hyc.lee@gmail.com \
    --cc=leon.pollak@gmail.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=marcus.folkesson@gmail.com \
    --cc=rockdotlee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®