* [PATCH] ice: use proper macro for testing bit
@ 2024-06-12 15:46 Petr Oros
2024-06-12 15:53 ` Ivan Vecera
0 siblings, 1 reply; 2+ messages in thread
From: Petr Oros @ 2024-06-12 15:46 UTC (permalink / raw)
To: netdev
Cc: ivecera, Petr Oros, Jesse Brandeburg, Tony Nguyen,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Marcin Domagala, Eric Joyner, Konrad Knitter, Marcin Szycik,
moderated list:INTEL ETHERNET DRIVERS, open list
Do not use _test_bit() macro for testing bit. The proper macro for this
is one without underline.
Fixes: 4da71a77fc3b ("ice: read internal temperature sensor")
Signed-off-by: Petr Oros <poros@redhat.com>
---
drivers/net/ethernet/intel/ice/ice_hwmon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_hwmon.c b/drivers/net/ethernet/intel/ice/ice_hwmon.c
index e4c2c1bff6c086..b7aa6812510a4f 100644
--- a/drivers/net/ethernet/intel/ice/ice_hwmon.c
+++ b/drivers/net/ethernet/intel/ice/ice_hwmon.c
@@ -96,7 +96,7 @@ static bool ice_is_internal_reading_supported(struct ice_pf *pf)
unsigned long sensors = pf->hw.dev_caps.supported_sensors;
- return _test_bit(ICE_SENSOR_SUPPORT_E810_INT_TEMP_BIT, &sensors);
+ return test_bit(ICE_SENSOR_SUPPORT_E810_INT_TEMP_BIT, &sensors);
};
void ice_hwmon_init(struct ice_pf *pf)
--
2.44.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ice: use proper macro for testing bit
2024-06-12 15:46 [PATCH] ice: use proper macro for testing bit Petr Oros
@ 2024-06-12 15:53 ` Ivan Vecera
0 siblings, 0 replies; 2+ messages in thread
From: Ivan Vecera @ 2024-06-12 15:53 UTC (permalink / raw)
To: Petr Oros, netdev
Cc: Jesse Brandeburg, Tony Nguyen, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Marcin Domagala, Eric Joyner,
Konrad Knitter, Marcin Szycik,
moderated list:INTEL ETHERNET DRIVERS, open list
On 12. 06. 24 17:46, Petr Oros wrote:
> Do not use _test_bit() macro for testing bit. The proper macro for this
> is one without underline.
>
> Fixes: 4da71a77fc3b ("ice: read internal temperature sensor")
> Signed-off-by: Petr Oros <poros@redhat.com>
> ---
> drivers/net/ethernet/intel/ice/ice_hwmon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/ice/ice_hwmon.c b/drivers/net/ethernet/intel/ice/ice_hwmon.c
> index e4c2c1bff6c086..b7aa6812510a4f 100644
> --- a/drivers/net/ethernet/intel/ice/ice_hwmon.c
> +++ b/drivers/net/ethernet/intel/ice/ice_hwmon.c
> @@ -96,7 +96,7 @@ static bool ice_is_internal_reading_supported(struct ice_pf *pf)
>
> unsigned long sensors = pf->hw.dev_caps.supported_sensors;
>
> - return _test_bit(ICE_SENSOR_SUPPORT_E810_INT_TEMP_BIT, &sensors);
> + return test_bit(ICE_SENSOR_SUPPORT_E810_INT_TEMP_BIT, &sensors);
> };
>
> void ice_hwmon_init(struct ice_pf *pf)
Acked-by: Ivan Vecera <ivecera@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-06-12 15:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-06-12 15:46 [PATCH] ice: use proper macro for testing bit Petr Oros
2024-06-12 15:53 ` Ivan Vecera
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®