mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Menzel <pmenzel@molgen.mpg.de>
To: Hilda Wu <hildawu@realtek.com>, marcel@holtmann.org
Cc: luiz.dentz@gmail.com, linux-bluetooth@vger.kernel.org,
	linux-kernel@vger.kernel.org, alex_lu@realsil.com.cn,
	max.chou@realtek.com, kidman@realtek.com
Subject: Re: [PATCH] Bluetooth: btusb: Add RTL8852BE device 0489:e125 to device tables
Date: Mon, 17 Jun 2024 10:32:18 +0200	[thread overview]
Message-ID: <04d3dc7d-8266-4d2d-9efb-e9993af9548b@molgen.mpg.de> (raw)
In-Reply-To: <20240617082101.3237350-1-hildawu@realtek.com>

Dear Hilda,


Thank you for your patch.

Am 17.06.24 um 10:21 schrieb Hilda Wu:
> Add the support ID(0489:e125) to usb_device_id table for

Please add a space before (.

> Realtek RTL8852B chip.
> 
> The device info from /sys/kernel/debug/usb/devices as below.

[…]

> Signed-off-by: Hilda Wu <hildawu@realtek.com>
> ---
>   drivers/bluetooth/btusb.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index 79aefdb3324d..2d7d47f9d007 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -555,6 +555,8 @@ static const struct usb_device_id quirks_table[] = {
>   						     BTUSB_WIDEBAND_SPEECH },
>   	{ USB_DEVICE(0x13d3, 0x3572), .driver_info = BTUSB_REALTEK |
>   						     BTUSB_WIDEBAND_SPEECH },
> +	{ USB_DEVICE(0x0489, 0xe125), .driver_info = BTUSB_REALTEK |
> +						     BTUSB_WIDEBAND_SPEECH },

Please put it at the beginning of the list for the 8852BE devices to 
kind of sort it.

>   
>   	/* Realtek 8852BT/8852BE-VT Bluetooth devices */
>   	{ USB_DEVICE(0x0bda, 0x8520), .driver_info = BTUSB_REALTEK |


Kind regards,

Paul

      reply	other threads:[~2024-06-17  8:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-17  8:21 Hilda Wu
2024-06-17  8:32 ` Paul Menzel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=04d3dc7d-8266-4d2d-9efb-e9993af9548b@molgen.mpg.de \
    --to=pmenzel@molgen.mpg.de \
    --cc=alex_lu@realsil.com.cn \
    --cc=hildawu@realtek.com \
    --cc=kidman@realtek.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    --cc=marcel@holtmann.org \
    --cc=max.chou@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®