* [PATCH 0/1] Add missing plane settings when async update
@ 2023-09-18 7:00 Hsiao Chien Sung
2023-09-18 7:00 ` [PATCH 1/1] drm/mediatek: " Hsiao Chien Sung
0 siblings, 1 reply; 4+ messages in thread
From: Hsiao Chien Sung @ 2023-09-18 7:00 UTC (permalink / raw)
To: CK Hu, AngeloGioacchino Del Regno
Cc: Bibby Hsieh, David Airlie, Daniel Vetter, Matthias Brugger,
Philipp Zabel, dri-devel, linux-mediatek, linux-kernel,
linux-arm-kernel, Hsiao Chien Sung
Fix an issue that plane coordinate was not saved when
calling async update.
Hsiao Chien Sung (1):
drm/mediatek: Add missing plane settings when async update
drivers/gpu/drm/mediatek/mtk_drm_plane.c | 2 ++
1 file changed, 2 insertions(+)
--
2.18.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/1] drm/mediatek: Add missing plane settings when async update
2023-09-18 7:00 [PATCH 0/1] Add missing plane settings when async update Hsiao Chien Sung
@ 2023-09-18 7:00 ` Hsiao Chien Sung
2023-09-18 8:56 ` AngeloGioacchino Del Regno
2023-10-26 1:42 ` CK Hu (胡俊光)
0 siblings, 2 replies; 4+ messages in thread
From: Hsiao Chien Sung @ 2023-09-18 7:00 UTC (permalink / raw)
To: CK Hu, AngeloGioacchino Del Regno
Cc: Bibby Hsieh, David Airlie, Daniel Vetter, Matthias Brugger,
Philipp Zabel, dri-devel, linux-mediatek, linux-kernel,
linux-arm-kernel, Hsiao Chien Sung
Fix an issue that plane coordinate was not saved when
calling async update.
Fixes: 920fffcc8912 ("drm/mediatek: update cursors by using async atomic update")
Signed-off-by: Hsiao Chien Sung <shawn.sung@mediatek.com>
---
drivers/gpu/drm/mediatek/mtk_drm_plane.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_plane.c b/drivers/gpu/drm/mediatek/mtk_drm_plane.c
index db2f70ae060d..58e9f93c38c4 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_plane.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_plane.c
@@ -206,6 +206,8 @@ static void mtk_plane_atomic_async_update(struct drm_plane *plane,
plane->state->src_y = new_state->src_y;
plane->state->src_h = new_state->src_h;
plane->state->src_w = new_state->src_w;
+ plane->state->dst.x1 = new_state->dst.x1;
+ plane->state->dst.y1 = new_state->dst.y1;
swap(plane->state->fb, new_state->fb);
mtk_plane_update_new_state(new_state, new_plane_state);
--
2.18.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] drm/mediatek: Add missing plane settings when async update
2023-09-18 7:00 ` [PATCH 1/1] drm/mediatek: " Hsiao Chien Sung
@ 2023-09-18 8:56 ` AngeloGioacchino Del Regno
2023-10-26 1:42 ` CK Hu (胡俊光)
1 sibling, 0 replies; 4+ messages in thread
From: AngeloGioacchino Del Regno @ 2023-09-18 8:56 UTC (permalink / raw)
To: Hsiao Chien Sung, CK Hu
Cc: Bibby Hsieh, David Airlie, Daniel Vetter, Matthias Brugger,
Philipp Zabel, dri-devel, linux-mediatek, linux-kernel,
linux-arm-kernel
Il 18/09/23 09:00, Hsiao Chien Sung ha scritto:
> Fix an issue that plane coordinate was not saved when
> calling async update.
>
> Fixes: 920fffcc8912 ("drm/mediatek: update cursors by using async atomic update")
>
> Signed-off-by: Hsiao Chien Sung <shawn.sung@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] drm/mediatek: Add missing plane settings when async update
2023-09-18 7:00 ` [PATCH 1/1] drm/mediatek: " Hsiao Chien Sung
2023-09-18 8:56 ` AngeloGioacchino Del Regno
@ 2023-10-26 1:42 ` CK Hu (胡俊光)
1 sibling, 0 replies; 4+ messages in thread
From: CK Hu (胡俊光) @ 2023-10-26 1:42 UTC (permalink / raw)
To: Shawn Sung (宋孝謙), angelogioacchino.delregno
Cc: linux-kernel, linux-mediatek,
Bibby Hsieh (謝濟遠),
daniel, p.zabel, dri-devel, airlied, linux-arm-kernel,
matthias.bgg
Hi, Hsiao-chien:
On Mon, 2023-09-18 at 15:00 +0800, Hsiao Chien Sung wrote:
> Fix an issue that plane coordinate was not saved when
> calling async update.
Reviewed-by: CK Hu <ck.hu@mediatek.com>
>
> Fixes: 920fffcc8912 ("drm/mediatek: update cursors by using async
> atomic update")
>
> Signed-off-by: Hsiao Chien Sung <shawn.sung@mediatek.com>
> ---
> drivers/gpu/drm/mediatek/mtk_drm_plane.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_plane.c
> b/drivers/gpu/drm/mediatek/mtk_drm_plane.c
> index db2f70ae060d..58e9f93c38c4 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_plane.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_plane.c
> @@ -206,6 +206,8 @@ static void mtk_plane_atomic_async_update(struct
> drm_plane *plane,
> plane->state->src_y = new_state->src_y;
> plane->state->src_h = new_state->src_h;
> plane->state->src_w = new_state->src_w;
> + plane->state->dst.x1 = new_state->dst.x1;
> + plane->state->dst.y1 = new_state->dst.y1;
> swap(plane->state->fb, new_state->fb);
>
> mtk_plane_update_new_state(new_state, new_plane_state);
> --
> 2.18.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-10-26 1:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-18 7:00 [PATCH 0/1] Add missing plane settings when async update Hsiao Chien Sung
2023-09-18 7:00 ` [PATCH 1/1] drm/mediatek: " Hsiao Chien Sung
2023-09-18 8:56 ` AngeloGioacchino Del Regno
2023-10-26 1:42 ` CK Hu (胡俊光)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®