From: Dan Carpenter <dan.carpenter@linaro.org>
To: Dave Penkler <dpenkler@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Modernize gpib_interface_t initialization and make static
Date: Wed, 8 Jan 2025 20:14:13 +0300 [thread overview]
Message-ID: <0518fba7-7c35-4a91-9354-6a32a35f2ed7@stanley.mountain> (raw)
In-Reply-To: <20250108152942.17687-1-dpenkler@gmail.com>
The subsystem prefix is missing in the subject.
On Wed, Jan 08, 2025 at 04:29:42PM +0100, Dave Penkler wrote:
> All interface drivers were using the old style initialization of
> this struct
>
> field : value;
>
> This generated the followng sparse warning, for example:
> agilent_82357a/agilent_82357a.c:1492:1: warning: obsolete struct initializer, use C99 syntax
>
> Change the initialization to use the C99 syntax
>
> .field = value;
>
> This also resolves the checkpatch constraint of no indentation.
>
> These structs were also not declared as static, unnecessarily polluting
> the symbol namespace and generating the following sparse warnings,
> for example:
>
> agilent_82357a/agilent_82357a.c:1465:18: warning: symbol 'agilent_82357a_gpib_interface' was not declared. Should it be static?
>
> Declare them as static and remove any conflicting extern declarations
> in the corresponding include files.
The c99 initializers and the making the structs static would ideally be
done in separate patches. Splitting up patches is kind of more art than
science...
regards,
dan carpenter
prev parent reply other threads:[~2025-01-08 17:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-08 15:29 Dave Penkler
2025-01-08 17:14 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0518fba7-7c35-4a91-9354-6a32a35f2ed7@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=dpenkler@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®