* [PATCH v2 0/4] amr64: dts: exynos: add dedicated SYSREG compatibles to Exynos850 and Exynosautov9 [not found] <CGME20221207105040epcas5p187cb82e00083eb7106f78264a76a866b@epcas5p1.samsung.com> @ 2022-12-07 10:50 ` Sriranjani P [not found] ` <CGME20221207105043epcas5p306086213835a5287f39de9016dcd43d2@epcas5p3.samsung.com> ` (3 more replies) 0 siblings, 4 replies; 8+ messages in thread From: Sriranjani P @ 2022-12-07 10:50 UTC (permalink / raw) To: robh+dt, krzysztof.kozlowski+dt, devicetree, alim.akhtar, pankaj.dubey, ravi.patel Cc: linux-kernel, linux-arm-kernel, linux-samsung-soc, Sriranjani P Exynos850 and Exynosautov9 has several different SYSREGs, so use dedicated compatibles for them in dtsi file and add respective compatible in the samsung exynos devicetree binding document. Changes since v1: 1. As per Krzysztof comment made an enum of deprecated compatibles. Sriranjani P (4): dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynos850 arm64: dts: exynos: add dedicated SYSREG compatibles to Exynos850 dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynosautov9 arm64: dts: exynos: add dedicated SYSREG compatibles to Exynosautov9 .../soc/samsung/samsung,exynos-sysreg.yaml | 24 +++++++++++++++---- arch/arm64/boot/dts/exynos/exynos850.dtsi | 6 +++-- arch/arm64/boot/dts/exynos/exynosautov9.dtsi | 9 ++++--- 3 files changed, 30 insertions(+), 9 deletions(-) -- 2.17.1 ^ permalink raw reply [flat|nested] 8+ messages in thread
[parent not found: <CGME20221207105043epcas5p306086213835a5287f39de9016dcd43d2@epcas5p3.samsung.com>]
* [PATCH v2 1/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynos850 [not found] ` <CGME20221207105043epcas5p306086213835a5287f39de9016dcd43d2@epcas5p3.samsung.com> @ 2022-12-07 10:50 ` Sriranjani P 2022-12-09 21:10 ` Rob Herring 0 siblings, 1 reply; 8+ messages in thread From: Sriranjani P @ 2022-12-07 10:50 UTC (permalink / raw) To: robh+dt, krzysztof.kozlowski+dt, devicetree, alim.akhtar, pankaj.dubey, ravi.patel Cc: linux-kernel, linux-arm-kernel, linux-samsung-soc, Sriranjani P Exynos850 has two different SYSREGs, hence add dedicated compatibles for them and deprecate usage of generic Exynos850 compatible alone. Signed-off-by: Sriranjani P <sriranjani.p@samsung.com> --- .../soc/samsung/samsung,exynos-sysreg.yaml | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml index 4954790eda6c..a37452965100 100644 --- a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml +++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml @@ -17,7 +17,6 @@ properties: - samsung,exynos3-sysreg - samsung,exynos4-sysreg - samsung,exynos5-sysreg - - samsung,exynos850-sysreg - samsung,exynosautov9-sysreg - tesla,fsd-cam-sysreg - tesla,fsd-fsys0-sysreg @@ -33,9 +32,17 @@ properties: - const: samsung,exynos5433-sysreg - const: syscon - items: - - const: samsung,exynos5433-sysreg + - enum: + - const: samsung,exynos5433-sysreg + - const: samsung,exynos850-sysreg + - const: syscon + deprecated: true + - items: + - enum: + - samsung,exynos850-cmgp-sysreg + - samsung,exynos850-peri-sysreg + - const: samsung,exynos850-sysreg - const: syscon - deprecated: true reg: maxItems: 1 @@ -53,6 +60,8 @@ allOf: compatible: contains: enum: + - samsung,exynos850-cmgp-sysreg + - samsung,exynos850-peri-sysreg - samsung,exynos850-sysreg then: required: -- 2.17.1 ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynos850 2022-12-07 10:50 ` [PATCH v2 1/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynos850 Sriranjani P @ 2022-12-09 21:10 ` Rob Herring 2022-12-14 4:41 ` Sriranjani P 0 siblings, 1 reply; 8+ messages in thread From: Rob Herring @ 2022-12-09 21:10 UTC (permalink / raw) To: Sriranjani P Cc: krzysztof.kozlowski+dt, devicetree, alim.akhtar, pankaj.dubey, ravi.patel, linux-kernel, linux-arm-kernel, linux-samsung-soc On Wed, Dec 07, 2022 at 04:20:29PM +0530, Sriranjani P wrote: > Exynos850 has two different SYSREGs, hence add dedicated compatibles for > them and deprecate usage of generic Exynos850 compatible alone. > > Signed-off-by: Sriranjani P <sriranjani.p@samsung.com> > --- > .../soc/samsung/samsung,exynos-sysreg.yaml | 15 ++++++++++++--- > 1 file changed, 12 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml > index 4954790eda6c..a37452965100 100644 > --- a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml > +++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml > @@ -17,7 +17,6 @@ properties: > - samsung,exynos3-sysreg > - samsung,exynos4-sysreg > - samsung,exynos5-sysreg > - - samsung,exynos850-sysreg > - samsung,exynosautov9-sysreg > - tesla,fsd-cam-sysreg > - tesla,fsd-fsys0-sysreg > @@ -33,9 +32,17 @@ properties: > - const: samsung,exynos5433-sysreg > - const: syscon > - items: > - - const: samsung,exynos5433-sysreg > + - enum: > + - const: samsung,exynos5433-sysreg This says the compatible entry is "const: samsung,exynos5433-sysreg". That should be a schema warning. You did test this, right? Rob ^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH v2 1/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynos850 2022-12-09 21:10 ` Rob Herring @ 2022-12-14 4:41 ` Sriranjani P 2022-12-14 8:06 ` Krzysztof Kozlowski 0 siblings, 1 reply; 8+ messages in thread From: Sriranjani P @ 2022-12-14 4:41 UTC (permalink / raw) To: 'Rob Herring' Cc: krzysztof.kozlowski+dt, devicetree, alim.akhtar, pankaj.dubey, ravi.patel, linux-kernel, linux-arm-kernel, linux-samsung-soc > -----Original Message----- > From: Rob Herring [mailto:robh@kernel.org] > Sent: 10 December 2022 02:40 > To: Sriranjani P <sriranjani.p@samsung.com> > Cc: krzysztof.kozlowski+dt@linaro.org; devicetree@vger.kernel.org; > alim.akhtar@samsung.com; pankaj.dubey@samsung.com; > ravi.patel@samsung.com; linux-kernel@vger.kernel.org; linux-arm- > kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org > Subject: Re: [PATCH v2 1/4] dt-bindings: soc: samsung: exynos-sysreg: add > dedicated SYSREG compatibles to Exynos850 > > On Wed, Dec 07, 2022 at 04:20:29PM +0530, Sriranjani P wrote: > > Exynos850 has two different SYSREGs, hence add dedicated compatibles > > for them and deprecate usage of generic Exynos850 compatible alone. > > > > Signed-off-by: Sriranjani P <sriranjani.p@samsung.com> > > --- > > .../soc/samsung/samsung,exynos-sysreg.yaml | 15 ++++++++++++--- > > 1 file changed, 12 insertions(+), 3 deletions(-) > > > > diff --git > > a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos- > sysreg. > > yaml > > b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos- > sysreg. > > yaml index 4954790eda6c..a37452965100 100644 > > --- > > a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos- > sysreg. > > yaml > > +++ > b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sys > > +++ reg.yaml > > @@ -17,7 +17,6 @@ properties: > > - samsung,exynos3-sysreg > > - samsung,exynos4-sysreg > > - samsung,exynos5-sysreg > > - - samsung,exynos850-sysreg > > - samsung,exynosautov9-sysreg > > - tesla,fsd-cam-sysreg > > - tesla,fsd-fsys0-sysreg @@ -33,9 +32,17 @@ properties: > > - const: samsung,exynos5433-sysreg > > - const: syscon > > - items: > > - - const: samsung,exynos5433-sysreg > > + - enum: > > + - const: samsung,exynos5433-sysreg > > This says the compatible entry is "const: samsung,exynos5433-sysreg". > > That should be a schema warning. You did test this, right? Thanks for pointing it out, somehow dtbs check not showed any error. Will fix it in the next version. > > Rob ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynos850 2022-12-14 4:41 ` Sriranjani P @ 2022-12-14 8:06 ` Krzysztof Kozlowski 0 siblings, 0 replies; 8+ messages in thread From: Krzysztof Kozlowski @ 2022-12-14 8:06 UTC (permalink / raw) To: Sriranjani P, 'Rob Herring' Cc: krzysztof.kozlowski+dt, devicetree, alim.akhtar, pankaj.dubey, ravi.patel, linux-kernel, linux-arm-kernel, linux-samsung-soc On 14/12/2022 05:41, Sriranjani P wrote: > > >> -----Original Message----- >> From: Rob Herring [mailto:robh@kernel.org] >> Sent: 10 December 2022 02:40 >> To: Sriranjani P <sriranjani.p@samsung.com> >> Cc: krzysztof.kozlowski+dt@linaro.org; devicetree@vger.kernel.org; >> alim.akhtar@samsung.com; pankaj.dubey@samsung.com; >> ravi.patel@samsung.com; linux-kernel@vger.kernel.org; linux-arm- >> kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org >> Subject: Re: [PATCH v2 1/4] dt-bindings: soc: samsung: exynos-sysreg: add >> dedicated SYSREG compatibles to Exynos850 >> >> On Wed, Dec 07, 2022 at 04:20:29PM +0530, Sriranjani P wrote: >>> Exynos850 has two different SYSREGs, hence add dedicated compatibles >>> for them and deprecate usage of generic Exynos850 compatible alone. >>> >>> Signed-off-by: Sriranjani P <sriranjani.p@samsung.com> >>> --- >>> .../soc/samsung/samsung,exynos-sysreg.yaml | 15 ++++++++++++--- >>> 1 file changed, 12 insertions(+), 3 deletions(-) >>> >>> diff --git >>> a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos- >> sysreg. >>> yaml >>> b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos- >> sysreg. >>> yaml index 4954790eda6c..a37452965100 100644 >>> --- >>> a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos- >> sysreg. >>> yaml >>> +++ >> b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sys >>> +++ reg.yaml >>> @@ -17,7 +17,6 @@ properties: >>> - samsung,exynos3-sysreg >>> - samsung,exynos4-sysreg >>> - samsung,exynos5-sysreg >>> - - samsung,exynos850-sysreg >>> - samsung,exynosautov9-sysreg >>> - tesla,fsd-cam-sysreg >>> - tesla,fsd-fsys0-sysreg @@ -33,9 +32,17 @@ properties: >>> - const: samsung,exynos5433-sysreg >>> - const: syscon >>> - items: >>> - - const: samsung,exynos5433-sysreg >>> + - enum: >>> + - const: samsung,exynos5433-sysreg >> >> This says the compatible entry is "const: samsung,exynos5433-sysreg". >> >> That should be a schema warning. You did test this, right? > Thanks for pointing it out, somehow dtbs check not showed any error. Will > fix it in the next version. To test binding please run dt_binding_check instead. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 8+ messages in thread
[parent not found: <CGME20221207105046epcas5p133c477b31f060d72e52c02566fa7683a@epcas5p1.samsung.com>]
* [PATCH v2 2/4] arm64: dts: exynos: add dedicated SYSREG compatibles to Exynos850 [not found] ` <CGME20221207105046epcas5p133c477b31f060d72e52c02566fa7683a@epcas5p1.samsung.com> @ 2022-12-07 10:50 ` Sriranjani P 0 siblings, 0 replies; 8+ messages in thread From: Sriranjani P @ 2022-12-07 10:50 UTC (permalink / raw) To: robh+dt, krzysztof.kozlowski+dt, devicetree, alim.akhtar, pankaj.dubey, ravi.patel Cc: linux-kernel, linux-arm-kernel, linux-samsung-soc, Sriranjani P Exynos850 has two different SYSREGs, so use dedicated compatibles for them. Signed-off-by: Sriranjani P <sriranjani.p@samsung.com> --- arch/arm64/boot/dts/exynos/exynos850.dtsi | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/exynos/exynos850.dtsi b/arch/arm64/boot/dts/exynos/exynos850.dtsi index c61441f3a89a..a38fe5129937 100644 --- a/arch/arm64/boot/dts/exynos/exynos850.dtsi +++ b/arch/arm64/boot/dts/exynos/exynos850.dtsi @@ -549,13 +549,15 @@ }; sysreg_peri: syscon@10020000 { - compatible = "samsung,exynos850-sysreg", "syscon"; + compatible = "samsung,exynos850-peri-sysreg", + "samsung,exynos850-sysreg", "syscon"; reg = <0x10020000 0x10000>; clocks = <&cmu_peri CLK_GOUT_SYSREG_PERI_PCLK>; }; sysreg_cmgp: syscon@11c20000 { - compatible = "samsung,exynos850-sysreg", "syscon"; + compatible = "samsung,exynos850-cmgp-sysreg", + "samsung,exynos850-sysreg", "syscon"; reg = <0x11c20000 0x10000>; clocks = <&cmu_cmgp CLK_GOUT_SYSREG_CMGP_PCLK>; }; -- 2.17.1 ^ permalink raw reply [flat|nested] 8+ messages in thread
[parent not found: <CGME20221207105049epcas5p305d9c9c22c164ba7e88f93cc59b8b865@epcas5p3.samsung.com>]
* [PATCH v2 3/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynosautov9 [not found] ` <CGME20221207105049epcas5p305d9c9c22c164ba7e88f93cc59b8b865@epcas5p3.samsung.com> @ 2022-12-07 10:50 ` Sriranjani P 0 siblings, 0 replies; 8+ messages in thread From: Sriranjani P @ 2022-12-07 10:50 UTC (permalink / raw) To: robh+dt, krzysztof.kozlowski+dt, devicetree, alim.akhtar, pankaj.dubey, ravi.patel Cc: linux-kernel, linux-arm-kernel, linux-samsung-soc, Sriranjani P Exynosautov9 has several different SYSREGs, so use dedicated compatibles for them and deprecate usage of generic Exynosautov9 compatible alone. Signed-off-by: Sriranjani P <sriranjani.p@samsung.com> --- .../bindings/soc/samsung/samsung,exynos-sysreg.yaml | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml index a37452965100..ffca0c118bcf 100644 --- a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml +++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml @@ -17,7 +17,6 @@ properties: - samsung,exynos3-sysreg - samsung,exynos4-sysreg - samsung,exynos5-sysreg - - samsung,exynosautov9-sysreg - tesla,fsd-cam-sysreg - tesla,fsd-fsys0-sysreg - tesla,fsd-fsys1-sysreg @@ -35,6 +34,7 @@ properties: - enum: - const: samsung,exynos5433-sysreg - const: samsung,exynos850-sysreg + - const: samsung,exynosautov9-sysreg - const: syscon deprecated: true - items: @@ -43,6 +43,13 @@ properties: - samsung,exynos850-peri-sysreg - const: samsung,exynos850-sysreg - const: syscon + - items: + - enum: + - samsung,exynosautov9-fsys2-sysreg + - samsung,exynosautov9-peric0-sysreg + - samsung,exynosautov9-peric1-sysreg + - const: samsung,exynosautov9-sysreg + - const: syscon reg: maxItems: 1 -- 2.17.1 ^ permalink raw reply [flat|nested] 8+ messages in thread
[parent not found: <CGME20221207105052epcas5p1473e38c140d38909c3c98d892bc8a4c4@epcas5p1.samsung.com>]
* [PATCH v2 4/4] arm64: dts: exynos: add dedicated SYSREG compatibles to Exynosautov9 [not found] ` <CGME20221207105052epcas5p1473e38c140d38909c3c98d892bc8a4c4@epcas5p1.samsung.com> @ 2022-12-07 10:50 ` Sriranjani P 0 siblings, 0 replies; 8+ messages in thread From: Sriranjani P @ 2022-12-07 10:50 UTC (permalink / raw) To: robh+dt, krzysztof.kozlowski+dt, devicetree, alim.akhtar, pankaj.dubey, ravi.patel Cc: linux-kernel, linux-arm-kernel, linux-samsung-soc, Sriranjani P Exynosautov9 has several different SYSREGs, so use dedicated compatibles for them. Signed-off-by: Sriranjani P <sriranjani.p@samsung.com> --- arch/arm64/boot/dts/exynos/exynosautov9.dtsi | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/exynos/exynosautov9.dtsi b/arch/arm64/boot/dts/exynos/exynosautov9.dtsi index 5dc361734cfe..d3c5cdeff47f 100644 --- a/arch/arm64/boot/dts/exynos/exynosautov9.dtsi +++ b/arch/arm64/boot/dts/exynos/exynosautov9.dtsi @@ -370,17 +370,20 @@ }; syscon_fsys2: syscon@17c20000 { - compatible = "samsung,exynosautov9-sysreg", "syscon"; + compatible = "samsung,exynosautov9-fsys2-sysreg", + "samsung,exynosautov9-sysreg", "syscon"; reg = <0x17c20000 0x1000>; }; syscon_peric0: syscon@10220000 { - compatible = "samsung,exynosautov9-sysreg", "syscon"; + compatible = "samsung,exynosautov9-peric0-sysreg", + "samsung,exynosautov9-sysreg", "syscon"; reg = <0x10220000 0x2000>; }; syscon_peric1: syscon@10820000 { - compatible = "samsung,exynosautov9-sysreg", "syscon"; + compatible = "samsung,exynosautov9-peric1-sysreg", + "samsung,exynosautov9-sysreg", "syscon"; reg = <0x10820000 0x2000>; }; -- 2.17.1 ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-12-14 8:06 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20221207105040epcas5p187cb82e00083eb7106f78264a76a866b@epcas5p1.samsung.com>
2022-12-07 10:50 ` [PATCH v2 0/4] amr64: dts: exynos: add dedicated SYSREG compatibles to Exynos850 and Exynosautov9 Sriranjani P
[not found] ` <CGME20221207105043epcas5p306086213835a5287f39de9016dcd43d2@epcas5p3.samsung.com>
2022-12-07 10:50 ` [PATCH v2 1/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynos850 Sriranjani P
2022-12-09 21:10 ` Rob Herring
2022-12-14 4:41 ` Sriranjani P
2022-12-14 8:06 ` Krzysztof Kozlowski
[not found] ` <CGME20221207105046epcas5p133c477b31f060d72e52c02566fa7683a@epcas5p1.samsung.com>
2022-12-07 10:50 ` [PATCH v2 2/4] arm64: dts: exynos: " Sriranjani P
[not found] ` <CGME20221207105049epcas5p305d9c9c22c164ba7e88f93cc59b8b865@epcas5p3.samsung.com>
2022-12-07 10:50 ` [PATCH v2 3/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynosautov9 Sriranjani P
[not found] ` <CGME20221207105052epcas5p1473e38c140d38909c3c98d892bc8a4c4@epcas5p1.samsung.com>
2022-12-07 10:50 ` [PATCH v2 4/4] arm64: dts: exynos: " Sriranjani P
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®