From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Praveen Talari <praveen.talari@oss.qualcomm.com>,
Andi Shyti <andi.shyti@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Mukesh Kumar Savaliya <mukesh.savaliya@oss.qualcomm.com>,
Viken Dadhaniya <viken.dadhaniya@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
bjorn.andersson@oss.qualcomm.com,
dmitry.baryshkov@oss.qualcomm.com
Cc: prasad.sodagudi@oss.qualcomm.com, quic_vtanuku@quicinc.com,
aniket.randive@oss.qualcomm.com,
chandana.chiluveru@oss.qualcomm.com,
jyothi.seerapu@oss.qualcomm.com, chiluka.harish@oss.qualcomm.com
Subject: Re: [PATCH v5 05/13] soc: qcom: geni-se: Add resources activation/deactivation helpers
Date: Tue, 17 Feb 2026 13:02:05 +0100 [thread overview]
Message-ID: <05340972-2013-45b6-801c-7e52fe48cef0@oss.qualcomm.com> (raw)
In-Reply-To: <20260206174112.4149893-6-praveen.talari@oss.qualcomm.com>
On 2/6/26 6:41 PM, Praveen Talari wrote:
> The GENI SE protocol drivers (I2C, SPI, UART) implement similar resource
> activation/deactivation sequences independently, leading to code
> duplication.
>
> Introduce geni_se_resources_activate()/geni_se_resources_deactivate() to
> power on/off resources.The activate function enables ICC, clocks, and TLMM
> whereas the deactivate function disables resources in reverse order
> including OPP rate reset, clocks, ICC and TLMM.
>
> Signed-off-by: Praveen Talari <praveen.talari@oss.qualcomm.com>
> ---
> v4 -> v5
> Konrad
> - updated return value as 0 for geni_se_resources_activate().
I would really like you to include that kerneldoc bit I mentioned it
https://lore.kernel.org/linux-arm-msm/ff9a2aa3-1b2b-4001-82ce-198c61a4b637@oss.qualcomm.com/
Konrad
next prev parent reply other threads:[~2026-02-17 12:02 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-06 17:40 [PATCH v5 00/13] Enable I2C on SA8255p Qualcomm platforms Praveen Talari
2026-02-06 17:41 ` [PATCH v5 01/13] soc: qcom: geni-se: Refactor geni_icc_get() and make qup-memory ICC path optional Praveen Talari
2026-02-06 17:41 ` [PATCH v5 02/13] soc: qcom: geni-se: Add geni_icc_set_bw_ab() function Praveen Talari
2026-02-06 17:41 ` [PATCH v5 03/13] soc: qcom: geni-se: Introduce helper API for resource initialization Praveen Talari
2026-02-06 17:41 ` [PATCH v5 04/13] soc: qcom: geni-se: Handle core clk in geni_se_clks_off() and geni_se_clks_on() Praveen Talari
2026-02-06 17:41 ` [PATCH v5 05/13] soc: qcom: geni-se: Add resources activation/deactivation helpers Praveen Talari
2026-02-17 12:02 ` Konrad Dybcio [this message]
2026-02-23 13:39 ` Praveen Talari
2026-02-25 14:38 ` Konrad Dybcio
2026-02-06 17:41 ` [PATCH v5 06/13] soc: qcom: geni-se: Introduce helper API for attaching power domains Praveen Talari
2026-02-17 11:39 ` Konrad Dybcio
2026-02-19 14:58 ` Praveen Talari
2026-02-19 15:07 ` Konrad Dybcio
2026-02-06 17:41 ` [PATCH v5 07/13] soc: qcom: geni-se: Introduce helper APIs for performance control Praveen Talari
2026-02-25 14:28 ` Konrad Dybcio
2026-02-26 3:52 ` Praveen Talari
2026-02-06 17:41 ` [PATCH v5 08/13] dt-bindings: i2c: Describe SA8255p Praveen Talari
2026-02-06 17:41 ` [PATCH v5 09/13] i2c: qcom-geni: Isolate serial engine setup Praveen Talari
2026-02-06 17:41 ` [PATCH v5 10/13] i2c: qcom-geni: Move resource initialization to separate function Praveen Talari
2026-02-06 17:41 ` [PATCH v5 11/13] i2c: qcom-geni: Use resources helper APIs in runtime PM functions Praveen Talari
2026-02-17 11:55 ` Konrad Dybcio
2026-02-06 17:41 ` [PATCH v5 12/13] i2c: qcom-geni: Store of_device_id data in driver private struct Praveen Talari
2026-02-17 11:46 ` Konrad Dybcio
2026-02-19 14:48 ` Praveen Talari
2026-02-06 17:41 ` [PATCH v5 13/13] i2c: qcom-geni: Enable I2C on SA8255p Qualcomm platforms Praveen Talari
2026-02-17 11:50 ` Konrad Dybcio
2026-02-19 14:46 ` Praveen Talari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05340972-2013-45b6-801c-7e52fe48cef0@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=aniket.randive@oss.qualcomm.com \
--cc=bjorn.andersson@oss.qualcomm.com \
--cc=chandana.chiluveru@oss.qualcomm.com \
--cc=chiluka.harish@oss.qualcomm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=jyothi.seerapu@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mukesh.savaliya@oss.qualcomm.com \
--cc=prasad.sodagudi@oss.qualcomm.com \
--cc=praveen.talari@oss.qualcomm.com \
--cc=quic_vtanuku@quicinc.com \
--cc=robh@kernel.org \
--cc=viken.dadhaniya@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®