mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: socfpga: agilex: add emmc support
@ 2026-01-12  3:35 tzeyee.ng
  2026-01-13 17:54 ` Dinh Nguyen
  2026-01-13 17:57 ` Krzysztof Kozlowski
  0 siblings, 2 replies; 4+ messages in thread
From: tzeyee.ng @ 2026-01-12  3:35 UTC (permalink / raw)
  To: Dinh Nguyen, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	devicetree, linux-kernel

From: Ng Tze Yee <tzeyee.ng@altera.com>

The Agilex devkit supports a separate NAND/eMMC daughter card. The
NAND/eMMC daughter card replaces the SDMMC slot that is on the default
daughter card and thus requires a separate board dts file.

New eMMC dts which is based on the existing NAND dts, which is
needed to comply with spec in which eMMC board ID is designated as 2.

Signed-off-by: Ng Tze Yee <tzeyee.ng@altera.com>
---
 arch/arm64/boot/dts/intel/Makefile            |   1 +
 .../dts/intel/socfpga_agilex_socdk_emmc.dts   | 105 ++++++++++++++++++
 2 files changed, 106 insertions(+)
 create mode 100644 arch/arm64/boot/dts/intel/socfpga_agilex_socdk_emmc.dts

diff --git a/arch/arm64/boot/dts/intel/Makefile b/arch/arm64/boot/dts/intel/Makefile
index a117268267ee..6f4da79725de 100644
--- a/arch/arm64/boot/dts/intel/Makefile
+++ b/arch/arm64/boot/dts/intel/Makefile
@@ -1,6 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0-only
 dtb-$(CONFIG_ARCH_INTEL_SOCFPGA) += socfpga_agilex_n6000.dtb \
 				socfpga_agilex_socdk.dtb \
+				socfpga_agilex_socdk_emmc.dtb \
 				socfpga_agilex_socdk_nand.dtb \
 				socfpga_agilex3_socdk.dtb \
 				socfpga_agilex5_socdk.dtb \
diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex_socdk_emmc.dts b/arch/arm64/boot/dts/intel/socfpga_agilex_socdk_emmc.dts
new file mode 100644
index 000000000000..5caf231de370
--- /dev/null
+++ b/arch/arm64/boot/dts/intel/socfpga_agilex_socdk_emmc.dts
@@ -0,0 +1,105 @@
+// SPDX-License-Identifier:     GPL-2.0
+/*
+ * Copyright (C) 2026, Intel Corporation
+ */
+#include "socfpga_agilex.dtsi"
+
+/ {
+	model = "SoCFPGA Agilex SoCDK";
+	compatible = "intel,socfpga-agilex-socdk", "intel,socfpga-agilex";
+
+	aliases {
+		serial0 = &uart0;
+		ethernet0 = &gmac0;
+		ethernet1 = &gmac1;
+		ethernet2 = &gmac2;
+	};
+
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
+	leds {
+		compatible = "gpio-leds";
+		led0 {
+			label = "hps_led0";
+			gpios = <&portb 20 GPIO_ACTIVE_HIGH>;
+		};
+
+		led1 {
+			label = "hps_led1";
+			gpios = <&portb 19 GPIO_ACTIVE_HIGH>;
+		};
+
+		led2 {
+			label = "hps_led2";
+			gpios = <&portb 21 GPIO_ACTIVE_HIGH>;
+		};
+	};
+
+	memory@80000000 {
+		device_type = "memory";
+		/* We expect the bootloader to fill in the reg */
+		reg = <0 0x80000000 0 0>;
+	};
+};
+
+&gpio1 {
+	status = "okay";
+};
+
+&gmac2 {
+	status = "okay";
+	/* PHY delays is configured via skew properties */
+	phy-mode = "rgmii";
+	phy-handle = <&phy0>;
+
+	max-frame-size = <9000>;
+
+	mdio0 {
+		#address-cells = <1>;
+		#size-cells = <0>;
+		compatible = "snps,dwmac-mdio";
+		phy0: ethernet-phy@0 {
+			reg = <4>;
+
+			txd0-skew-ps = <0>; /* -420ps */
+			txd1-skew-ps = <0>; /* -420ps */
+			txd2-skew-ps = <0>; /* -420ps */
+			txd3-skew-ps = <0>; /* -420ps */
+			rxd0-skew-ps = <420>; /* 0ps */
+			rxd1-skew-ps = <420>; /* 0ps */
+			rxd2-skew-ps = <420>; /* 0ps */
+			rxd3-skew-ps = <420>; /* 0ps */
+			txen-skew-ps = <0>; /* -420ps */
+			txc-skew-ps = <900>; /* 0ps */
+			rxdv-skew-ps = <420>; /* 0ps */
+			rxc-skew-ps = <1680>; /* 780ps */
+		};
+	};
+};
+
+&mmc {
+	status = "okay";
+	cap-mmc-highspeed;
+	broken-cd;
+	bus-width = <4>;
+	clk-phase-sd-hs = <0>, <135>;
+};
+
+&osc1 {
+	clock-frequency = <25000000>;
+};
+
+&uart0 {
+	status = "okay";
+};
+
+&usb0 {
+	status = "okay";
+	disable-over-current;
+};
+
+&watchdog0 {
+	status = "okay";
+};
-- 
2.25.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: dts: socfpga: agilex: add emmc support
  2026-01-12  3:35 [PATCH] arm64: dts: socfpga: agilex: add emmc support tzeyee.ng
@ 2026-01-13 17:54 ` Dinh Nguyen
  2026-01-14  8:19   ` Ng, Tze Yee
  2026-01-13 17:57 ` Krzysztof Kozlowski
  1 sibling, 1 reply; 4+ messages in thread
From: Dinh Nguyen @ 2026-01-13 17:54 UTC (permalink / raw)
  To: tzeyee.ng, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	devicetree, linux-kernel



On 1/11/26 21:35, tzeyee.ng@altera.com wrote:
> From: Ng Tze Yee <tzeyee.ng@altera.com>
> 
> The Agilex devkit supports a separate NAND/eMMC daughter card. The
> NAND/eMMC daughter card replaces the SDMMC slot that is on the default
> daughter card and thus requires a separate board dts file.
> 
> New eMMC dts which is based on the existing NAND dts, which is
> needed to comply with spec in which eMMC board ID is designated as 2.
> 

Can you elaborate what you mean by this? I don't see a change that is 
related.

Dinh

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: dts: socfpga: agilex: add emmc support
  2026-01-12  3:35 [PATCH] arm64: dts: socfpga: agilex: add emmc support tzeyee.ng
  2026-01-13 17:54 ` Dinh Nguyen
@ 2026-01-13 17:57 ` Krzysztof Kozlowski
  1 sibling, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2026-01-13 17:57 UTC (permalink / raw)
  To: tzeyee.ng, Dinh Nguyen, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, devicetree, linux-kernel

On 12/01/2026 04:35, tzeyee.ng@altera.com wrote:
> diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex_socdk_emmc.dts b/arch/arm64/boot/dts/intel/socfpga_agilex_socdk_emmc.dts
> new file mode 100644
> index 000000000000..5caf231de370
> --- /dev/null
> +++ b/arch/arm64/boot/dts/intel/socfpga_agilex_socdk_emmc.dts
> @@ -0,0 +1,105 @@
> +// SPDX-License-Identifier:     GPL-2.0

Please fix spacing of your tag.

> +/*
> + * Copyright (C) 2026, Intel Corporation
> + */
> +#include "socfpga_agilex.dtsi"
> +
> +/ {
> +	model = "SoCFPGA Agilex SoCDK";
> +	compatible = "intel,socfpga-agilex-socdk", "intel,socfpga-agilex";

Where are the bindings? Where is new compatible?

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: dts: socfpga: agilex: add emmc support
  2026-01-13 17:54 ` Dinh Nguyen
@ 2026-01-14  8:19   ` Ng, Tze Yee
  0 siblings, 0 replies; 4+ messages in thread
From: Ng, Tze Yee @ 2026-01-14  8:19 UTC (permalink / raw)
  To: Dinh Nguyen, Ng, Tze Yee, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, devicetree, linux-kernel

On 14/1/2026 1:54 am, Dinh Nguyen wrote:
> [CAUTION: This email is from outside your organization. Unless you trust 
> the sender, do not click on links or open attachments as it may be a 
> fraudulent email attempting to steal your information and/or compromise 
> your computer.]
> 
> On 1/11/26 21:35, tzeyee.ng@altera.com wrote:
>> From: Ng Tze Yee <tzeyee.ng@altera.com>
>>
>> The Agilex devkit supports a separate NAND/eMMC daughter card. The
>> NAND/eMMC daughter card replaces the SDMMC slot that is on the default
>> daughter card and thus requires a separate board dts file.
>>
>> New eMMC dts which is based on the existing NAND dts, which is
>> needed to comply with spec in which eMMC board ID is designated as 2.
>>
> 
> Can you elaborate what you mean by this? I don't see a change that is
> related.
> 
> Dinh
The board ID is transparent to Linux kernel. Will drop the board ID 
reference from commit.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-01-14  8:19 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-01-12  3:35 [PATCH] arm64: dts: socfpga: agilex: add emmc support tzeyee.ng
2026-01-13 17:54 ` Dinh Nguyen
2026-01-14  8:19   ` Ng, Tze Yee
2026-01-13 17:57 ` Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®