* [PATCH] checkpatch: Validate SPDX license with spdxcheck.py
@ 2018-07-24 17:04 Joe Perches
2018-07-24 17:29 ` Rob Herring
0 siblings, 1 reply; 2+ messages in thread
From: Joe Perches @ 2018-07-24 17:04 UTC (permalink / raw)
To: Andrew Morton
Cc: Thomas Gleixner, LKML, Greg Kroah-Hartman, Rob Herring, Andy Whitcroft
Use the existing scripts/spdxcheck.py to validate any
SPDX-License-Identifier found in line 1 or 2 of patches or files.
Miscellanea:
o Properly indent the existing SPDX-License-Identifier block.
Signed-off-by: Joe Perches <joe@perches.com>
---
scripts/checkpatch.pl | 20 ++++++++++++++++++--
1 file changed, 18 insertions(+), 2 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 34e4683de7a3..4523dd6d0476 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -849,6 +849,16 @@ sub is_maintained_obsolete {
return $status =~ /obsolete/i;
}
+sub is_SPDX_License_valid {
+ my ($license) = @_;
+
+ return 1 if (!$tree || which("python") eq "" || !(-e "$root/scripts/spdxcheck.py"));
+
+ my $status = `echo "$license" | python $root/scripts/spdxcheck.py -`;
+ return 0 if ($status ne "");
+ return 1;
+}
+
my $camelcase_seeded = 0;
sub seed_camelcase_includes {
return if ($camelcase_seeded);
@@ -2978,8 +2988,14 @@ sub process {
if ($comment !~ /^$/ &&
$rawline !~ /^\+\Q$comment\E SPDX-License-Identifier: /) {
- WARN("SPDX_LICENSE_TAG",
- "Missing or malformed SPDX-License-Identifier tag in line $checklicenseline\n" . $herecurr);
+ WARN("SPDX_LICENSE_TAG",
+ "Missing or malformed SPDX-License-Identifier tag in line $checklicenseline\n" . $herecurr);
+ } elsif ($rawline =~ /(SPDX-License-Identifier: .*)/) {
+ my $spdx_license = $1;
+ if (!is_SPDX_License_valid($spdx_license)) {
+ WARN("SPDX_LICENSE_TAG",
+ "'$spdx_license' is not supported in LICENSES/...\n" . $herecurr);
+ }
}
}
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] checkpatch: Validate SPDX license with spdxcheck.py
2018-07-24 17:04 [PATCH] checkpatch: Validate SPDX license with spdxcheck.py Joe Perches
@ 2018-07-24 17:29 ` Rob Herring
0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring @ 2018-07-24 17:29 UTC (permalink / raw)
To: Joe Perches
Cc: Andrew Morton, Thomas Gleixner, linux-kernel, Greg Kroah-Hartman,
Andy Whitcroft
On Tue, Jul 24, 2018 at 11:04 AM Joe Perches <joe@perches.com> wrote:
>
> Use the existing scripts/spdxcheck.py to validate any
> SPDX-License-Identifier found in line 1 or 2 of patches or files.
>
> Miscellanea:
>
> o Properly indent the existing SPDX-License-Identifier block.
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> scripts/checkpatch.pl | 20 ++++++++++++++++++--
> 1 file changed, 18 insertions(+), 2 deletions(-)
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-24 17:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-24 17:04 [PATCH] checkpatch: Validate SPDX license with spdxcheck.py Joe Perches
2018-07-24 17:29 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®