Re: [PATCH wireless-next v4 01/21] wifi: nl80211: define Seamless Mobility Domain (SMD) device capability

[Pooventhiran G <pooventhiran.g@oss.qualcomm.com>]

On 11/10/2026 07:56 pm, Johannes Berg wrote:
> On Tue, 2026-11-10 at 15:15 +0100, Johannes Berg wrote:
>>> + * @NL80211_ATTR_SMD_SUPPORT: Flag attribute to indicate SMD support. Used with
>>> + *	multiple commands to indicate appropriate SMD support (refer DOC).
>>
>> This (with the wiphy flag) is the wrong way to do this, we have extended
>> flags that don't need the double enum value and pass through to
>> userspace directly.

I changed the EXT_FEATURE flag to WIPHY_FLAG based on the comments in v2 and
NL80211_ATTR_MLO_SUPPORT implementation. I will change this back to
EXT_FEATURE flag to indicate driver support.

>>
>> But also, this does absolutely _nothing_, the only thing you do with it
>> is pass a completely ignored NL80211_ATTR_SMD_SUPPORT to START_AP ...
>> it's not even passed to the driver.
> 
> Actually it is, just ignored. I don't really see why we'd care at this
> point though.
> 

NL80211_ATTR_SMD_SUPPORT passed to ieee80211_start_ap is parsed into link_conf
and (will be) read by the driver in assign_vif_chanctx drv-op. ath12k
implementation needs this indication to instantiate vifs and workflows in both
the driver and firmware.

> johannes