From: Afonso Bordado <afonsobordado@az8.co>
To: Jonathan Cameron <jic23@kernel.org>
Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 2/4] iio: gyro: add device tree support for fxas21002c
Date: Wed, 29 Aug 2018 07:43:53 +0100 [thread overview]
Message-ID: <060655b11b68d25fd855e9535df75db4b113a615.camel@az8.co> (raw)
In-Reply-To: <20180827181341.6563c0bf@archlinux>
On Mon, 2018-08-27 at 18:13 +0100, Jonathan Cameron wrote:
> On Sat, 25 Aug 2018 22:19:08 +0100
> Afonso Bordado <afonsobordado@az8.co> wrote:
>
> > This patch adds device tree support for the fxas21002c driver,
> > including
> > bindings.
> >
> > Signed-off-by: Afonso Bordado <afonsobordado@az8.co>
>
> Now, the devicetree bindings should not reflect just what the driver
> uses right now, but rather describe the hardware.
>
> There are interrupts on there for starters that definitely want to be
> described from the start. Also there is a reset line that should
> probably
> be here from the start.
>
> Potentially also the two power supplies though that's less critical
> (nice to have though)
>
> It is also an i2c and spi part though that can probably be added
> later as
> we can argue we are only documenting the bindings for the device in
> i2c mode
> for now.
>
> So what is here is fine, but I think we need to describe more.
>
> It's all well understood details of how it is connected so no need to
> have tested it with a driver to be sure it will be right.
>
> Jonathan
Ok, so i'm thinking about adding both interrupts, the reset line and
the regulators. If i say they are optional in the device tree document,
i shouldn't need to add any more code immediately and could just
implement support for it later right?
next prev parent reply other threads:[~2018-08-29 6:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-25 21:19 [PATCH 1/4] iio: gyro: add " Afonso Bordado
2018-08-25 21:19 ` [PATCH 2/4] iio: gyro: add device tree " Afonso Bordado
2018-08-27 17:13 ` Jonathan Cameron
2018-08-29 6:43 ` Afonso Bordado [this message]
2018-09-02 9:15 ` Jonathan Cameron
2018-08-25 21:19 ` [PATCH 3/4] iio: fxas21002c: add ODR/Scale support Afonso Bordado
2018-08-27 17:18 ` Jonathan Cameron
2018-08-25 21:19 ` [PATCH 4/4] MAINTAINERS: add entry for fxas21002c gyro driver Afonso Bordado
2018-08-27 17:08 ` [PATCH 1/4] iio: gyro: add support for fxas21002c Jonathan Cameron
2018-08-27 20:50 ` Joe Perches
2018-08-29 6:43 ` Afonso Bordado
2018-09-02 9:18 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=060655b11b68d25fd855e9535df75db4b113a615.camel@az8.co \
--to=afonsobordado@az8.co \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®