From: Joe Perches <joe@perches.com>
To: Jonathan Cameron <jic23@kernel.org>,
Afonso Bordado <afonsobordado@az8.co>
Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/4] iio: gyro: add support for fxas21002c
Date: Mon, 27 Aug 2018 13:50:08 -0700 [thread overview]
Message-ID: <0c3d98ffd218e455eb864fdfd7715af19d43230c.camel@perches.com> (raw)
In-Reply-To: <20180827180805.7d4b9f4e@archlinux>
On Mon, 2018-08-27 at 18:08 +0100, Jonathan Cameron wrote:
> On Sat, 25 Aug 2018 22:19:07 +0100
> Afonso Bordado <afonsobordado@az8.co> wrote:
>
> > FXAS21002C is a 3 axis gyroscope with integrated temperature sensor
> >
> > Signed-off-by: Afonso Bordado <afonsobordado@az8.co>
>
> Hi,
>
> Driver is pretty clean so only a few minor comments inline.
> If we were late in a cycle I'd probably just have taken it and fixed up
> but as we have lots of time and I'm inherently lazy I'll let you do a v2 :)
>
> Good job, thanks!
[]
> > diff --git a/drivers/iio/gyro/fxas21002c.c b/drivers/iio/gyro/fxas21002c.c
[]
> /* ... */
>
> Please run checkpatch as IIRC it complains about this.
Running checkpatch and paying attention to what it bleats
is generally a good idea, as long as its bleats aren't
mindlessly followed.
And c99 style // comments have been ignored since:
commit dadf680de3c2eb4cba9840619991eda0cfe98778
Author: Joe Perches <joe@perches.com>
Date: Tue Aug 2 14:04:33 2016 -0700
checkpatch: allow c99 style // comments
Sanitise the lines that contain c99 comments so that the error doesn't
get emitted.
next prev parent reply other threads:[~2018-08-27 20:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-25 21:19 Afonso Bordado
2018-08-25 21:19 ` [PATCH 2/4] iio: gyro: add device tree " Afonso Bordado
2018-08-27 17:13 ` Jonathan Cameron
2018-08-29 6:43 ` Afonso Bordado
2018-09-02 9:15 ` Jonathan Cameron
2018-08-25 21:19 ` [PATCH 3/4] iio: fxas21002c: add ODR/Scale support Afonso Bordado
2018-08-27 17:18 ` Jonathan Cameron
2018-08-25 21:19 ` [PATCH 4/4] MAINTAINERS: add entry for fxas21002c gyro driver Afonso Bordado
2018-08-27 17:08 ` [PATCH 1/4] iio: gyro: add support for fxas21002c Jonathan Cameron
2018-08-27 20:50 ` Joe Perches [this message]
2018-08-29 6:43 ` Afonso Bordado
2018-09-02 9:18 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c3d98ffd218e455eb864fdfd7715af19d43230c.camel@perches.com \
--to=joe@perches.com \
--cc=afonsobordado@az8.co \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®