From: "Arnd Bergmann" <arnd@arndb.de>
To: "Thomas Weißschuh" <linux@weissschuh.net>,
"Anna-Maria Gleixner" <anna-maria@linutronix.de>,
"Frederic Weisbecker" <frederic@kernel.org>,
"Thomas Gleixner" <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org,
"Richard Cochran" <richardcochran@gmail.com>,
"Cyrill Gorcunov" <gorcunov@gmail.com>
Subject: Re: [PATCH] posix-clock: Remove duplicate ioctl handler
Date: Sat, 25 Jan 2025 15:28:29 +0100 [thread overview]
Message-ID: <06196213-3106-4b69-a15d-4b2e4ac6f187@app.fastmail.com> (raw)
In-Reply-To: <20250125-posix-clock-compat-cleanup-v1-1-c8b0f377905b@weissschuh.net>
On Sat, Jan 25, 2025, at 11:20, Thomas Weißschuh wrote:
> static int posix_clock_open(struct inode *inode, struct file *fp)
> {
> int err;
> @@ -174,7 +154,7 @@ static const struct file_operations
> posix_clock_file_operations = {
> .open = posix_clock_open,
> .release = posix_clock_release,
> #ifdef CONFIG_COMPAT
> - .compat_ioctl = posix_clock_compat_ioctl,
> + .compat_ioctl = posix_clock_ioctl,
> #endif
I would remove the #ifdef/#endif as well here. I would also suggest
using compat_ptr_ioctl(), so on s390 the pointers get converted
correctly, even if it clears the upper bit on the integer arguments.
Arnd
next prev parent reply other threads:[~2025-01-25 14:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-25 10:20 Thomas Weißschuh
2025-01-25 12:25 ` Cyrill Gorcunov
2025-01-25 14:28 ` Arnd Bergmann [this message]
2025-01-26 17:20 ` Thomas Weißschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06196213-3106-4b69-a15d-4b2e4ac6f187@app.fastmail.com \
--to=arnd@arndb.de \
--cc=anna-maria@linutronix.de \
--cc=frederic@kernel.org \
--cc=gorcunov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=richardcochran@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®