mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tal Zussman <tz2294@columbia.edu>
To: Andreas Gruenbacher <agruenba@redhat.com>
Cc: gfs2@lists.linux.dev, linux-kernel@vger.kernel.org,
	"Matthew Wilcox (Oracle)" <willy@infradead.org>
Subject: Re: [PATCH 0/3] gfs2: stop using struct page in the log code
Date: Fri, 20 Nov 2026 13:11:48 -0500	[thread overview]
Message-ID: <061b0cd2-8bd6-42fa-b716-b23cb3b0db33@columbia.edu> (raw)
In-Reply-To: <CAHc6FU43KTAm-VvYXrR19BE1Q--2aHL6UALG9cj1pgdeqB_tBw@mail.gmail.com>

On 11/19/26 6:47 PM, Andreas Gruenbacher wrote:
> Tal,
> 
> On Tue, Nov 17, 2026 at 8:46 AM Tal Zussman <tz2294@columbia.edu> wrote:
>> This series gets rid of the remaining struct page usage in the gfs2 log
>> code.
>>
>> The log headers, descriptors, revoke blocks, and escaped block copies
>> are allocated as pages from a mempool, and they end up in the same bios
>> as the page cache buffers being journaled. The completion handler then
>> calls page_folio() on every segment to figure out which kind it is
>> looking at. That won't work once memdescs land and those pool pages are
>> no longer folios.
>>
>> Patch 1 moves these blocks over to a kmalloc mempool, with their own
>> bios and completion handler. As a result each descriptor block is now
>> submitted as its own bio, so patch 2 adds a plug around the log flush to
>> let the block layer merge them back together. Patch 3 cleans up the
>> leftover page references in the log code.
>>
>> Tested with fio 4K write+fsync on gfs2 over virtio-blk and null_blk.
>> Without an I/O scheduler, patch 1 adds one write request per log flush
>> (196.7k to 229.5k for 32k fsyncs) and ~10 us to the p99.9 fsync latency
>> on null_blk (41 us to 51 us); the plug in patch 2 merges them and
>> restores both performance numbers to the baseline. With mq-deadline
>> nothing changes.
> 
> thank you for these patches. Could you please rerun that test with a
> block size smaller than the page size?
> 
> Thanks,
> Andreas
> 

I ran it with a 1k block size on 4k pages, and the result is the same:

job (fsyncs)      sched        base      p1        p2
----------------  -----------  --------  --------  --------
fsync4k (32768)   none         199519    232296    199514
fsync64k (2048)   none          15445     17503     15441
create (2000)     none          12228     14234     12226
fsync4k (32768)   mq-deadline  199509    200016    199505

p99.9 latency results are also the same.

Thanks,
Tal


      reply	other threads:[~2026-11-20 18:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17  7:46 Tal Zussman
2026-11-17  7:46 ` [PATCH 1/3] gfs2: stop using pages for log buffers Tal Zussman
2026-11-20  0:08   ` Andreas Gruenbacher
2026-11-20 18:14     ` Tal Zussman
2026-11-17  7:46 ` [PATCH 2/3] gfs2: plug the log writes of a flush Tal Zussman
2026-11-17  7:46 ` [PATCH 3/3] gfs2: remove the remaining page references in the log code Tal Zussman
2026-11-19 23:47 ` [PATCH 0/3] gfs2: stop using struct page " Andreas Gruenbacher
2026-11-20 18:11   ` Tal Zussman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=061b0cd2-8bd6-42fa-b716-b23cb3b0db33@columbia.edu \
    --to=tz2294@columbia.edu \
    --cc=agruenba@redhat.com \
    --cc=gfs2@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®