mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 0/3] gfs2: stop using struct page in the log code
@ 2026-11-17  7:46 Tal Zussman
  2026-11-17  7:46 ` [PATCH 1/3] gfs2: stop using pages for log buffers Tal Zussman
                   ` (3 more replies)
  0 siblings, 4 replies; 8+ messages in thread
From: Tal Zussman @ 2026-11-17  7:46 UTC (permalink / raw)
  To: Andreas Gruenbacher
  Cc: gfs2, linux-kernel, Matthew Wilcox (Oracle), Tal Zussman

This series gets rid of the remaining struct page usage in the gfs2 log
code.

The log headers, descriptors, revoke blocks, and escaped block copies
are allocated as pages from a mempool, and they end up in the same bios
as the page cache buffers being journaled. The completion handler then
calls page_folio() on every segment to figure out which kind it is
looking at. That won't work once memdescs land and those pool pages are
no longer folios.

Patch 1 moves these blocks over to a kmalloc mempool, with their own
bios and completion handler. As a result each descriptor block is now
submitted as its own bio, so patch 2 adds a plug around the log flush to
let the block layer merge them back together. Patch 3 cleans up the
leftover page references in the log code.

Tested with fio 4K write+fsync on gfs2 over virtio-blk and null_blk.
Without an I/O scheduler, patch 1 adds one write request per log flush
(196.7k to 229.5k for 32k fsyncs) and ~10 us to the p99.9 fsync latency
on null_blk (41 us to 51 us); the plug in patch 2 merges them and
restores both performance numbers to the baseline. With mq-deadline
nothing changes.

---
Tal Zussman (3):
      gfs2: stop using pages for log buffers
      gfs2: plug the log writes of a flush
      gfs2: remove the remaining page references in the log code

 fs/gfs2/bmap.h |   1 -
 fs/gfs2/log.c  |  19 ++---
 fs/gfs2/lops.c | 221 +++++++++++++++++++++++++++++++++++----------------------
 fs/gfs2/lops.h |   6 +-
 fs/gfs2/main.c |   8 +--
 fs/gfs2/util.c |   2 +-
 fs/gfs2/util.h |   2 +-
 7 files changed, 154 insertions(+), 105 deletions(-)
---
base-commit: e3280ea8b73964efb447f396fb09401a31373136
change-id: 20261014-gfs2-log-folio-274b84f5cc07

Best regards,
--  
Tal Zussman <tz2294@columbia.edu>


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2026-11-20 18:14 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-17  7:46 [PATCH 0/3] gfs2: stop using struct page in the log code Tal Zussman
2026-11-17  7:46 ` [PATCH 1/3] gfs2: stop using pages for log buffers Tal Zussman
2026-11-20  0:08   ` Andreas Gruenbacher
2026-11-20 18:14     ` Tal Zussman
2026-11-17  7:46 ` [PATCH 2/3] gfs2: plug the log writes of a flush Tal Zussman
2026-11-17  7:46 ` [PATCH 3/3] gfs2: remove the remaining page references in the log code Tal Zussman
2026-11-19 23:47 ` [PATCH 0/3] gfs2: stop using struct page " Andreas Gruenbacher
2026-11-20 18:11   ` Tal Zussman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®