mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vivek Sahu <vivek.sahu@oss.qualcomm.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
	Bartosz Golaszewski <brgl@kernel.org>,
	Marcel Holtmann <marcel@holtmann.org>,
	Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Balakrishna Godavarthi <quic_bgodavar@quicinc.com>,
	Rocky Liao <quic_rjliao@quicinc.com>,
	quic_mohamull@quicinc.com, quic_hbandi@quicinc.com,
	janaki.thota@oss.qualcomm.com, linux-arm-msm@vger.kernel.org,
	linux-bluetooth@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/2] Bluetooth: qca: add QCC2072 support
Date: Wed, 18 Feb 2026 17:09:14 +0530	[thread overview]
Message-ID: <0637e27c-cadd-45e7-9c43-cc510c431f2d@oss.qualcomm.com> (raw)
In-Reply-To: <3v3iz5cxsbaoevcfkk7itutdepfuagxoemixgfhewdevmju2ut@rcg3zuyg4gzn>



On 2/17/2026 6:31 PM, Dmitry Baryshkov wrote:
> On Tue, Feb 17, 2026 at 06:21:19PM +0530, Vivek Sahu wrote:
>>
>>
>> On 2/17/2026 1:23 PM, Krzysztof Kozlowski wrote:
>>> On Tue, Feb 17, 2026 at 01:17:29PM +0530, Vivek Sahu wrote:
>>>>>> +		case QCA_QCC2072:
>>>>>> +			snprintf(config.fwname, sizeof(config.fwname),
>>>>>> +				 "qca/ornnv%02x.bin", rom_ver);
>>>>>> +			break;
>>>>>>     		case QCA_WCN3950:
>>>>>>     			if (le32_to_cpu(ver.soc_id) == QCA_WCN3950_SOC_ID_T)
>>>>>>     				variant = "t";
>>>>>> diff --git a/drivers/bluetooth/btqca.h b/drivers/bluetooth/btqca.h
>>>>>> index 8f3c1b1c77b3..a175ac31e7b2 100644
>>>>>> --- a/drivers/bluetooth/btqca.h
>>>>>> +++ b/drivers/bluetooth/btqca.h
>>>>>> @@ -158,6 +158,7 @@ enum qca_btsoc_type {
>>>>>>     	QCA_WCN6750,
>>>>>>     	QCA_WCN6855,
>>>>>>     	QCA_WCN7850,
>>>>>> +	QCA_QCC2072,
>>>>>
>>>>> Why not keep it sorted?
>>>>>
>>>> As mentioned in the cover letter "qca_btsoc_type" enum in
>>>> drivers/bluetooth/btqca.h contains all the soc type which need to be enabled
>>>> for BT enablement on the target device. There are few places where logic of
>>>> framing packets transferring between SoC  and Host depends on the which
>>>> generation of the chip it is, refer api "qca_read_soc_version". So It is not
>>>> sorted in btqca.h file.
>>>
>>> Neither in previous patch comments nor here you respond to actual
>>> comment. You just write something completely irrelevant.
>>>
>>> I don't think any of this should be considered if you are not
>>> responding to actual comments.
>>>
>>>
>>> Best regards,
>>> Krzysztof
>>>
>> There is high impact on the existing design if i make this enum sorted. We
> 
> What kind of "high impact"?
> 
We identified a better way of handling it. I'll move it to the correct 
place.
>> are considering your comments regarding sorting for next commit not for this
>> commit. Can we have approval for this commit if all other changes looks
>> fine.
> 
> 
> No.
> 


  reply	other threads:[~2026-02-18 11:39 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-17  5:47 [PATCH v4 0/2] Cover letter QCC2072 enablement Vivek Sahu
2026-02-17  5:47 ` [PATCH v4 1/2] dt-bindings: bluetooth: qcom,qcc2072-bt: Split to separate schema Vivek Sahu
2026-02-17  6:34   ` Dmitry Baryshkov
2026-02-17  7:41     ` Vivek Sahu
2026-02-17  8:13       ` Dmitry Baryshkov
2026-02-17  8:19         ` Vivek Sahu
2026-02-17  8:21           ` Krzysztof Kozlowski
2026-02-17  7:51   ` Krzysztof Kozlowski
2026-02-17  8:08     ` Vivek Sahu
2026-02-17  5:47 ` [PATCH v4 2/2] Bluetooth: qca: add QCC2072 support Vivek Sahu
2026-02-17  6:36   ` Dmitry Baryshkov
2026-02-17  7:47     ` Vivek Sahu
2026-02-17  7:53       ` Krzysztof Kozlowski
2026-02-17 12:51         ` Vivek Sahu
2026-02-17 13:01           ` Dmitry Baryshkov
2026-02-18 11:39             ` Vivek Sahu [this message]
2026-02-18 11:51         ` Vivek Sahu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0637e27c-cadd-45e7-9c43-cc510c431f2d@oss.qualcomm.com \
    --to=vivek.sahu@oss.qualcomm.com \
    --cc=brgl@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=janaki.thota@oss.qualcomm.com \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    --cc=marcel@holtmann.org \
    --cc=quic_bgodavar@quicinc.com \
    --cc=quic_hbandi@quicinc.com \
    --cc=quic_mohamull@quicinc.com \
    --cc=quic_rjliao@quicinc.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®