From: David Laight <David.Laight@ACULAB.COM>
To: "'Shannon Nelson'" <shannon.nelson@oracle.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>
Cc: "sparclinux@vger.kernel.org" <sparclinux@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 net-next 4/5] sunvnet: count multicast packets
Date: Wed, 15 Mar 2017 08:50:05 +0000 [thread overview]
Message-ID: <063D6719AE5E284EB5DD2968C1650D6DCFFB12CF@AcuExch.aculab.com> (raw)
In-Reply-To: <1489512283-422140-5-git-send-email-shannon.nelson@oracle.com>
From: Shannon Nelson
> Sent: 14 March 2017 17:25
...
> + if (unlikely(is_multicast_ether_addr(eth_hdr(skb)->h_dest)))
> + dev->stats.multicast++;
I'd guess that:
dev->stats.multicast += is_multicast_ether_addr(eth_hdr(skb)->h_dest);
generates faster code.
Especially if is_multicast_ether_addr(x) is (*x >> 7).
David
next prev parent reply other threads:[~2017-03-15 8:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-14 17:24 [PATCH v2 net-next 0/5] sunvnet: better connection management Shannon Nelson
2017-03-14 17:24 ` [PATCH v2 net-next 1/5] ldmvsw: better use of link up and down on ldom vswitch Shannon Nelson
2017-03-14 17:24 ` [PATCH v2 net-next 2/5] sunvnet: add stats to track ldom to ldom packets and bytes Shannon Nelson
2017-03-14 17:24 ` [PATCH v2 net-next 3/5] sunvnet: track port queues correctly Shannon Nelson
2017-03-14 17:24 ` [PATCH v2 net-next 4/5] sunvnet: count multicast packets Shannon Nelson
2017-03-15 8:50 ` David Laight [this message]
2017-03-16 0:17 ` Shannon Nelson
2017-03-16 12:12 ` David Laight
2017-03-16 18:30 ` David Miller
2017-03-14 17:24 ` [PATCH v2 net-next 5/5] sunvnet: xoff not needed when removing port link Shannon Nelson
2017-03-17 3:30 ` [PATCH v2 net-next 0/5] sunvnet: better connection management David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=063D6719AE5E284EB5DD2968C1650D6DCFFB12CF@AcuExch.aculab.com \
--to=david.laight@aculab.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shannon.nelson@oracle.com \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®