From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Ricardo Ribalda <ribalda@chromium.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Stanimir Varbanov <stanimir.k.varbanov@gmail.com>,
Vikash Garodia <quic_vgarodia@quicinc.com>
Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v5 01/10] media: venus: Remove unused structs
Date: Mon, 12 Aug 2024 16:03:46 +0100 [thread overview]
Message-ID: <0640d530-404d-40cf-9737-0d7468dd0177@linaro.org> (raw)
In-Reply-To: <20240618-cocci-flexarray-v5-1-6a8294942f48@chromium.org>
On 18/06/2024 14:37, Ricardo Ribalda wrote:
> This structures are not used, and have a single element array at the end
> of them. Remove them.
>
> This fix the following cocci warnings:
> drivers/media/platform/qcom/venus/hfi_helper.h:764:5-15: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)
> drivers/media/platform/qcom/venus/hfi_helper.h:1041:5-15: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)
> drivers/media/platform/qcom/venus/hfi_helper.h:1088:39-51: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)
> drivers/media/platform/qcom/venus/hfi_helper.h:1093:5-22: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)
> drivers/media/platform/qcom/venus/hfi_helper.h:1144:4-8: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)
> drivers/media/platform/qcom/venus/hfi_helper.h:1239:4-8: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)
> drivers/media/platform/qcom/venus/hfi_helper.h:1272:4-13: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)
> drivers/media/platform/qcom/venus/hfi_cmds.h:85:5-16: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)
> drivers/media/platform/qcom/venus/hfi_cmds.h:180:5-9: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)
> drivers/media/platform/qcom/venus/hfi_cmds.h:189:5-9: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)
>
> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
I realise I'm going against the grain saying this but, I believe these
structures - which document host <-> firmware data packets - the ABI -
should be retained in the header, even if they are unused, since they
are documentary and potentially of future use.
I'd rather fix the WARNING than zap the structure.
---
bod
next prev parent reply other threads:[~2024-08-12 15:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-18 13:37 [PATCH v5 00/10] media: Fix the last set of coccinelle warnings Ricardo Ribalda
2024-06-18 13:37 ` [PATCH v5 01/10] media: venus: Remove unused structs Ricardo Ribalda
2024-08-12 15:03 ` Bryan O'Donoghue [this message]
2024-06-18 13:37 ` [PATCH v5 02/10] media: venus: Use flex array for hfi_session_release_buffer_pkt Ricardo Ribalda
2024-06-18 13:37 ` [PATCH v5 03/10] media: venus: Refactor struct hfi_uncompressed_plane_info Ricardo Ribalda
2024-06-18 13:37 ` [PATCH v5 04/10] media: venus: Refactor struct hfi_session_get_property_pkt Ricardo Ribalda
2024-06-18 13:37 ` [PATCH v5 05/10] media: venus: Refactor struct hfi_uncompressed_format_supported Ricardo Ribalda
2024-06-18 13:37 ` [PATCH v5 06/10] media: venus: Refactor hfi_session_empty_buffer_uncompressed_plane0_pkt Ricardo Ribalda
2024-06-18 13:37 ` [PATCH v5 07/10] media: venus: Refactor hfi_session_empty_buffer_compressed_pkt Ricardo Ribalda
2024-06-18 13:37 ` [PATCH v5 08/10] media: venus: Refactor hfi_sys_get_property_pkt Ricardo Ribalda
2024-06-18 13:37 ` [PATCH v5 09/10] media: venus: Refactor hfi_session_fill_buffer_pkt Ricardo Ribalda
2024-06-18 13:37 ` [PATCH v5 10/10] media: venus: Refactor hfi_buffer_alloc_mode_supported Ricardo Ribalda
2024-06-19 6:40 ` [PATCH v5 00/10] media: Fix the last set of coccinelle warnings Dmitry Baryshkov
2024-08-12 9:50 ` Ricardo Ribalda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0640d530-404d-40cf-9737-0d7468dd0177@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=quic_vgarodia@quicinc.com \
--cc=ribalda@chromium.org \
--cc=stanimir.k.varbanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®