mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ricardo Ribalda <ribalda@chromium.org>
To: Mauro Carvalho Chehab <mchehab@kernel.org>,
	 Stanimir Varbanov <stanimir.k.varbanov@gmail.com>,
	 Vikash Garodia <quic_vgarodia@quicinc.com>,
	 Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl>,
	linux-media@vger.kernel.org,  linux-kernel@vger.kernel.org,
	linux-arm-msm@vger.kernel.org,
	 Ricardo Ribalda <ribalda@chromium.org>
Subject: [PATCH v5 03/10] media: venus: Refactor struct hfi_uncompressed_plane_info
Date: Tue, 18 Jun 2024 13:37:46 +0000	[thread overview]
Message-ID: <20240618-cocci-flexarray-v5-3-6a8294942f48@chromium.org> (raw)
In-Reply-To: <20240618-cocci-flexarray-v5-0-6a8294942f48@chromium.org>

This field is never used, but if we remove it we would change the size
of the struct and can lead to behavior change. Stay on the safe side by
replacing the single element array with a single element field.

This fixes the following cocci warning:
drivers/media/platform/qcom/venus/hfi_helper.h:1003:43-60: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)

Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Acked-by: Vikash Garodia <quic_vgarodia@quicinc.com>
Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
---
 drivers/media/platform/qcom/venus/hfi_helper.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/platform/qcom/venus/hfi_helper.h b/drivers/media/platform/qcom/venus/hfi_helper.h
index f61295819cc1..c53e2fb2d42c 100644
--- a/drivers/media/platform/qcom/venus/hfi_helper.h
+++ b/drivers/media/platform/qcom/venus/hfi_helper.h
@@ -1000,7 +1000,7 @@ struct hfi_uncompressed_plane_constraints {
 struct hfi_uncompressed_plane_info {
 	u32 format;
 	u32 num_planes;
-	struct hfi_uncompressed_plane_constraints plane_constraints[1];
+	struct hfi_uncompressed_plane_constraints plane_constraints;
 };
 
 struct hfi_uncompressed_format_supported {

-- 
2.45.2.627.g7a2c4fd464-goog


  parent reply	other threads:[~2024-06-18 13:37 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-18 13:37 [PATCH v5 00/10] media: Fix the last set of coccinelle warnings Ricardo Ribalda
2024-06-18 13:37 ` [PATCH v5 01/10] media: venus: Remove unused structs Ricardo Ribalda
2024-08-12 15:03   ` Bryan O'Donoghue
2024-06-18 13:37 ` [PATCH v5 02/10] media: venus: Use flex array for hfi_session_release_buffer_pkt Ricardo Ribalda
2024-06-18 13:37 ` Ricardo Ribalda [this message]
2024-06-18 13:37 ` [PATCH v5 04/10] media: venus: Refactor struct hfi_session_get_property_pkt Ricardo Ribalda
2024-06-18 13:37 ` [PATCH v5 05/10] media: venus: Refactor struct hfi_uncompressed_format_supported Ricardo Ribalda
2024-06-18 13:37 ` [PATCH v5 06/10] media: venus: Refactor hfi_session_empty_buffer_uncompressed_plane0_pkt Ricardo Ribalda
2024-06-18 13:37 ` [PATCH v5 07/10] media: venus: Refactor hfi_session_empty_buffer_compressed_pkt Ricardo Ribalda
2024-06-18 13:37 ` [PATCH v5 08/10] media: venus: Refactor hfi_sys_get_property_pkt Ricardo Ribalda
2024-06-18 13:37 ` [PATCH v5 09/10] media: venus: Refactor hfi_session_fill_buffer_pkt Ricardo Ribalda
2024-06-18 13:37 ` [PATCH v5 10/10] media: venus: Refactor hfi_buffer_alloc_mode_supported Ricardo Ribalda
2024-06-19  6:40 ` [PATCH v5 00/10] media: Fix the last set of coccinelle warnings Dmitry Baryshkov
2024-08-12  9:50   ` Ricardo Ribalda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240618-cocci-flexarray-v5-3-6a8294942f48@chromium.org \
    --to=ribalda@chromium.org \
    --cc=bryan.odonoghue@linaro.org \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=quic_vgarodia@quicinc.com \
    --cc=stanimir.k.varbanov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®