mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chanh Nguyen <chanh@amperemail.onmicrosoft.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Chanh Nguyen <chanh@os.amperecomputing.com>,
	Jean Delvare <jdelvare@suse.com>,
	Guenter Roeck <linux@roeck-us.net>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Justin Ledford <justinledford@google.com>,
	devicetree@vger.kernel.org, linux-hwmon@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	OpenBMC Maillist <openbmc@lists.ozlabs.org>,
	Open Source Submission <patches@amperecomputing.com>
Cc: Phong Vo <phong@os.amperecomputing.com>,
	Thang Nguyen <thang@os.amperecomputing.com>,
	Quan Nguyen <quan@os.amperecomputing.com>
Subject: Re: [PATCH v2 3/3] dt-bindings: hwmon: max31790: Add maxim,pwmout-pin-as-tach-input property
Date: Tue, 16 Apr 2024 11:52:58 +0700	[thread overview]
Message-ID: <065243cc-09cf-4087-8842-bd4394fb324f@amperemail.onmicrosoft.com> (raw)
In-Reply-To: <13b195e6-cbbd-4f74-a6fa-d874cb4aaa45@linaro.org>



On 14/04/2024 13:07, Krzysztof Kozlowski wrote:
> On 14/04/2024 06:22, Chanh Nguyen wrote:
>> The max31790 supports six pins, which are dedicated PWM outputs. Any of the
>> six PWM outputs can also be configured to serve as tachometer inputs,
>> allowing for up to 12 tachometer fans to be monitored.
>>
>> Add a new vendor-specific property, 'maxim,pwmout-pin-as-tach-input',
>> to allow PWMOUT to become a TACH input.
>>
>> An array of six integers responds to six PWM channels for configuring
>> the PWM to TACH mode. When set to 0, the associated PWMOUT produces
>> a PWM waveform for control of fan speed. When set to 1, PWMOUT becomes
>> a TACH input.
>>
>> Signed-off-by: Chanh Nguyen <chanh@os.amperecomputing.com>
>> ---
>> Changes in v2:
>>   - Update the vendor property name to "maxim,pwmout-pin-as-tach-input"   [Rob]
>>   - Update commit message                                                 [Krzysztof]
> 
> Please put binding before its user.
> 

Hi Krzysztof, I'll drop this [Path 3/3] in the patch series v3.

My patch series will only be two patches. They are "dt-bindings: hwmon: 
Add maxim max31790" and "hwmon: (max31790): Support config PWM output 
becomes TACH"

>> ---
>>   .../devicetree/bindings/hwmon/maxim,max31790.yaml     | 11 +++++++++++
>>   1 file changed, 11 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml b/Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml
>> index a561e5a3e9e4..2d4f50bc7c41 100644
>> --- a/Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml
>> +++ b/Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml
>> @@ -30,6 +30,16 @@ properties:
>>     resets:
>>       maxItems: 1
>>   
>> +  maxim,pwmout-pin-as-tach-input:
>> +    description: |
>> +      An array of six integers responds to six PWM channels for
>> +      configuring the pwm to tach mode.
>> +      When set to 0, the associated PWMOUT produces a PWM waveform for
>> +      control of fan speed. When set to 1, PWMOUT becomes a TACH input
>> +    $ref: /schemas/types.yaml#/definitions/uint8-array
>> +    maxItems: 6
>> +    minItems: 6
> 
> tach-ch solves your case. You define which inputs should be used for tach.
> 

Agree Krzysztof. I'll use the tach-ch property from the fan-common.yaml 
to solve my case. So I will not need to define a new vendor property as 
"maxim,pwmout-pin-as-tach-input". I'll drop this [Path 3/3] in the patch 
series v3.


> Best regards,
> Krzysztof
> 

  reply	other threads:[~2024-04-16  4:53 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-14  4:22 [PATCH v2 0/3] Update the max31790 driver Chanh Nguyen
2024-04-14  4:22 ` [PATCH v2 1/3] dt-bindings: hwmon: Add maxim max31790 bindings Chanh Nguyen
2024-04-14  6:03   ` Krzysztof Kozlowski
2024-04-16  4:38     ` Chanh Nguyen
2024-04-14  4:22 ` [PATCH v2 2/3] hwmon: (max31790): Support config PWM output becomes TACH Chanh Nguyen
2024-04-14  8:03   ` Christophe JAILLET
2024-04-16  5:27     ` Chanh Nguyen
2024-04-16 17:39       ` Christophe JAILLET
2024-04-17  2:54         ` Chanh Nguyen
2024-04-14  4:22 ` [PATCH v2 3/3] dt-bindings: hwmon: max31790: Add maxim,pwmout-pin-as-tach-input property Chanh Nguyen
2024-04-14  6:07   ` Krzysztof Kozlowski
2024-04-16  4:52     ` Chanh Nguyen [this message]
2024-04-23  8:45       ` Chanh Nguyen
2024-04-23 17:02         ` Conor Dooley
2024-04-25 10:33           ` Chanh Nguyen
2024-04-25 14:05             ` Guenter Roeck
2024-04-25 15:46               ` Krzysztof Kozlowski
2024-04-25 15:56                 ` Conor Dooley
2024-05-05 10:08               ` Chanh Nguyen
2024-05-05 15:40                 ` Guenter Roeck
2024-05-08  3:44                   ` Chanh Nguyen
2024-05-08 16:47                     ` Conor Dooley
2024-06-07 16:47                       ` Chanh Nguyen
2024-06-07 23:14                         ` Guenter Roeck
2024-06-08  8:32                           ` Chanh Nguyen
2024-05-09  8:29                     ` Krzysztof Kozlowski
2024-06-07 16:46                       ` Chanh Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=065243cc-09cf-4087-8842-bd4394fb324f@amperemail.onmicrosoft.com \
    --to=chanh@amperemail.onmicrosoft.com \
    --cc=chanh@os.amperecomputing.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jdelvare@suse.com \
    --cc=justinledford@google.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=openbmc@lists.ozlabs.org \
    --cc=patches@amperecomputing.com \
    --cc=phong@os.amperecomputing.com \
    --cc=quan@os.amperecomputing.com \
    --cc=robh+dt@kernel.org \
    --cc=thang@os.amperecomputing.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®