mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: Chanh Nguyen <chanh@os.amperecomputing.com>,
	Jean Delvare <jdelvare@suse.com>,
	Guenter Roeck <linux@roeck-us.net>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Justin Ledford <justinledford@google.com>,
	devicetree@vger.kernel.org, linux-hwmon@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	OpenBMC Maillist <openbmc@lists.ozlabs.org>,
	Open Source Submission <patches@amperecomputing.com>
Cc: Phong Vo <phong@os.amperecomputing.com>,
	Thang Nguyen <thang@os.amperecomputing.com>,
	Quan Nguyen <quan@os.amperecomputing.com>
Subject: Re: [PATCH v2 2/3] hwmon: (max31790): Support config PWM output becomes TACH
Date: Sun, 14 Apr 2024 10:03:07 +0200	[thread overview]
Message-ID: <79bef664-b191-4905-896c-afab341b982b@wanadoo.fr> (raw)
In-Reply-To: <20240414042246.8681-3-chanh@os.amperecomputing.com>

Le 14/04/2024 à 06:22, Chanh Nguyen a écrit :
> PWMOUT pins on MAX31790 can be configured as a tachometer input pin by
> setting bit[0] in the Configuration Register. When the bit[0] of a channel
> is set, the PWMOUT pin becomes the tach input pin for the channel plus six.
> 
> This commit allows the kernel to set those pins when necessary if the
> maxim,pwmout-pin-as-tach-input DT property exists.
> 
> Signed-off-by: Chanh Nguyen <chanh@os.amperecomputing.com>
> ---
> Changes in v2:
>   - Update the vendor property name to "maxim,pwmout-pin-as-tach-input"   [Rob]

...

> @@ -528,6 +532,33 @@ static int max31790_probe(struct i2c_client *client)
>   	if (err)
>   		return err;
>   
> +	if (device_property_present(dev, "maxim,pwmout-pin-as-tach-input")) {
> +		err = device_property_read_u8_array(dev, "maxim,pwmout-pin-as-tach-input",
> +						    pwmout_to_tach, NR_CHANNEL);
> +		if (err) {
> +			/* The maxim,pwmout-pin-as-tach-input is an array of six values */
> +			dev_warn(dev, "The maxim,pwmout-pin-as-tach-input property exist but malform");

Nit: exists
Nit: malformed or "is malformed"

CJ

  reply	other threads:[~2024-04-14  8:03 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-14  4:22 [PATCH v2 0/3] Update the max31790 driver Chanh Nguyen
2024-04-14  4:22 ` [PATCH v2 1/3] dt-bindings: hwmon: Add maxim max31790 bindings Chanh Nguyen
2024-04-14  6:03   ` Krzysztof Kozlowski
2024-04-16  4:38     ` Chanh Nguyen
2024-04-14  4:22 ` [PATCH v2 2/3] hwmon: (max31790): Support config PWM output becomes TACH Chanh Nguyen
2024-04-14  8:03   ` Christophe JAILLET [this message]
2024-04-16  5:27     ` Chanh Nguyen
2024-04-16 17:39       ` Christophe JAILLET
2024-04-17  2:54         ` Chanh Nguyen
2024-04-14  4:22 ` [PATCH v2 3/3] dt-bindings: hwmon: max31790: Add maxim,pwmout-pin-as-tach-input property Chanh Nguyen
2024-04-14  6:07   ` Krzysztof Kozlowski
2024-04-16  4:52     ` Chanh Nguyen
2024-04-23  8:45       ` Chanh Nguyen
2024-04-23 17:02         ` Conor Dooley
2024-04-25 10:33           ` Chanh Nguyen
2024-04-25 14:05             ` Guenter Roeck
2024-04-25 15:46               ` Krzysztof Kozlowski
2024-04-25 15:56                 ` Conor Dooley
2024-05-05 10:08               ` Chanh Nguyen
2024-05-05 15:40                 ` Guenter Roeck
2024-05-08  3:44                   ` Chanh Nguyen
2024-05-08 16:47                     ` Conor Dooley
2024-06-07 16:47                       ` Chanh Nguyen
2024-06-07 23:14                         ` Guenter Roeck
2024-06-08  8:32                           ` Chanh Nguyen
2024-05-09  8:29                     ` Krzysztof Kozlowski
2024-06-07 16:46                       ` Chanh Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=79bef664-b191-4905-896c-afab341b982b@wanadoo.fr \
    --to=christophe.jaillet@wanadoo.fr \
    --cc=chanh@os.amperecomputing.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jdelvare@suse.com \
    --cc=justinledford@google.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=openbmc@lists.ozlabs.org \
    --cc=patches@amperecomputing.com \
    --cc=phong@os.amperecomputing.com \
    --cc=quan@os.amperecomputing.com \
    --cc=robh+dt@kernel.org \
    --cc=thang@os.amperecomputing.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®