mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Gabriele Monaco <gmonaco@redhat.com>
To: Nam Cao <namcao@linutronix.de>, Steven Rostedt <rostedt@goodmis.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	linux-trace-kernel@vger.kernel.org,
	 linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>,
	 stable@vger.kernel.org
Subject: Re: [PATCH 2/2] rv: Make rtapp/pagefault monitor depends on CONFIG_MMU
Date: Thu, 02 Oct 2025 13:51:01 +0200	[thread overview]
Message-ID: <067420a47d3fd7d9f50e4bc97248d0b4b812f9cd.camel@redhat.com> (raw)
In-Reply-To: <20251002082317.973839-1-namcao@linutronix.de>

On Thu, 2025-10-02 at 08:23 +0000, Nam Cao wrote:
> There is no page fault without MMU. Compiling the rtapp/pagefault monitor
> without CONFIG_MMU fails as page fault tracepoints' definitions are not
> available.
> 
> Make rtapp/pagefault monitor depends on CONFIG_MMU.

Makes sense.

Reviewed-by: Gabriele Monaco <gmonaco@redhat.com>

Thanks,
Gabriele

> 
> Fixes: 9162620eb604 ("rv: Add rtapp_pagefault monitor")
> Signed-off-by: Nam Cao <namcao@linutronix.de>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes:
> https://lore.kernel.org/oe-kbuild-all/202509260455.6Z9Vkty4-lkp@intel.com/
> Cc: stable@vger.kernel.org
> ---
>  kernel/trace/rv/monitors/pagefault/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/kernel/trace/rv/monitors/pagefault/Kconfig
> b/kernel/trace/rv/monitors/pagefault/Kconfig
> index 5e16625f1653..0e013f00c33b 100644
> --- a/kernel/trace/rv/monitors/pagefault/Kconfig
> +++ b/kernel/trace/rv/monitors/pagefault/Kconfig
> @@ -5,6 +5,7 @@ config RV_MON_PAGEFAULT
>  	select RV_LTL_MONITOR
>  	depends on RV_MON_RTAPP
>  	depends on X86 || RISCV
> +	depends on MMU
>  	default y
>  	select LTL_MON_EVENTS_ID
>  	bool "pagefault monitor"


      reply	other threads:[~2025-10-02 11:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-02  8:23 Nam Cao
2025-10-02 11:51 ` Gabriele Monaco [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=067420a47d3fd7d9f50e4bc97248d0b4b812f9cd.camel@redhat.com \
    --to=gmonaco@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhiramat@kernel.org \
    --cc=namcao@linutronix.de \
    --cc=rostedt@goodmis.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®