mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 2/2] rv: Make rtapp/pagefault monitor depends on CONFIG_MMU
@ 2025-10-02  8:23 Nam Cao
  2025-10-02 11:51 ` Gabriele Monaco
  0 siblings, 1 reply; 2+ messages in thread
From: Nam Cao @ 2025-10-02  8:23 UTC (permalink / raw)
  To: Gabriele Monaco, Steven Rostedt
  Cc: Masami Hiramatsu, Mathieu Desnoyers, linux-trace-kernel,
	linux-kernel, Nam Cao, kernel test robot, stable

There is no page fault without MMU. Compiling the rtapp/pagefault monitor
without CONFIG_MMU fails as page fault tracepoints' definitions are not
available.

Make rtapp/pagefault monitor depends on CONFIG_MMU.

Fixes: 9162620eb604 ("rv: Add rtapp_pagefault monitor")
Signed-off-by: Nam Cao <namcao@linutronix.de>
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202509260455.6Z9Vkty4-lkp@intel.com/
Cc: stable@vger.kernel.org
---
 kernel/trace/rv/monitors/pagefault/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/kernel/trace/rv/monitors/pagefault/Kconfig b/kernel/trace/rv/monitors/pagefault/Kconfig
index 5e16625f1653..0e013f00c33b 100644
--- a/kernel/trace/rv/monitors/pagefault/Kconfig
+++ b/kernel/trace/rv/monitors/pagefault/Kconfig
@@ -5,6 +5,7 @@ config RV_MON_PAGEFAULT
 	select RV_LTL_MONITOR
 	depends on RV_MON_RTAPP
 	depends on X86 || RISCV
+	depends on MMU
 	default y
 	select LTL_MON_EVENTS_ID
 	bool "pagefault monitor"
-- 
2.51.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH 2/2] rv: Make rtapp/pagefault monitor depends on CONFIG_MMU
  2025-10-02  8:23 [PATCH 2/2] rv: Make rtapp/pagefault monitor depends on CONFIG_MMU Nam Cao
@ 2025-10-02 11:51 ` Gabriele Monaco
  0 siblings, 0 replies; 2+ messages in thread
From: Gabriele Monaco @ 2025-10-02 11:51 UTC (permalink / raw)
  To: Nam Cao, Steven Rostedt
  Cc: Masami Hiramatsu, Mathieu Desnoyers, linux-trace-kernel,
	linux-kernel, kernel test robot, stable

On Thu, 2025-10-02 at 08:23 +0000, Nam Cao wrote:
> There is no page fault without MMU. Compiling the rtapp/pagefault monitor
> without CONFIG_MMU fails as page fault tracepoints' definitions are not
> available.
> 
> Make rtapp/pagefault monitor depends on CONFIG_MMU.

Makes sense.

Reviewed-by: Gabriele Monaco <gmonaco@redhat.com>

Thanks,
Gabriele

> 
> Fixes: 9162620eb604 ("rv: Add rtapp_pagefault monitor")
> Signed-off-by: Nam Cao <namcao@linutronix.de>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes:
> https://lore.kernel.org/oe-kbuild-all/202509260455.6Z9Vkty4-lkp@intel.com/
> Cc: stable@vger.kernel.org
> ---
>  kernel/trace/rv/monitors/pagefault/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/kernel/trace/rv/monitors/pagefault/Kconfig
> b/kernel/trace/rv/monitors/pagefault/Kconfig
> index 5e16625f1653..0e013f00c33b 100644
> --- a/kernel/trace/rv/monitors/pagefault/Kconfig
> +++ b/kernel/trace/rv/monitors/pagefault/Kconfig
> @@ -5,6 +5,7 @@ config RV_MON_PAGEFAULT
>  	select RV_LTL_MONITOR
>  	depends on RV_MON_RTAPP
>  	depends on X86 || RISCV
> +	depends on MMU
>  	default y
>  	select LTL_MON_EVENTS_ID
>  	bool "pagefault monitor"


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-10-02 11:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-10-02  8:23 [PATCH 2/2] rv: Make rtapp/pagefault monitor depends on CONFIG_MMU Nam Cao
2025-10-02 11:51 ` Gabriele Monaco

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®