mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Datta, Shubhrajyoti" <shubhrajyoti@ti.com>
To: Vasiliy Kulikov <segooon@gmail.com>,
	"kernel-janitors@vger.kernel.org"
	<kernel-janitors@vger.kernel.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	"Chemparathy, Cyril" <cyril@ti.com>,
	Kevin Hilman <khilman@deeprootsystems.com>,
	"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] keyboard: tnetv107x: fix input_device leak
Date: Mon, 27 Sep 2010 10:55:24 +0530	[thread overview]
Message-ID: <0680EC522D0CC943BC586913CF3768C003FF0594C8@dbde02.ent.ti.com> (raw)
In-Reply-To: <1285491584-32664-1-git-send-email-segooon@gmail.com>



> -----Original Message-----
> From: linux-input-owner@vger.kernel.org [mailto:linux-input-
> owner@vger.kernel.org] On Behalf Of Vasiliy Kulikov
> Sent: Sunday, September 26, 2010 2:30 PM
> To: kernel-janitors@vger.kernel.org
> Cc: Dmitry Torokhov; Chemparathy, Cyril; Kevin Hilman; linux-
> input@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] keyboard: tnetv107x: fix input_device leak
> 
> keypad_probe() calls input_free_device() on error, but keypad_remove()
> doesn't.
> ---
>  Compile tested.
> 
>  drivers/input/keyboard/tnetv107x-keypad.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/input/keyboard/tnetv107x-keypad.c
> b/drivers/input/keyboard/tnetv107x-keypad.c
> index b4a81eb..1ea20e1 100644
> --- a/drivers/input/keyboard/tnetv107x-keypad.c
> +++ b/drivers/input/keyboard/tnetv107x-keypad.c
> @@ -305,6 +305,7 @@ static int __devexit keypad_remove(struct
> platform_device *pdev)
>  	free_irq(kp->irq_press, kp);
>  	free_irq(kp->irq_release, kp);
>  	input_unregister_device(kp->input_dev);
> +	input_free_device(kp->input_dev);
It does not seem to be correct.

>  	clk_put(kp->clk);
>  	iounmap(kp->regs);
>  	release_mem_region(kp->res->start, resource_size(kp->res));
> --
> 1.7.0.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-input" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

      reply	other threads:[~2010-09-27  5:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-26  8:59 Vasiliy Kulikov
2010-09-27  5:25 ` Datta, Shubhrajyoti [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0680EC522D0CC943BC586913CF3768C003FF0594C8@dbde02.ent.ti.com \
    --to=shubhrajyoti@ti.com \
    --cc=cyril@ti.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=khilman@deeprootsystems.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=segooon@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®