From: Neil Armstrong <neil.armstrong@linaro.org>
To: Satya Priya <quic_c_skakit@quicinc.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: mka@chromium.org, Stephen Boyd <swboyd@chromium.org>,
Andy Gross <agross@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
quic_tdas@quicinc.com, linux-clk@vger.kernel.org
Subject: Re: [PATCH] clk: qcom: lpass: Fix lpass audiocc probe
Date: Wed, 21 Sep 2022 09:45:38 +0200 [thread overview]
Message-ID: <06841d1f-840f-bc6a-0c20-21a31fdf89cb@linaro.org> (raw)
In-Reply-To: <1663673683-7018-1-git-send-email-quic_c_skakit@quicinc.com>
On 20/09/2022 13:34, Satya Priya wrote:
> Change the qcom_cc_probe_by_index() call to qcom_cc_really_probe()
> to avoid remapping of memory region for index 0, which is already
> being done through qcom_cc_map().
>
> Fixes: 7c6a6641c2 ("clk: qcom: lpass: Add support for resets & external mclk for SC7280")
> Signed-off-by: Satya Priya <quic_c_skakit@quicinc.com>
> ---
> drivers/clk/qcom/lpassaudiocc-sc7280.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/qcom/lpassaudiocc-sc7280.c b/drivers/clk/qcom/lpassaudiocc-sc7280.c
> index 5d4bc56..063e036 100644
> --- a/drivers/clk/qcom/lpassaudiocc-sc7280.c
> +++ b/drivers/clk/qcom/lpassaudiocc-sc7280.c
> @@ -785,7 +785,7 @@ static int lpass_audio_cc_sc7280_probe(struct platform_device *pdev)
> regmap_write(regmap, 0x4, 0x3b);
> regmap_write(regmap, 0x8, 0xff05);
>
> - ret = qcom_cc_probe_by_index(pdev, 0, &lpass_audio_cc_sc7280_desc);
> + ret = qcom_cc_really_probe(pdev, &lpass_audio_cc_sc7280_desc, regmap);
> if (ret) {
> dev_err(&pdev->dev, "Failed to register LPASS AUDIO CC clocks\n");
> pm_runtime_disable(&pdev->dev);
Reviewed-by: Neil Armstrong <neil.armstrong@baylibre.com>
next prev parent reply other threads:[~2022-09-21 7:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-20 11:34 Satya Priya
2022-09-21 7:45 ` Neil Armstrong [this message]
2022-09-27 3:23 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06841d1f-840f-bc6a-0c20-21a31fdf89cb@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=quic_c_skakit@quicinc.com \
--cc=quic_tdas@quicinc.com \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®