* [PATCH] clk: qcom: lpass: Fix lpass audiocc probe
@ 2022-09-20 11:34 Satya Priya
2022-09-21 7:45 ` Neil Armstrong
2022-09-27 3:23 ` Bjorn Andersson
0 siblings, 2 replies; 3+ messages in thread
From: Satya Priya @ 2022-09-20 11:34 UTC (permalink / raw)
To: Bjorn Andersson
Cc: mka, Stephen Boyd, Andy Gross, linux-arm-msm, linux-kernel,
quic_tdas, quic_c_skakit, linux-clk
Change the qcom_cc_probe_by_index() call to qcom_cc_really_probe()
to avoid remapping of memory region for index 0, which is already
being done through qcom_cc_map().
Fixes: 7c6a6641c2 ("clk: qcom: lpass: Add support for resets & external mclk for SC7280")
Signed-off-by: Satya Priya <quic_c_skakit@quicinc.com>
---
drivers/clk/qcom/lpassaudiocc-sc7280.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/qcom/lpassaudiocc-sc7280.c b/drivers/clk/qcom/lpassaudiocc-sc7280.c
index 5d4bc56..063e036 100644
--- a/drivers/clk/qcom/lpassaudiocc-sc7280.c
+++ b/drivers/clk/qcom/lpassaudiocc-sc7280.c
@@ -785,7 +785,7 @@ static int lpass_audio_cc_sc7280_probe(struct platform_device *pdev)
regmap_write(regmap, 0x4, 0x3b);
regmap_write(regmap, 0x8, 0xff05);
- ret = qcom_cc_probe_by_index(pdev, 0, &lpass_audio_cc_sc7280_desc);
+ ret = qcom_cc_really_probe(pdev, &lpass_audio_cc_sc7280_desc, regmap);
if (ret) {
dev_err(&pdev->dev, "Failed to register LPASS AUDIO CC clocks\n");
pm_runtime_disable(&pdev->dev);
--
2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] clk: qcom: lpass: Fix lpass audiocc probe
2022-09-20 11:34 [PATCH] clk: qcom: lpass: Fix lpass audiocc probe Satya Priya
@ 2022-09-21 7:45 ` Neil Armstrong
2022-09-27 3:23 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Neil Armstrong @ 2022-09-21 7:45 UTC (permalink / raw)
To: Satya Priya, Bjorn Andersson
Cc: mka, Stephen Boyd, Andy Gross, linux-arm-msm, linux-kernel,
quic_tdas, linux-clk
On 20/09/2022 13:34, Satya Priya wrote:
> Change the qcom_cc_probe_by_index() call to qcom_cc_really_probe()
> to avoid remapping of memory region for index 0, which is already
> being done through qcom_cc_map().
>
> Fixes: 7c6a6641c2 ("clk: qcom: lpass: Add support for resets & external mclk for SC7280")
> Signed-off-by: Satya Priya <quic_c_skakit@quicinc.com>
> ---
> drivers/clk/qcom/lpassaudiocc-sc7280.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/qcom/lpassaudiocc-sc7280.c b/drivers/clk/qcom/lpassaudiocc-sc7280.c
> index 5d4bc56..063e036 100644
> --- a/drivers/clk/qcom/lpassaudiocc-sc7280.c
> +++ b/drivers/clk/qcom/lpassaudiocc-sc7280.c
> @@ -785,7 +785,7 @@ static int lpass_audio_cc_sc7280_probe(struct platform_device *pdev)
> regmap_write(regmap, 0x4, 0x3b);
> regmap_write(regmap, 0x8, 0xff05);
>
> - ret = qcom_cc_probe_by_index(pdev, 0, &lpass_audio_cc_sc7280_desc);
> + ret = qcom_cc_really_probe(pdev, &lpass_audio_cc_sc7280_desc, regmap);
> if (ret) {
> dev_err(&pdev->dev, "Failed to register LPASS AUDIO CC clocks\n");
> pm_runtime_disable(&pdev->dev);
Reviewed-by: Neil Armstrong <neil.armstrong@baylibre.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] clk: qcom: lpass: Fix lpass audiocc probe
2022-09-20 11:34 [PATCH] clk: qcom: lpass: Fix lpass audiocc probe Satya Priya
2022-09-21 7:45 ` Neil Armstrong
@ 2022-09-27 3:23 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2022-09-27 3:23 UTC (permalink / raw)
To: Bjorn Andersson, quic_c_skakit
Cc: swboyd, linux-clk, linux-kernel, mka, quic_tdas, linux-arm-msm, agross
On Tue, 20 Sep 2022 17:04:43 +0530, Satya Priya wrote:
> Change the qcom_cc_probe_by_index() call to qcom_cc_really_probe()
> to avoid remapping of memory region for index 0, which is already
> being done through qcom_cc_map().
>
>
Applied, thanks!
[1/1] clk: qcom: lpass: Fix lpass audiocc probe
commit: 31e4fcf9713096c187f84bf3cb249637b8b681e1
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-27 3:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-20 11:34 [PATCH] clk: qcom: lpass: Fix lpass audiocc probe Satya Priya
2022-09-21 7:45 ` Neil Armstrong
2022-09-27 3:23 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®