* [PATCH 2/2] platform/x86: int3472: Handle GPIO type 0x10 (DOVDD) for OV5675
@ 2026-02-10 8:56 Leif Skunberg
2026-02-10 13:21 ` [PATCH v2] platform/x86: int3472: Handle GPIO type 0x10 (DOVDD) Leif Skunberg
0 siblings, 1 reply; 4+ messages in thread
From: Leif Skunberg @ 2026-02-10 8:56 UTC (permalink / raw)
To: dan.scally, sakari.ailus
Cc: hansg, ilpo.jarvinen, platform-driver-x86, linux-kernel, Leif Skunberg
The Lenovo ThinkPad X1 Fold 16 Gen 1 has an OV5675 sensor (ACPI HID
OVTI5675) behind an INT3472 discrete PMIC controller. The INT3472
_DSM returns GPIO type 0x10 for one of the pins, which controls the
DOVDD (digital I/O power) regulator enable.
Type 0x10 is not currently handled by the driver, causing the GPIO to
be ignored with a warning. Add INT3472_GPIO_TYPE_DOVDD (0x10) and
handle it by:
1. Adding an entry to int3472_gpio_map[] that maps the DOVDD type to
INT3472_GPIO_TYPE_POWER_ENABLE for the OVTI5675 HID. The con_id
is set to "vio" because "dovdd" exceeds GPIO_SUPPLY_NAME_LENGTH.
2. Adding a fallback case in int3472_get_con_id_and_polarity() so
devices without a gpio_map match still get a valid con_id.
3. Adding INT3472_GPIO_TYPE_DOVDD to both switch statements in
skl_int3472_handle_gpio_resources() so the GPIO is acquired via
temp lookup and registered as a regulator.
Signed-off-by: Leif Skunberg <diamondback@cohunt.app>
---
drivers/platform/x86/intel/int3472/discrete.c | 14 ++++++++++++++
include/linux/platform_data/x86/int3472.h | 1 +
2 files changed, 15 insertions(+)
diff --git a/drivers/platform/x86/intel/int3472/discrete.c b/drivers/platform/x86/intel/int3472/discrete.c
index 1505fc3ef..0a293e73c 100644
--- a/drivers/platform/x86/intel/int3472/discrete.c
+++ b/drivers/platform/x86/intel/int3472/discrete.c
@@ -164,6 +164,13 @@ static const struct int3472_gpio_map int3472_gpio_map[] = {
.con_id = "dvdd",
.enable_time_us = 45 * USEC_PER_MSEC,
},
+ { /* ov5675: DOVDD is a power regulator enable */
+ .hid = "OVTI5675",
+ .type_from = INT3472_GPIO_TYPE_DOVDD,
+ .type_to = INT3472_GPIO_TYPE_POWER_ENABLE,
+ .con_id = "vio",
+ .enable_time_us = GPIO_REGULATOR_ENABLE_TIME,
+ },
};
static void int3472_get_con_id_and_polarity(struct int3472_discrete_device *int3472, u8 *type,
@@ -223,6 +230,10 @@ static void int3472_get_con_id_and_polarity(struct int3472_discrete_device *int3
*con_id = "avdd";
*gpio_flags = GPIO_ACTIVE_HIGH;
break;
+ case INT3472_GPIO_TYPE_DOVDD:
+ *con_id = "vio";
+ *gpio_flags = GPIO_ACTIVE_HIGH;
+ break;
case INT3472_GPIO_TYPE_HANDSHAKE:
*con_id = "dvdd";
*gpio_flags = GPIO_ACTIVE_HIGH;
@@ -251,6 +262,7 @@ static void int3472_get_con_id_and_polarity(struct int3472_discrete_device *int3
* 0x0b Power enable
* 0x0c Clock enable
* 0x0d Privacy LED
+ * 0x10 DOVDD (digital I/O voltage)
* 0x13 Hotplug detect
*
* There are some known platform specific quirks where that does not quite
@@ -332,6 +344,7 @@ static int skl_int3472_handle_gpio_resources(struct acpi_resource *ares,
case INT3472_GPIO_TYPE_CLK_ENABLE:
case INT3472_GPIO_TYPE_PRIVACY_LED:
case INT3472_GPIO_TYPE_POWER_ENABLE:
+ case INT3472_GPIO_TYPE_DOVDD:
case INT3472_GPIO_TYPE_HANDSHAKE:
gpio = skl_int3472_gpiod_get_from_temp_lookup(int3472, agpio, con_id, gpio_flags);
if (IS_ERR(gpio)) {
@@ -356,6 +369,7 @@ static int skl_int3472_handle_gpio_resources(struct acpi_resource *ares,
case INT3472_GPIO_TYPE_POWER_ENABLE:
second_sensor = int3472->quirks.avdd_second_sensor;
fallthrough;
+ case INT3472_GPIO_TYPE_DOVDD:
case INT3472_GPIO_TYPE_HANDSHAKE:
ret = skl_int3472_register_regulator(int3472, gpio, enable_time_us,
con_id, second_sensor);
diff --git a/include/linux/platform_data/x86/int3472.h b/include/linux/platform_data/x86/int3472.h
index b1b837583..d72c621f7 100644
--- a/include/linux/platform_data/x86/int3472.h
+++ b/include/linux/platform_data/x86/int3472.h
@@ -26,6 +26,7 @@
#define INT3472_GPIO_TYPE_POWER_ENABLE 0x0b
#define INT3472_GPIO_TYPE_CLK_ENABLE 0x0c
#define INT3472_GPIO_TYPE_PRIVACY_LED 0x0d
+#define INT3472_GPIO_TYPE_DOVDD 0x10
#define INT3472_GPIO_TYPE_HANDSHAKE 0x12
#define INT3472_GPIO_TYPE_HOTPLUG_DETECT 0x13
--
2.53.0
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH v2] platform/x86: int3472: Handle GPIO type 0x10 (DOVDD)
2026-02-10 8:56 [PATCH 2/2] platform/x86: int3472: Handle GPIO type 0x10 (DOVDD) for OV5675 Leif Skunberg
@ 2026-02-10 13:21 ` Leif Skunberg
2026-02-10 13:31 ` Hans de Goede
2026-02-23 16:34 ` Ilpo Järvinen
0 siblings, 2 replies; 4+ messages in thread
From: Leif Skunberg @ 2026-02-10 13:21 UTC (permalink / raw)
To: dan.scally, sakari.ailus
Cc: hansg, ilpo.jarvinen, platform-driver-x86, linux-kernel, Leif Skunberg
The Lenovo ThinkPad X1 Fold 16 Gen 1 has an OV5675 sensor (ACPI HID
OVTI5675) behind an INT3472 discrete PMIC controller. The INT3472
_DSM returns GPIO type 0x10 for one of the pins, which controls the
DOVDD (digital I/O power) regulator enable.
Type 0x10 is not currently handled by the driver, causing the GPIO to
be ignored with a warning. Add INT3472_GPIO_TYPE_DOVDD (0x10) and
handle it as a regulator with con_id "dovdd" to match the supply name
used by sensor drivers (e.g. ov5675).
Also increase GPIO_SUPPLY_NAME_LENGTH from 5 to 6 to accommodate
the "dovdd" name (5 chars + null terminator).
Signed-off-by: Leif Skunberg <diamondback@cohunt.app>
---
drivers/platform/x86/intel/int3472/discrete.c | 7 +++++++
include/linux/platform_data/x86/int3472.h | 5 +++--
2 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/drivers/platform/x86/intel/int3472/discrete.c b/drivers/platform/x86/intel/int3472/discrete.c
index 1505fc3ef..fec8a899c 100644
--- a/drivers/platform/x86/intel/int3472/discrete.c
+++ b/drivers/platform/x86/intel/int3472/discrete.c
@@ -223,6 +223,10 @@ static void int3472_get_con_id_and_polarity(struct int3472_discrete_device *int3
*con_id = "avdd";
*gpio_flags = GPIO_ACTIVE_HIGH;
break;
+ case INT3472_GPIO_TYPE_DOVDD:
+ *con_id = "dovdd";
+ *gpio_flags = GPIO_ACTIVE_HIGH;
+ break;
case INT3472_GPIO_TYPE_HANDSHAKE:
*con_id = "dvdd";
*gpio_flags = GPIO_ACTIVE_HIGH;
@@ -251,6 +255,7 @@ static void int3472_get_con_id_and_polarity(struct int3472_discrete_device *int3
* 0x0b Power enable
* 0x0c Clock enable
* 0x0d Privacy LED
+ * 0x10 DOVDD (digital I/O voltage)
* 0x13 Hotplug detect
*
* There are some known platform specific quirks where that does not quite
@@ -332,6 +337,7 @@ static int skl_int3472_handle_gpio_resources(struct acpi_resource *ares,
case INT3472_GPIO_TYPE_CLK_ENABLE:
case INT3472_GPIO_TYPE_PRIVACY_LED:
case INT3472_GPIO_TYPE_POWER_ENABLE:
+ case INT3472_GPIO_TYPE_DOVDD:
case INT3472_GPIO_TYPE_HANDSHAKE:
gpio = skl_int3472_gpiod_get_from_temp_lookup(int3472, agpio, con_id, gpio_flags);
if (IS_ERR(gpio)) {
@@ -356,6 +362,7 @@ static int skl_int3472_handle_gpio_resources(struct acpi_resource *ares,
case INT3472_GPIO_TYPE_POWER_ENABLE:
second_sensor = int3472->quirks.avdd_second_sensor;
fallthrough;
+ case INT3472_GPIO_TYPE_DOVDD:
case INT3472_GPIO_TYPE_HANDSHAKE:
ret = skl_int3472_register_regulator(int3472, gpio, enable_time_us,
con_id, second_sensor);
diff --git a/include/linux/platform_data/x86/int3472.h b/include/linux/platform_data/x86/int3472.h
index b1b837583..dbe745dc8 100644
--- a/include/linux/platform_data/x86/int3472.h
+++ b/include/linux/platform_data/x86/int3472.h
@@ -26,6 +26,7 @@
#define INT3472_GPIO_TYPE_POWER_ENABLE 0x0b
#define INT3472_GPIO_TYPE_CLK_ENABLE 0x0c
#define INT3472_GPIO_TYPE_PRIVACY_LED 0x0d
+#define INT3472_GPIO_TYPE_DOVDD 0x10
#define INT3472_GPIO_TYPE_HANDSHAKE 0x12
#define INT3472_GPIO_TYPE_HOTPLUG_DETECT 0x13
@@ -33,8 +34,8 @@
#define INT3472_MAX_SENSOR_GPIOS 3
#define INT3472_MAX_REGULATORS 3
-/* E.g. "avdd\0" */
-#define GPIO_SUPPLY_NAME_LENGTH 5
+/* E.g. "dovdd\0" */
+#define GPIO_SUPPLY_NAME_LENGTH 6
/* 12 chars for acpi_dev_name() + "-", e.g. "ABCD1234:00-" */
#define GPIO_REGULATOR_NAME_LENGTH (12 + GPIO_SUPPLY_NAME_LENGTH)
/* lower- and upper-case mapping */
--
2.53.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] platform/x86: int3472: Handle GPIO type 0x10 (DOVDD)
2026-02-10 13:21 ` [PATCH v2] platform/x86: int3472: Handle GPIO type 0x10 (DOVDD) Leif Skunberg
@ 2026-02-10 13:31 ` Hans de Goede
2026-02-23 16:34 ` Ilpo Järvinen
1 sibling, 0 replies; 4+ messages in thread
From: Hans de Goede @ 2026-02-10 13:31 UTC (permalink / raw)
To: Leif Skunberg, dan.scally, sakari.ailus
Cc: ilpo.jarvinen, platform-driver-x86, linux-kernel
Hi,
On 10-Feb-26 14:21, Leif Skunberg wrote:
> The Lenovo ThinkPad X1 Fold 16 Gen 1 has an OV5675 sensor (ACPI HID
> OVTI5675) behind an INT3472 discrete PMIC controller. The INT3472
> _DSM returns GPIO type 0x10 for one of the pins, which controls the
> DOVDD (digital I/O power) regulator enable.
>
> Type 0x10 is not currently handled by the driver, causing the GPIO to
> be ignored with a warning. Add INT3472_GPIO_TYPE_DOVDD (0x10) and
> handle it as a regulator with con_id "dovdd" to match the supply name
> used by sensor drivers (e.g. ov5675).
>
> Also increase GPIO_SUPPLY_NAME_LENGTH from 5 to 6 to accommodate
> the "dovdd" name (5 chars + null terminator).
>
> Signed-off-by: Leif Skunberg <diamondback@cohunt.app>
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede <johannes.goede@oss.qualcomm.com>
Regards,
Hans
> ---
> drivers/platform/x86/intel/int3472/discrete.c | 7 +++++++
> include/linux/platform_data/x86/int3472.h | 5 +++--
> 2 files changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/platform/x86/intel/int3472/discrete.c b/drivers/platform/x86/intel/int3472/discrete.c
> index 1505fc3ef..fec8a899c 100644
> --- a/drivers/platform/x86/intel/int3472/discrete.c
> +++ b/drivers/platform/x86/intel/int3472/discrete.c
> @@ -223,6 +223,10 @@ static void int3472_get_con_id_and_polarity(struct int3472_discrete_device *int3
> *con_id = "avdd";
> *gpio_flags = GPIO_ACTIVE_HIGH;
> break;
> + case INT3472_GPIO_TYPE_DOVDD:
> + *con_id = "dovdd";
> + *gpio_flags = GPIO_ACTIVE_HIGH;
> + break;
> case INT3472_GPIO_TYPE_HANDSHAKE:
> *con_id = "dvdd";
> *gpio_flags = GPIO_ACTIVE_HIGH;
> @@ -251,6 +255,7 @@ static void int3472_get_con_id_and_polarity(struct int3472_discrete_device *int3
> * 0x0b Power enable
> * 0x0c Clock enable
> * 0x0d Privacy LED
> + * 0x10 DOVDD (digital I/O voltage)
> * 0x13 Hotplug detect
> *
> * There are some known platform specific quirks where that does not quite
> @@ -332,6 +337,7 @@ static int skl_int3472_handle_gpio_resources(struct acpi_resource *ares,
> case INT3472_GPIO_TYPE_CLK_ENABLE:
> case INT3472_GPIO_TYPE_PRIVACY_LED:
> case INT3472_GPIO_TYPE_POWER_ENABLE:
> + case INT3472_GPIO_TYPE_DOVDD:
> case INT3472_GPIO_TYPE_HANDSHAKE:
> gpio = skl_int3472_gpiod_get_from_temp_lookup(int3472, agpio, con_id, gpio_flags);
> if (IS_ERR(gpio)) {
> @@ -356,6 +362,7 @@ static int skl_int3472_handle_gpio_resources(struct acpi_resource *ares,
> case INT3472_GPIO_TYPE_POWER_ENABLE:
> second_sensor = int3472->quirks.avdd_second_sensor;
> fallthrough;
> + case INT3472_GPIO_TYPE_DOVDD:
> case INT3472_GPIO_TYPE_HANDSHAKE:
> ret = skl_int3472_register_regulator(int3472, gpio, enable_time_us,
> con_id, second_sensor);
> diff --git a/include/linux/platform_data/x86/int3472.h b/include/linux/platform_data/x86/int3472.h
> index b1b837583..dbe745dc8 100644
> --- a/include/linux/platform_data/x86/int3472.h
> +++ b/include/linux/platform_data/x86/int3472.h
> @@ -26,6 +26,7 @@
> #define INT3472_GPIO_TYPE_POWER_ENABLE 0x0b
> #define INT3472_GPIO_TYPE_CLK_ENABLE 0x0c
> #define INT3472_GPIO_TYPE_PRIVACY_LED 0x0d
> +#define INT3472_GPIO_TYPE_DOVDD 0x10
> #define INT3472_GPIO_TYPE_HANDSHAKE 0x12
> #define INT3472_GPIO_TYPE_HOTPLUG_DETECT 0x13
>
> @@ -33,8 +34,8 @@
> #define INT3472_MAX_SENSOR_GPIOS 3
> #define INT3472_MAX_REGULATORS 3
>
> -/* E.g. "avdd\0" */
> -#define GPIO_SUPPLY_NAME_LENGTH 5
> +/* E.g. "dovdd\0" */
> +#define GPIO_SUPPLY_NAME_LENGTH 6
> /* 12 chars for acpi_dev_name() + "-", e.g. "ABCD1234:00-" */
> #define GPIO_REGULATOR_NAME_LENGTH (12 + GPIO_SUPPLY_NAME_LENGTH)
> /* lower- and upper-case mapping */
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] platform/x86: int3472: Handle GPIO type 0x10 (DOVDD)
2026-02-10 13:21 ` [PATCH v2] platform/x86: int3472: Handle GPIO type 0x10 (DOVDD) Leif Skunberg
2026-02-10 13:31 ` Hans de Goede
@ 2026-02-23 16:34 ` Ilpo Järvinen
1 sibling, 0 replies; 4+ messages in thread
From: Ilpo Järvinen @ 2026-02-23 16:34 UTC (permalink / raw)
To: dan.scally, sakari.ailus, Leif Skunberg
Cc: hansg, platform-driver-x86, linux-kernel
On Tue, 10 Feb 2026 14:21:29 +0100, Leif Skunberg wrote:
> The Lenovo ThinkPad X1 Fold 16 Gen 1 has an OV5675 sensor (ACPI HID
> OVTI5675) behind an INT3472 discrete PMIC controller. The INT3472
> _DSM returns GPIO type 0x10 for one of the pins, which controls the
> DOVDD (digital I/O power) regulator enable.
>
> Type 0x10 is not currently handled by the driver, causing the GPIO to
> be ignored with a warning. Add INT3472_GPIO_TYPE_DOVDD (0x10) and
> handle it as a regulator with con_id "dovdd" to match the supply name
> used by sensor drivers (e.g. ov5675).
>
> [...]
Thank you for your contribution, it has been applied to my local
review-ilpo-fixes branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my
local branch there, which might take a while.
The list of commits applied:
[1/1] platform/x86: int3472: Handle GPIO type 0x10 (DOVDD)
commit: 2a7b7652b1bb3fadc3bd47d622bfb127a93ab6b0
--
i.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-02-23 16:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-02-10 8:56 [PATCH 2/2] platform/x86: int3472: Handle GPIO type 0x10 (DOVDD) for OV5675 Leif Skunberg
2026-02-10 13:21 ` [PATCH v2] platform/x86: int3472: Handle GPIO type 0x10 (DOVDD) Leif Skunberg
2026-02-10 13:31 ` Hans de Goede
2026-02-23 16:34 ` Ilpo Järvinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®