mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michal Luczaj <mhal@rbox.co>
To: Stefano Garzarella <sgarzare@redhat.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Simon Horman <horms@kernel.org>,
	virtualization@lists.linux.dev, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] vsock: Ignore signal/timeout on connect() if already established
Date: Thu, 20 Nov 2025 22:12:20 +0100	[thread overview]
Message-ID: <06936b55-b359-4e3d-bec0-b157ca32d237@rbox.co> (raw)
In-Reply-To: <1b2255c7-0e97-4b37-b7ab-e13e90b7b0b9@rbox.co>

On 11/19/25 20:52, Michal Luczaj wrote:
> ...
> To follow up, should I add a version of syzkaller's lockdep warning repro
> to vsock test suite? In theory it could test this fix here as well, but in
> practice the race window is small and hitting it (the brute way) takes
> prohibitively long.

Replying to self to add more data.

After reverting

f7c877e75352 ("vsock: fix lock inversion in vsock_assign_transport()")
002541ef650b ("vsock: Ignore signal/timeout on connect() if already
established")

adding

--- a/tools/testing/vsock/vsock_test.c
+++ b/tools/testing/vsock/vsock_test.c
@@ -2014,6 +2014,7 @@ static void test_stream_transport_change_client(const
struct test_opts *opts)
                        perror("socket");
                        exit(EXIT_FAILURE);
                }
+               enable_so_linger(s, 1);

                ret = connect(s, (struct sockaddr *)&sa, sizeof(sa));
                /* The connect can fail due to signals coming from the

is enough for vsock_test to trigger the lockdep warning syzkaller found.


  reply	other threads:[~2025-11-20 21:12 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-17 20:57 Michal Luczaj
2025-11-18  9:51 ` Stefano Garzarella
2025-11-18 22:02   ` Michal Luczaj
2025-11-19 10:36     ` Stefano Garzarella
2025-11-19 14:09       ` Michal Luczaj
2025-11-19 16:31         ` Stefano Garzarella
2025-11-19 19:52           ` Michal Luczaj
2025-11-20 21:12             ` Michal Luczaj [this message]
2025-11-21  9:21               ` Stefano Garzarella
2025-11-23 21:46                 ` Michal Luczaj
2025-11-24 11:49                   ` Stefano Garzarella
2026-01-23 16:52                     ` Michal Luczaj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=06936b55-b359-4e3d-bec0-b157ca32d237@rbox.co \
    --to=mhal@rbox.co \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sgarzare@redhat.com \
    --cc=virtualization@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®