From: Jon Hunter <jonathanh@nvidia.com>
To: Kartik Rajput <kkartik@nvidia.com>,
ldewangan@nvidia.com, digetx@gmail.com, andi.shyti@kernel.org,
thierry.reding@gmail.com, akhilrajeev@nvidia.com,
smangipudi@nvidia.com, linux-i2c@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 0/4] Add I2C support for Tegra410
Date: Wed, 21 Jan 2026 14:31:43 +0000 [thread overview]
Message-ID: <06bc4b6b-e758-4e38-9520-c373646c7360@nvidia.com> (raw)
In-Reply-To: <20260120092032.83100-1-kkartik@nvidia.com>
On 20/01/2026 09:20, Kartik Rajput wrote:
> Add support for the Tegra410 SoC, which has 4 I2C controllers. The
> controllers are feature-equivalent to Tegra264; only the register
> offsets differ.
>
> Kartik Rajput (4):
> i2c: tegra: Introduce tegra_i2c_variant to identify DVC and VI
> i2c: tegra: Move variant to tegra_i2c_hw_feature
> i2c: tegra: Add logic to support different register offsets
> i2c: tegra: Add support for Tegra410
>
> drivers/i2c/busses/i2c-tegra.c | 557 ++++++++++++++++++++++++---------
> 1 file changed, 401 insertions(+), 156 deletions(-)
>
Series looks good to me in general. Unfortunately the commit message in
3/4 is still not correct and now makes me wonder if we should even mess
with the tegra_dvc_init() function?
Jon
--
nvpublic
prev parent reply other threads:[~2026-01-21 14:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-20 9:20 Kartik Rajput
2026-01-20 9:20 ` [PATCH v8 1/4] i2c: tegra: Introduce tegra_i2c_variant to identify DVC and VI Kartik Rajput
2026-01-20 9:20 ` [PATCH v8 2/4] i2c: tegra: Move variant to tegra_i2c_hw_feature Kartik Rajput
2026-01-20 9:20 ` [PATCH v8 3/4] i2c: tegra: Add logic to support different register offsets Kartik Rajput
2026-01-21 14:30 ` Jon Hunter
2026-01-21 15:36 ` Kartik Rajput
2026-01-20 9:20 ` [PATCH v8 4/4] i2c: tegra: Add support for Tegra410 Kartik Rajput
2026-01-21 14:31 ` Jon Hunter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06bc4b6b-e758-4e38-9520-c373646c7360@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=akhilrajeev@nvidia.com \
--cc=andi.shyti@kernel.org \
--cc=digetx@gmail.com \
--cc=kkartik@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=smangipudi@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®