From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Banajit Goswami <bgoswami@quicinc.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
alsa-devel@alsa-project.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Patrick Lai <plai@qti.qualcomm.com>,
Srinivasa Rao Mandadapu <srivasam@qti.qualcomm.com>
Subject: Re: [PATCH 00/10] ASoC: dt-bindings: Rework Qualcomm APR/GPR Sound nodes for SM8450
Date: Fri, 11 Nov 2022 16:15:28 +0000 [thread overview]
Message-ID: <06da072c-8cf0-8181-3c32-4592fe41f9c2@linaro.org> (raw)
In-Reply-To: <20221111113547.100442-1-krzysztof.kozlowski@linaro.org>
On 11/11/2022 11:35, Krzysztof Kozlowski wrote:
> Adding sound support for Qualcomm SM8450 SoC (and later for SC8280XP) brought
> some changes to APR/GPR services bindings. These bindings are part of
> qcom,apr.yaml:
>
> apr-or-gpr-device-node <- qcom,apr.yaml
> apr-gpr-service@[0-9] <- qcom,apr.yaml
> service-specific-components <- /schemas/sound/qcom,q6*.yaml
>
> The schema for services (apr-gpr-service@[0-9]) already grows considerably and
> is still quite not specific. It allows several incorrect combinations, like
> adding a clock-controller to a APM device. Restricting it would complicate the
> schema even more. Bringing new support for sound on Qualcomm SM8450 and
> SC8280XP SoC would grow it as well.
Why would this grow? All the dsp services are static and they will not
change per SoC unless there is a total firmware change in DSP.
>
> Refactor the bindings before extending them for Qualcomm SM8450 SoC.
I dont understand this bit, what is SoC audio support to do with DSP
bindings. DSP bindings should be totally independent of this.
>
--srini
> Best regards,
> Krzysztof
>
> Krzysztof Kozlowski (10):
> ASoC: dt-bindings: qcom,apr: Add GLINK channel name for SM8450
> ASoC: dt-bindings: qcom,apr: Split services to shared schema
> ASoC: dt-bindings: qcom,q6afe: Split to separate schema
> ASoC: dt-bindings: qcom,q6apm: Split to separate schema
> ASoC: dt-bindings: qcom,q6adm: Split to separate schema
> ASoC: dt-bindings: qcom,q6asm: Split to separate schema
> ASoC: dt-bindings: qcom,q6prm: Split to separate schema
> ASoC: dt-bindings: qcom,q6core: Split to separate schema
> ASoC: dt-bindings: qcom,q6apm-lpass-dais: Split to separate schema
> ASoC: dt-bindings: qcom,q6apm: Add SM8450 bedais node
>
> .../bindings/soc/qcom/qcom,apr-services.yaml | 54 ++++++++
> .../bindings/soc/qcom/qcom,apr.yaml | 119 ++----------------
> .../bindings/sound/qcom,q6adm-routing.yaml | 22 +---
> .../devicetree/bindings/sound/qcom,q6adm.yaml | 51 ++++++++
> .../devicetree/bindings/sound/qcom,q6afe.yaml | 69 ++++++++++
> .../bindings/sound/qcom,q6apm-dai.yaml | 19 +--
> .../bindings/sound/qcom,q6apm-lpass-dais.yaml | 32 +++++
> .../devicetree/bindings/sound/qcom,q6apm.yaml | 67 ++++++++++
> .../bindings/sound/qcom,q6asm-dais.yaml | 48 +++----
> .../devicetree/bindings/sound/qcom,q6asm.yaml | 68 ++++++++++
> .../bindings/sound/qcom,q6core.yaml | 39 ++++++
> .../sound/qcom,q6dsp-lpass-clocks.yaml | 40 +-----
> .../sound/qcom,q6dsp-lpass-ports.yaml | 57 ++-------
> .../devicetree/bindings/sound/qcom,q6prm.yaml | 50 ++++++++
> MAINTAINERS | 2 +-
> 15 files changed, 477 insertions(+), 260 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,apr-services.yaml
> create mode 100644 Documentation/devicetree/bindings/sound/qcom,q6adm.yaml
> create mode 100644 Documentation/devicetree/bindings/sound/qcom,q6afe.yaml
> create mode 100644 Documentation/devicetree/bindings/sound/qcom,q6apm-lpass-dais.yaml
> create mode 100644 Documentation/devicetree/bindings/sound/qcom,q6apm.yaml
> create mode 100644 Documentation/devicetree/bindings/sound/qcom,q6asm.yaml
> create mode 100644 Documentation/devicetree/bindings/sound/qcom,q6core.yaml
> create mode 100644 Documentation/devicetree/bindings/sound/qcom,q6prm.yaml
>
next prev parent reply other threads:[~2022-11-11 16:15 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-11 11:35 Krzysztof Kozlowski
2022-11-11 11:35 ` [PATCH 01/10] ASoC: dt-bindings: qcom,apr: Add GLINK channel name " Krzysztof Kozlowski
2022-11-11 11:35 ` [PATCH 02/10] ASoC: dt-bindings: qcom,apr: Split services to shared schema Krzysztof Kozlowski
2022-11-11 13:30 ` Rob Herring
2022-11-11 14:21 ` Krzysztof Kozlowski
2022-11-11 16:35 ` Srinivas Kandagatla
2022-11-14 7:45 ` Krzysztof Kozlowski
2022-11-15 10:22 ` Krzysztof Kozlowski
2022-11-11 11:35 ` [PATCH 03/10] ASoC: dt-bindings: qcom,q6afe: Split to separate schema Krzysztof Kozlowski
2022-11-11 11:35 ` [PATCH 04/10] ASoC: dt-bindings: qcom,q6apm: " Krzysztof Kozlowski
2022-11-11 11:35 ` [PATCH 05/10] ASoC: dt-bindings: qcom,q6adm: " Krzysztof Kozlowski
2022-11-11 11:35 ` [PATCH 06/10] ASoC: dt-bindings: qcom,q6asm: " Krzysztof Kozlowski
2022-11-11 11:35 ` [PATCH 07/10] ASoC: dt-bindings: qcom,q6prm: " Krzysztof Kozlowski
2022-11-11 11:35 ` [PATCH 08/10] ASoC: dt-bindings: qcom,q6core: " Krzysztof Kozlowski
2022-11-11 11:35 ` [PATCH 09/10] ASoC: dt-bindings: qcom,q6apm-lpass-dais: " Krzysztof Kozlowski
2022-11-11 11:35 ` [PATCH 10/10] ASoC: dt-bindings: qcom,q6apm: Add SM8450 bedais node Krzysztof Kozlowski
2022-11-14 11:40 ` Srinivas Kandagatla
2022-11-14 12:08 ` Krzysztof Kozlowski
2022-11-11 12:10 ` [PATCH 00/10] ASoC: dt-bindings: Rework Qualcomm APR/GPR Sound nodes for SM8450 Krzysztof Kozlowski
2022-11-11 16:15 ` Srinivas Kandagatla [this message]
2022-11-14 7:48 ` Krzysztof Kozlowski
2022-11-14 11:50 ` Srinivas Kandagatla
2022-11-14 12:09 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06da072c-8cf0-8181-3c32-4592fe41f9c2@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=agross@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=andersson@kernel.org \
--cc=bgoswami@quicinc.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=plai@qti.qualcomm.com \
--cc=robh+dt@kernel.org \
--cc=srivasam@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®