From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Mark Brown <broonie@kernel.org>,
Banajit Goswami <bgoswami@quicinc.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Andy Gross <agross@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Patrick Lai <plai@qti.qualcomm.com>,
Rob Herring <robh+dt@kernel.org>,
Srinivasa Rao Mandadapu <srivasam@qti.qualcomm.com>,
alsa-devel@alsa-project.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 02/10] ASoC: dt-bindings: qcom,apr: Split services to shared schema
Date: Fri, 11 Nov 2022 15:21:49 +0100 [thread overview]
Message-ID: <f7be60a6-ea1d-838a-ef50-d324d918db86@linaro.org> (raw)
In-Reply-To: <166817308876.3060199.17933327732327950670.robh@kernel.org>
On 11/11/2022 14:30, Rob Herring wrote:
>
> On Fri, 11 Nov 2022 12:35:39 +0100, Krzysztof Kozlowski wrote:
>> The APR/GPR nodes are organized like:
>>
>> apr-or-gpr-device-node <- qcom,apr.yaml
>> apr-gpr-service@[0-9] <- qcom,apr.yaml
>> service-specific-components <- /schemas/sound/qcom,q6*.yaml
>>
>> The schema for services (apr-gpr-service@[0-9]) already grows
>> considerably and is still quite not specific. It allows several
>> incorrect combinations, like adding a clock-controller to a APM device.
>> Restricting it would complicate the schema even more. Bringing new
>> support for sound on Qualcomm SM8450 and SC8280XP SoC would grow it as
>> well.
>>
>> Simplify the qcom,apr.yaml by splitting the services to a shared file
>> which will be:
>> 1. Referenced by qcom,apr.yaml with additionalProperties:true,
>> 2. Referenced by specific bindings for services with
>> additionalProperties:false (not yet in this commit).
>>
>> While moving the code, add also required 'reg' and
>> 'qcom,protection-domain' to further constrain the bindings.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>> .../bindings/soc/qcom/qcom,apr-services.yaml | 54 +++++++++
>> .../bindings/soc/qcom/qcom,apr.yaml | 108 +-----------------
>> MAINTAINERS | 2 +-
>> 3 files changed, 58 insertions(+), 106 deletions(-)
>> create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,apr-services.yaml
>>
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> Documentation/devicetree/bindings/soc/qcom/qcom,apr.example.dtb:0:0: /example-0/apr/service@3: failed to match any schema with compatible: ['qcom,q6core']
> Documentation/devicetree/bindings/soc/qcom/qcom,apr.example.dtb:0:0: /example-0/apr/service@4: failed to match any schema with compatible: ['qcom,q6afe']
> Documentation/devicetree/bindings/soc/qcom/qcom,apr.example.dtb:0:0: /example-0/apr/service@7: failed to match any schema with compatible: ['qcom,q6asm']
> Documentation/devicetree/bindings/soc/qcom/qcom,apr.example.dtb:0:0: /example-0/apr/service@8: failed to match any schema with compatible: ['qcom,q6adm']
This is expected. I should have mention maybe in commit msg that these
compatibles are being removed in this commit and re-added in further
commits. Change is therefore not entirely bisectable, but should be
easier for review.
If desired, I can squash these commits.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-11-11 14:23 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-11 11:35 [PATCH 00/10] ASoC: dt-bindings: Rework Qualcomm APR/GPR Sound nodes for SM8450 Krzysztof Kozlowski
2022-11-11 11:35 ` [PATCH 01/10] ASoC: dt-bindings: qcom,apr: Add GLINK channel name " Krzysztof Kozlowski
2022-11-11 11:35 ` [PATCH 02/10] ASoC: dt-bindings: qcom,apr: Split services to shared schema Krzysztof Kozlowski
2022-11-11 13:30 ` Rob Herring
2022-11-11 14:21 ` Krzysztof Kozlowski [this message]
2022-11-11 16:35 ` Srinivas Kandagatla
2022-11-14 7:45 ` Krzysztof Kozlowski
2022-11-15 10:22 ` Krzysztof Kozlowski
2022-11-11 11:35 ` [PATCH 03/10] ASoC: dt-bindings: qcom,q6afe: Split to separate schema Krzysztof Kozlowski
2022-11-11 11:35 ` [PATCH 04/10] ASoC: dt-bindings: qcom,q6apm: " Krzysztof Kozlowski
2022-11-11 11:35 ` [PATCH 05/10] ASoC: dt-bindings: qcom,q6adm: " Krzysztof Kozlowski
2022-11-11 11:35 ` [PATCH 06/10] ASoC: dt-bindings: qcom,q6asm: " Krzysztof Kozlowski
2022-11-11 11:35 ` [PATCH 07/10] ASoC: dt-bindings: qcom,q6prm: " Krzysztof Kozlowski
2022-11-11 11:35 ` [PATCH 08/10] ASoC: dt-bindings: qcom,q6core: " Krzysztof Kozlowski
2022-11-11 11:35 ` [PATCH 09/10] ASoC: dt-bindings: qcom,q6apm-lpass-dais: " Krzysztof Kozlowski
2022-11-11 11:35 ` [PATCH 10/10] ASoC: dt-bindings: qcom,q6apm: Add SM8450 bedais node Krzysztof Kozlowski
2022-11-14 11:40 ` Srinivas Kandagatla
2022-11-14 12:08 ` Krzysztof Kozlowski
2022-11-11 12:10 ` [PATCH 00/10] ASoC: dt-bindings: Rework Qualcomm APR/GPR Sound nodes for SM8450 Krzysztof Kozlowski
2022-11-11 16:15 ` Srinivas Kandagatla
2022-11-14 7:48 ` Krzysztof Kozlowski
2022-11-14 11:50 ` Srinivas Kandagatla
2022-11-14 12:09 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7be60a6-ea1d-838a-ef50-d324d918db86@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=andersson@kernel.org \
--cc=bgoswami@quicinc.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=plai@qti.qualcomm.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=srivasam@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®