From: Vidya Sagar <vidyas@nvidia.com>
To: Dmitry Osipenko <digetx@gmail.com>, <lorenzo.pieralisi@arm.com>,
<bhelgaas@google.com>, <robh+dt@kernel.org>,
<mark.rutland@arm.com>, <thierry.reding@gmail.com>,
<jonathanh@nvidia.com>, <kishon@ti.com>,
<catalin.marinas@arm.com>, <will.deacon@arm.com>,
<jingoohan1@gmail.com>, <gustavo.pimentel@synopsys.com>
Cc: <mperttunen@nvidia.com>, <linux-pci@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <kthota@nvidia.com>,
<mmaddireddy@nvidia.com>, <sagar.tv@gmail.com>
Subject: Re: [PATCH V8 14/15] PCI: tegra: Add Tegra194 PCIe support
Date: Fri, 7 Jun 2019 19:40:37 +0530 [thread overview]
Message-ID: <06f2f74e-d618-8688-14ae-beb4920bcbf6@nvidia.com> (raw)
In-Reply-To: <cbdac43f-32f7-c992-832b-ed40bef2375b@gmail.com>
On 6/7/2019 12:22 AM, Dmitry Osipenko wrote:
> 06.06.2019 19:35, Dmitry Osipenko пишет:
>> 26.05.2019 7:37, Vidya Sagar пишет:
>>> Add support for Synopsys DesignWare core IP based PCIe host controller
>>> present in Tegra194 SoC.
>>>
>>> Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
>>> ---
>>> Changes since [v7]:
>>> * Addressed review comments from Thierry
>>>
>>> Changes since [v6]:
>>> * Removed code around "nvidia,disable-aspm-states" DT property
>>> * Refactored code to remove code duplication
>>>
>>> Changes since [v5]:
>>> * Addressed review comments from Thierry
>>>
>>> Changes since [v4]:
>>> * None
>>>
>>> Changes since [v3]:
>>> * None
>>>
>>> Changes since [v2]:
>>> * Changed 'nvidia,init-speed' to 'nvidia,init-link-speed'
>>> * Changed 'nvidia,pex-wake' to 'nvidia,wake-gpios'
>>> * Removed .runtime_suspend() & .runtime_resume() implementations
>>>
>>> Changes since [v1]:
>>> * Made CONFIG_PCIE_TEGRA194 as 'm' by default from its previous 'y' state
>>> * Modified code as per changes made to DT documentation
>>> * Refactored code to address Bjorn & Thierry's review comments
>>> * Added goto to avoid recursion in tegra_pcie_dw_host_init() API
>>> * Merged .scan_bus() of dw_pcie_host_ops implementation to tegra_pcie_dw_host_init() API
>>>
>>> drivers/pci/controller/dwc/Kconfig | 10 +
>>> drivers/pci/controller/dwc/Makefile | 1 +
>>> drivers/pci/controller/dwc/pcie-tegra194.c | 1621 ++++++++++++++++++++
>>> 3 files changed, 1632 insertions(+)
>>> create mode 100644 drivers/pci/controller/dwc/pcie-tegra194.c
>>>
>>> diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig
>>> index a6ce1ee51b4c..884112afc11b 100644
>>> --- a/drivers/pci/controller/dwc/Kconfig
>>> +++ b/drivers/pci/controller/dwc/Kconfig
>>> @@ -220,6 +220,16 @@ config PCI_MESON
>>> and therefore the driver re-uses the DesignWare core functions to
>>> implement the driver.
>>>
>>> +config PCIE_TEGRA194
>>> + tristate "NVIDIA Tegra194 (and later) PCIe controller"
>>> + depends on (TEGRA_BPMP && ARCH_TEGRA) || COMPILE_TEST
>>
>> TEGRA_BPMP will be enough here as it depends on other relevant options.
>>
>> Hence I mean:
>>
>> depends on TEGRA_BPMP || COMPILE_TEST
>
> Maybe it's worth to even change TEGRA_BPMP to ARCH_TEGRA_194_SOC.
> Although then you'll have to extend it with other platforms later on,
> but probably that's fine.
I received an explicit comment previously to make this dependent on TEGRA_BPMP
as the driver is using APIs to get certain jobs done by BPMP-FW. But, since
we can't boot kernel in the first place without having BPMP-FW in place, I think
it should be fine to make it dependent on ARCH_TEGRA_194_SOC directly.
>
>>
>>> + depends on PCI_MSI_IRQ_DOMAIN
>>
>> You probably want to s/depends on/select/ PCI_MSI_IRQ_DOMAIN, don't you?
>>
>
> I actually looked up the PCI_MSI_IRQ_DOMAIN and it is correct in your
> case, my bad.
>
next prev parent reply other threads:[~2019-06-07 14:10 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-26 4:37 [PATCH V8 00/15] " Vidya Sagar
2019-05-26 4:37 ` [PATCH V8 01/15] PCI: Add #defines for some of PCIe spec r4.0 features Vidya Sagar
2019-05-26 4:37 ` [PATCH V8 02/15] PCI: Disable MSI for Tegra194 root port Vidya Sagar
2019-05-26 4:37 ` [PATCH V8 03/15] PCI: dwc: Perform dbi regs write lock towards the end Vidya Sagar
2019-05-26 4:37 ` [PATCH V8 04/15] PCI: dwc: Move config space capability search API Vidya Sagar
2019-05-26 4:37 ` [PATCH V8 05/15] PCI: dwc: Add ext " Vidya Sagar
2019-06-06 15:32 ` Thierry Reding
2019-05-26 4:37 ` [PATCH V8 06/15] dt-bindings: PCI: designware: Add binding for CDM register check Vidya Sagar
2019-05-26 4:37 ` [PATCH V8 07/15] PCI: dwc: Add support to enable " Vidya Sagar
2019-05-26 4:37 ` [PATCH V8 08/15] dt-bindings: Add PCIe supports-clkreq property Vidya Sagar
2019-05-26 4:37 ` [PATCH V8 09/15] dt-bindings: PCI: tegra: Add device tree support for Tegra194 Vidya Sagar
2019-06-06 15:34 ` Thierry Reding
2019-05-26 4:37 ` [PATCH V8 10/15] dt-bindings: PHY: P2U: Add Tegra194 P2U block Vidya Sagar
2019-05-26 4:37 ` [PATCH V8 11/15] arm64: tegra: Add P2U and PCIe controller nodes to Tegra194 DT Vidya Sagar
2019-05-26 4:37 ` [PATCH V8 12/15] arm64: tegra: Enable PCIe slots in P2972-0000 board Vidya Sagar
2019-05-26 4:37 ` [PATCH V8 13/15] phy: tegra: Add PCIe PIPE2UPHY support Vidya Sagar
2019-06-06 16:30 ` Dmitry Osipenko
2019-06-07 13:45 ` Vidya Sagar
2019-05-26 4:37 ` [PATCH V8 14/15] PCI: tegra: Add Tegra194 PCIe support Vidya Sagar
2019-06-06 15:36 ` Thierry Reding
2019-06-06 16:35 ` Dmitry Osipenko
2019-06-06 18:52 ` Dmitry Osipenko
2019-06-07 14:10 ` Vidya Sagar [this message]
2019-06-07 14:26 ` Dmitry Osipenko
2019-05-26 4:37 ` [PATCH V8 15/15] arm64: Add Tegra194 PCIe driver to defconfig Vidya Sagar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06f2f74e-d618-8688-14ae-beb4920bcbf6@nvidia.com \
--to=vidyas@nvidia.com \
--cc=bhelgaas@google.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=jingoohan1@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=kishon@ti.com \
--cc=kthota@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=mmaddireddy@nvidia.com \
--cc=mperttunen@nvidia.com \
--cc=robh+dt@kernel.org \
--cc=sagar.tv@gmail.com \
--cc=thierry.reding@gmail.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome