From: Vidya Sagar <vidyas@nvidia.com>
To: Dmitry Osipenko <digetx@gmail.com>, <lorenzo.pieralisi@arm.com>,
<bhelgaas@google.com>, <robh+dt@kernel.org>,
<mark.rutland@arm.com>, <thierry.reding@gmail.com>,
<jonathanh@nvidia.com>, <kishon@ti.com>,
<catalin.marinas@arm.com>, <will.deacon@arm.com>,
<jingoohan1@gmail.com>, <gustavo.pimentel@synopsys.com>
Cc: <mperttunen@nvidia.com>, <linux-pci@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <kthota@nvidia.com>,
<mmaddireddy@nvidia.com>, <sagar.tv@gmail.com>
Subject: Re: [PATCH V8 13/15] phy: tegra: Add PCIe PIPE2UPHY support
Date: Fri, 7 Jun 2019 19:15:32 +0530 [thread overview]
Message-ID: <5a5545c8-9e4c-b459-c40e-9e1c4e5daf5b@nvidia.com> (raw)
In-Reply-To: <c81c5d42-4292-ba6d-b5ab-afe1a604115f@gmail.com>
On 6/6/2019 10:00 PM, Dmitry Osipenko wrote:
> 26.05.2019 7:37, Vidya Sagar пишет:
>> Synopsys DesignWare core based PCIe controllers in Tegra 194 SoC interface
>> with Universal PHY (UPHY) module through a PIPE2UPHY (P2U) module.
>> For each PCIe lane of a controller, there is a P2U unit instantiated at
>> hardware level. This driver provides support for the programming required
>> for each P2U that is going to be used for a PCIe controller.
>>
>> Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
>> ---
>> Changes since [v7]:
>> * Changed P2U driver file name from pcie-p2u-tegra194.c to phy-tegra194-p2u.c
>>
>> Changes since [v6]:
>> * None
>>
>> Changes since [v5]:
>> * Addressed review comments from Thierry
>>
>> Changes since [v4]:
>> * None
>>
>> Changes since [v3]:
>> * Rebased on top of linux-next top of the tree
>>
>> Changes since [v2]:
>> * Replaced spaces with tabs in Kconfig file
>> * Sorted header file inclusion alphabetically
>>
>> Changes since [v1]:
>> * Added COMPILE_TEST in Kconfig
>> * Removed empty phy_ops implementations
>> * Modified code according to DT documentation file modifications
>>
>> drivers/phy/tegra/Kconfig | 7 ++
>> drivers/phy/tegra/Makefile | 1 +
>> drivers/phy/tegra/phy-tegra194-p2u.c | 109 +++++++++++++++++++++++++++
>> 3 files changed, 117 insertions(+)
>> create mode 100644 drivers/phy/tegra/phy-tegra194-p2u.c
>>
>> diff --git a/drivers/phy/tegra/Kconfig b/drivers/phy/tegra/Kconfig
>> index a3b1de953fb7..c56fc8452e03 100644
>> --- a/drivers/phy/tegra/Kconfig
>> +++ b/drivers/phy/tegra/Kconfig
>> @@ -6,3 +6,10 @@ config PHY_TEGRA_XUSB
>>
>> To compile this driver as a module, choose M here: the module will
>> be called phy-tegra-xusb.
>> +
>> +config PHY_TEGRA194_P2U
>> + tristate "NVIDIA Tegra194 PIPE2UPHY PHY driver"
>> + depends on ARCH_TEGRA || COMPILE_TEST
>
> ARCH_TEGRA is a bit too much, ARCH_TEGRA_194_SOC should fit better here.
>
Ok. I'll take care of it in the next patch series.
next prev parent reply other threads:[~2019-06-07 13:45 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-26 4:37 [PATCH V8 00/15] Add Tegra194 PCIe support Vidya Sagar
2019-05-26 4:37 ` [PATCH V8 01/15] PCI: Add #defines for some of PCIe spec r4.0 features Vidya Sagar
2019-05-26 4:37 ` [PATCH V8 02/15] PCI: Disable MSI for Tegra194 root port Vidya Sagar
2019-05-26 4:37 ` [PATCH V8 03/15] PCI: dwc: Perform dbi regs write lock towards the end Vidya Sagar
2019-05-26 4:37 ` [PATCH V8 04/15] PCI: dwc: Move config space capability search API Vidya Sagar
2019-05-26 4:37 ` [PATCH V8 05/15] PCI: dwc: Add ext " Vidya Sagar
2019-06-06 15:32 ` Thierry Reding
2019-05-26 4:37 ` [PATCH V8 06/15] dt-bindings: PCI: designware: Add binding for CDM register check Vidya Sagar
2019-05-26 4:37 ` [PATCH V8 07/15] PCI: dwc: Add support to enable " Vidya Sagar
2019-05-26 4:37 ` [PATCH V8 08/15] dt-bindings: Add PCIe supports-clkreq property Vidya Sagar
2019-05-26 4:37 ` [PATCH V8 09/15] dt-bindings: PCI: tegra: Add device tree support for Tegra194 Vidya Sagar
2019-06-06 15:34 ` Thierry Reding
2019-05-26 4:37 ` [PATCH V8 10/15] dt-bindings: PHY: P2U: Add Tegra194 P2U block Vidya Sagar
2019-05-26 4:37 ` [PATCH V8 11/15] arm64: tegra: Add P2U and PCIe controller nodes to Tegra194 DT Vidya Sagar
2019-05-26 4:37 ` [PATCH V8 12/15] arm64: tegra: Enable PCIe slots in P2972-0000 board Vidya Sagar
2019-05-26 4:37 ` [PATCH V8 13/15] phy: tegra: Add PCIe PIPE2UPHY support Vidya Sagar
2019-06-06 16:30 ` Dmitry Osipenko
2019-06-07 13:45 ` Vidya Sagar [this message]
2019-05-26 4:37 ` [PATCH V8 14/15] PCI: tegra: Add Tegra194 PCIe support Vidya Sagar
2019-06-06 15:36 ` Thierry Reding
2019-06-06 16:35 ` Dmitry Osipenko
2019-06-06 18:52 ` Dmitry Osipenko
2019-06-07 14:10 ` Vidya Sagar
2019-06-07 14:26 ` Dmitry Osipenko
2019-05-26 4:37 ` [PATCH V8 15/15] arm64: Add Tegra194 PCIe driver to defconfig Vidya Sagar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a5545c8-9e4c-b459-c40e-9e1c4e5daf5b@nvidia.com \
--to=vidyas@nvidia.com \
--cc=bhelgaas@google.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=jingoohan1@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=kishon@ti.com \
--cc=kthota@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=mmaddireddy@nvidia.com \
--cc=mperttunen@nvidia.com \
--cc=robh+dt@kernel.org \
--cc=sagar.tv@gmail.com \
--cc=thierry.reding@gmail.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome