* [PATCH] dt-bindings: interrupt-controller: Correct indentation and style in DTS example
@ 2025-01-07 13:11 Krzysztof Kozlowski
2025-01-08 0:38 ` Andrew Jeffery
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2025-01-07 13:11 UTC (permalink / raw)
To: Thomas Gleixner, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Joel Stanley, Andrew Jeffery, Florian Fainelli,
Broadcom internal kernel review list, linux-kernel, devicetree,
linux-arm-kernel, linux-aspeed
Cc: Krzysztof Kozlowski
DTS example in the bindings should be indented with 2- or 4-spaces and
aligned with opening '- |', so correct any differences like 3-spaces or
mixtures 2- and 4-spaces in one binding.
No functional changes here, but saves some comments during reviews of
new patches built on existing code.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../aspeed,ast2400-vic.yaml | 10 +++----
.../brcm,bcm7120-l2-intc.yaml | 30 +++++++++----------
2 files changed, 20 insertions(+), 20 deletions(-)
diff --git a/Documentation/devicetree/bindings/interrupt-controller/aspeed,ast2400-vic.yaml b/Documentation/devicetree/bindings/interrupt-controller/aspeed,ast2400-vic.yaml
index 73e8b9a39bd7..86516cd44b9d 100644
--- a/Documentation/devicetree/bindings/interrupt-controller/aspeed,ast2400-vic.yaml
+++ b/Documentation/devicetree/bindings/interrupt-controller/aspeed,ast2400-vic.yaml
@@ -52,11 +52,11 @@ additionalProperties: false
examples:
- |
interrupt-controller@1e6c0080 {
- compatible = "aspeed,ast2400-vic";
- reg = <0x1e6c0080 0x80>;
- interrupt-controller;
- #interrupt-cells = <1>;
- valid-sources = <0xffffffff 0x0007ffff>;
+ compatible = "aspeed,ast2400-vic";
+ reg = <0x1e6c0080 0x80>;
+ interrupt-controller;
+ #interrupt-cells = <1>;
+ valid-sources = <0xffffffff 0x0007ffff>;
};
...
diff --git a/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm7120-l2-intc.yaml b/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm7120-l2-intc.yaml
index 786f2426399b..0fcbe304cd05 100644
--- a/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm7120-l2-intc.yaml
+++ b/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm7120-l2-intc.yaml
@@ -130,23 +130,23 @@ required:
examples:
- |
irq0_intc: interrupt-controller@f0406800 {
- compatible = "brcm,bcm7120-l2-intc";
- interrupt-parent = <&intc>;
- #interrupt-cells = <1>;
- reg = <0xf0406800 0x8>;
- interrupt-controller;
- interrupts = <0x0 0x42 0x0>, <0x0 0x40 0x0>;
- brcm,int-map-mask = <0xeb8>, <0x140>;
- brcm,int-fwd-mask = <0x7>;
+ compatible = "brcm,bcm7120-l2-intc";
+ interrupt-parent = <&intc>;
+ #interrupt-cells = <1>;
+ reg = <0xf0406800 0x8>;
+ interrupt-controller;
+ interrupts = <0x0 0x42 0x0>, <0x0 0x40 0x0>;
+ brcm,int-map-mask = <0xeb8>, <0x140>;
+ brcm,int-fwd-mask = <0x7>;
};
- |
irq1_intc: interrupt-controller@10000020 {
- compatible = "brcm,bcm3380-l2-intc";
- reg = <0x10000024 0x4>, <0x1000002c 0x4>,
- <0x10000020 0x4>, <0x10000028 0x4>;
- interrupt-controller;
- #interrupt-cells = <1>;
- interrupt-parent = <&cpu_intc>;
- interrupts = <2>;
+ compatible = "brcm,bcm3380-l2-intc";
+ reg = <0x10000024 0x4>, <0x1000002c 0x4>,
+ <0x10000020 0x4>, <0x10000028 0x4>;
+ interrupt-controller;
+ #interrupt-cells = <1>;
+ interrupt-parent = <&cpu_intc>;
+ interrupts = <2>;
};
--
2.43.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: interrupt-controller: Correct indentation and style in DTS example
2025-01-07 13:11 [PATCH] dt-bindings: interrupt-controller: Correct indentation and style in DTS example Krzysztof Kozlowski
@ 2025-01-08 0:38 ` Andrew Jeffery
2025-01-08 17:16 ` Florian Fainelli
2025-01-10 15:46 ` Rob Herring (Arm)
2 siblings, 0 replies; 4+ messages in thread
From: Andrew Jeffery @ 2025-01-08 0:38 UTC (permalink / raw)
To: Krzysztof Kozlowski, Thomas Gleixner, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Joel Stanley,
Florian Fainelli, Broadcom internal kernel review list,
linux-kernel, devicetree, linux-arm-kernel, linux-aspeed
On Tue, 2025-01-07 at 14:11 +0100, Krzysztof Kozlowski wrote:
> DTS example in the bindings should be indented with 2- or 4-spaces
> and
> aligned with opening '- |', so correct any differences like 3-spaces
> or
> mixtures 2- and 4-spaces in one binding.
>
> No functional changes here, but saves some comments during reviews of
> new patches built on existing code.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../aspeed,ast2400-vic.yaml | 10 +++----
Acked-by: Andrew Jeffery <andrew@codeconstruct.com.au> # aspeed,ast2400-vic.yaml
Cheers,
Andrew
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: interrupt-controller: Correct indentation and style in DTS example
2025-01-07 13:11 [PATCH] dt-bindings: interrupt-controller: Correct indentation and style in DTS example Krzysztof Kozlowski
2025-01-08 0:38 ` Andrew Jeffery
@ 2025-01-08 17:16 ` Florian Fainelli
2025-01-10 15:46 ` Rob Herring (Arm)
2 siblings, 0 replies; 4+ messages in thread
From: Florian Fainelli @ 2025-01-08 17:16 UTC (permalink / raw)
To: Krzysztof Kozlowski, Thomas Gleixner, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Joel Stanley, Andrew Jeffery,
Broadcom internal kernel review list, linux-kernel, devicetree,
linux-arm-kernel, linux-aspeed
On 1/7/25 05:11, Krzysztof Kozlowski wrote:
> DTS example in the bindings should be indented with 2- or 4-spaces and
> aligned with opening '- |', so correct any differences like 3-spaces or
> mixtures 2- and 4-spaces in one binding.
>
> No functional changes here, but saves some comments during reviews of
> new patches built on existing code.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Acked-by: Florian Fainelli <florian.fainelli@broadcom.com>
--
Florian
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: interrupt-controller: Correct indentation and style in DTS example
2025-01-07 13:11 [PATCH] dt-bindings: interrupt-controller: Correct indentation and style in DTS example Krzysztof Kozlowski
2025-01-08 0:38 ` Andrew Jeffery
2025-01-08 17:16 ` Florian Fainelli
@ 2025-01-10 15:46 ` Rob Herring (Arm)
2 siblings, 0 replies; 4+ messages in thread
From: Rob Herring (Arm) @ 2025-01-10 15:46 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Thomas Gleixner, Florian Fainelli, linux-kernel, devicetree,
Joel Stanley, Conor Dooley, Broadcom internal kernel review list,
linux-arm-kernel, Andrew Jeffery, linux-aspeed,
Krzysztof Kozlowski
On Tue, 07 Jan 2025 14:11:08 +0100, Krzysztof Kozlowski wrote:
> DTS example in the bindings should be indented with 2- or 4-spaces and
> aligned with opening '- |', so correct any differences like 3-spaces or
> mixtures 2- and 4-spaces in one binding.
>
> No functional changes here, but saves some comments during reviews of
> new patches built on existing code.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../aspeed,ast2400-vic.yaml | 10 +++----
> .../brcm,bcm7120-l2-intc.yaml | 30 +++++++++----------
> 2 files changed, 20 insertions(+), 20 deletions(-)
>
Applied, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-01-10 15:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-01-07 13:11 [PATCH] dt-bindings: interrupt-controller: Correct indentation and style in DTS example Krzysztof Kozlowski
2025-01-08 0:38 ` Andrew Jeffery
2025-01-08 17:16 ` Florian Fainelli
2025-01-10 15:46 ` Rob Herring (Arm)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®