* [PATCH] usb: bdc: Use devm_clk_get_optional_enabled() in bdc_probe()
@ 2026-11-19 19:06 Markus Elfring
2026-11-19 20:19 ` Christophe JAILLET
0 siblings, 1 reply; 2+ messages in thread
From: Markus Elfring @ 2026-11-19 19:06 UTC (permalink / raw)
To: linux-usb, bcm-kernel-feedback-list, Al Cooper,
Greg Kroah-Hartman, Justin Chen, Neill Kapron
Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Thu, 19 Nov 2026 20:00:07 +0100
Reuse existing functionality from devm_clk_get_optional_enabled()
instead of keeping duplicate source code.
The source code was transformed by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/usb/gadget/udc/bdc/bdc_core.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/usb/gadget/udc/bdc/bdc_core.c b/drivers/usb/gadget/udc/bdc/bdc_core.c
index 5149c98bf9bf..ce09327250f4 100644
--- a/drivers/usb/gadget/udc/bdc/bdc_core.c
+++ b/drivers/usb/gadget/udc/bdc/bdc_core.c
@@ -530,16 +530,10 @@ static int bdc_probe(struct platform_device *pdev)
}
}
- bdc->clk = devm_clk_get_optional(dev, "sw_usbd");
+ bdc->clk = devm_clk_get_optional_enabled(dev, "sw_usbd");
if (IS_ERR(bdc->clk))
return PTR_ERR(bdc->clk);
- ret = clk_prepare_enable(bdc->clk);
- if (ret) {
- dev_err(dev, "could not enable clock\n");
- return ret;
- }
-
ret = bdc_phy_init(bdc);
if (ret) {
dev_err(bdc->dev, "BDC phy init failure:%d\n", ret);
--
2.56.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: bdc: Use devm_clk_get_optional_enabled() in bdc_probe()
2026-11-19 19:06 [PATCH] usb: bdc: Use devm_clk_get_optional_enabled() in bdc_probe() Markus Elfring
@ 2026-11-19 20:19 ` Christophe JAILLET
0 siblings, 0 replies; 2+ messages in thread
From: Christophe JAILLET @ 2026-11-19 20:19 UTC (permalink / raw)
To: Markus Elfring, linux-usb, bcm-kernel-feedback-list, Al Cooper,
Greg Kroah-Hartman, Justin Chen, Neill Kapron
Cc: LKML, kernel-janitors
Le 19/11/2026 à 20:06, Markus Elfring a écrit :
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Thu, 19 Nov 2026 20:00:07 +0100
>
> Reuse existing functionality from devm_clk_get_optional_enabled()
> instead of keeping duplicate source code.
>
> The source code was transformed by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> drivers/usb/gadget/udc/bdc/bdc_core.c | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/drivers/usb/gadget/udc/bdc/bdc_core.c b/drivers/usb/gadget/udc/bdc/bdc_core.c
> index 5149c98bf9bf..ce09327250f4 100644
> --- a/drivers/usb/gadget/udc/bdc/bdc_core.c
> +++ b/drivers/usb/gadget/udc/bdc/bdc_core.c
> @@ -530,16 +530,10 @@ static int bdc_probe(struct platform_device *pdev)
> }
> }
>
> - bdc->clk = devm_clk_get_optional(dev, "sw_usbd");
> + bdc->clk = devm_clk_get_optional_enabled(dev, "sw_usbd");
> if (IS_ERR(bdc->clk))
> return PTR_ERR(bdc->clk);
>
> - ret = clk_prepare_enable(bdc->clk);
> - if (ret) {
> - dev_err(dev, "could not enable clock\n");
> - return ret;
> - }
> -
> ret = bdc_phy_init(bdc);
> if (ret) {
> dev_err(bdc->dev, "BDC phy init failure:%d\n", ret);
Hi,
this patch is wrong because the remove function and the error handling
path of the probe need to be updated.
CJ
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-19 20:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-19 19:06 [PATCH] usb: bdc: Use devm_clk_get_optional_enabled() in bdc_probe() Markus Elfring
2026-11-19 20:19 ` Christophe JAILLET
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®