From: Oleg Drokin <green@linuxhacker.ru>
To: Joe Perches <joe@perches.com>
Cc: Andy Whitcroft <apw@canonical.com>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: checkpatch falsepositives in Lustre code
Date: Mon, 15 Feb 2016 20:57:13 -0500 [thread overview]
Message-ID: <073E66B1-D39F-4D03-BDC7-68B18172BA5D@linuxhacker.ru> (raw)
In-Reply-To: <1455584189.4046.28.camel@perches.com>
On Feb 15, 2016, at 7:56 PM, Joe Perches wrote:
> [etc...]
>
> Yeah, that's a defect of some type.
Also while I have your attention, here's another one:
struct cfs_percpt_lock *
cfs_percpt_lock_alloc(struct cfs_cpt_table *cptab)
{
struct cfs_percpt_lock *pcl;
spinlock_t *lock;
int i;
…
cfs_percpt_for_each(lock, i, pcl->pcl_locks)
spin_lock_init(lock);
The declaration of the spinlock pointer produces:
CHECK: spinlock_t definition without comment
Should spinlock pointers really be included in the check, it's obvious that
they themselves are not really protecting anything, esp. considering it's a
local function variable here.
next prev parent reply other threads:[~2016-02-16 1:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1E5E2198-2E5C-4B6F-AAA5-C28E0A776714@linuxhacker.ru>
2016-02-16 0:56 ` Joe Perches
2016-02-16 1:57 ` Oleg Drokin [this message]
2016-02-16 2:27 ` Joe Perches
2016-02-16 2:45 ` Oleg Drokin
2016-02-16 3:05 ` Joe Perches
2016-02-16 3:12 ` Oleg Drokin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=073E66B1-D39F-4D03-BDC7-68B18172BA5D@linuxhacker.ru \
--to=green@linuxhacker.ru \
--cc=apw@canonical.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®