From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Ajye Huang <ajye_huang@compal.corp-partner.google.com>
Cc: Libin Yang <libin.yang@intel.com>,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Cezary Rojewski <cezary.rojewski@intel.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
ye xingchen <ye.xingchen@zte.com.cn>,
Peter Ujfalusi <peter.ujfalusi@linux.intel.com>,
Takashi Iwai <tiwai@suse.com>,
linux-kernel@vger.kernel.org,
"balamurugan . c" <balamurugan.c@intel.com>,
Mark Brown <broonie@kernel.org>,
Muralidhar Reddy <muralidhar.reddy@intel.com>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Akihiko Odaki <akihiko.odaki@gmail.com>,
David Lin <CTLIN0@nuvoton.com>,
alsa-devel@alsa-project.org,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Brent Lu <brent.lu@intel.com>, Yong Zhi <yong.zhi@intel.com>
Subject: Re: [PATCH v2] ASoC: Intel: sof_nau8825: add variant with nau8318 amplifier.
Date: Wed, 21 Dec 2022 18:27:14 -0600 [thread overview]
Message-ID: <07538266-ea40-389e-9e68-054822121e0b@linux.intel.com> (raw)
In-Reply-To: <CALprXBZkhWitJBeenKHxzyQvkf=Q2FDAHKD511oCWC8-SJBK+A@mail.gmail.com>
On 12/21/22 17:30, Ajye Huang wrote:
> Hi Pierre
>
> On Sat, Dec 17, 2022 at 1:37 AM Pierre-Louis Bossart
> <pierre-louis.bossart@linux.intel.com> wrote:
>
>>
>> Ok, thanks for the explanations.
>>
>> Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
>
> Yesterday, I saw Arnd Bergmann sent this patch "ASoC: Intel:
> sof-nau8825: fix module alias overflow " for reducing the string to
> prevent over length,https://patchwork.kernel.org/project/alsa-devel/patch/20221221132515.2363276-1-arnd@kernel.org/.
>
> so, I need to check with you, should my string need to change the
> format style with his, even the my string does not over length , from
> .drv_name = "adl_nau8318_nau8825" to .drv_name = "adl_nau8318_8825",
> align with his format style?
That would be more consistent indeed, no objections from me.
next prev parent reply other threads:[~2022-12-22 0:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-16 15:49 Ajye Huang
2022-12-16 15:57 ` Ajye Huang
2022-12-16 16:05 ` Pierre-Louis Bossart
2022-12-16 16:57 ` Ajye Huang
2022-12-16 16:03 ` Pierre-Louis Bossart
2022-12-16 16:55 ` Ajye Huang
2022-12-16 17:36 ` Pierre-Louis Bossart
2022-12-20 14:06 ` Ajye Huang
2022-12-21 23:30 ` Ajye Huang
2022-12-22 0:27 ` Pierre-Louis Bossart [this message]
2022-12-22 2:38 ` Ajye Huang
2022-12-26 23:33 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07538266-ea40-389e-9e68-054822121e0b@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=CTLIN0@nuvoton.com \
--cc=ajye_huang@compal.corp-partner.google.com \
--cc=akihiko.odaki@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=balamurugan.c@intel.com \
--cc=brent.lu@intel.com \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=libin.yang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=muralidhar.reddy@intel.com \
--cc=peter.ujfalusi@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=tiwai@suse.com \
--cc=ye.xingchen@zte.com.cn \
--cc=yong.zhi@intel.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®