* [PATCH] selftests/dma: Fix bad array reference.
@ 2025-02-06 2:12 Liu Ye
2025-02-26 1:31 ` liuye
0 siblings, 1 reply; 5+ messages in thread
From: Liu Ye @ 2025-02-06 2:12 UTC (permalink / raw)
To: shuah; +Cc: zhujun2, iommu, linux-kselftest, linux-kernel, Liu Ye
dir[directions] should be directions[dir] to correctly index the
directions array.
Signed-off-by: Liu Ye <liuye@kylinos.cn>
---
tools/testing/selftests/dma/dma_map_benchmark.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/dma/dma_map_benchmark.c b/tools/testing/selftests/dma/dma_map_benchmark.c
index b12f1f9babf8..b925756373ce 100644
--- a/tools/testing/selftests/dma/dma_map_benchmark.c
+++ b/tools/testing/selftests/dma/dma_map_benchmark.c
@@ -118,7 +118,7 @@ int main(int argc, char **argv)
}
printf("dma mapping benchmark: threads:%d seconds:%d node:%d dir:%s granule: %d\n",
- threads, seconds, node, dir[directions], granule);
+ threads, seconds, node, directions[dir], granule);
printf("average map latency(us):%.1f standard deviation:%.1f\n",
map.avg_map_100ns/10.0, map.map_stddev/10.0);
printf("average unmap latency(us):%.1f standard deviation:%.1f\n",
--
2.25.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] selftests/dma: Fix bad array reference.
2025-02-06 2:12 [PATCH] selftests/dma: Fix bad array reference Liu Ye
@ 2025-02-26 1:31 ` liuye
2025-02-26 21:41 ` Shuah Khan
0 siblings, 1 reply; 5+ messages in thread
From: liuye @ 2025-02-26 1:31 UTC (permalink / raw)
To: shuah; +Cc: zhujun2, iommu, linux-kselftest, linux-kernel
Friendly ping.
在 2025/2/6 10:12, Liu Ye 写道:
> dir[directions] should be directions[dir] to correctly index the
> directions array.
>
> Signed-off-by: Liu Ye <liuye@kylinos.cn>
> ---
> tools/testing/selftests/dma/dma_map_benchmark.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/dma/dma_map_benchmark.c b/tools/testing/selftests/dma/dma_map_benchmark.c
> index b12f1f9babf8..b925756373ce 100644
> --- a/tools/testing/selftests/dma/dma_map_benchmark.c
> +++ b/tools/testing/selftests/dma/dma_map_benchmark.c
> @@ -118,7 +118,7 @@ int main(int argc, char **argv)
> }
>
> printf("dma mapping benchmark: threads:%d seconds:%d node:%d dir:%s granule: %d\n",
> - threads, seconds, node, dir[directions], granule);
> + threads, seconds, node, directions[dir], granule);
> printf("average map latency(us):%.1f standard deviation:%.1f\n",
> map.avg_map_100ns/10.0, map.map_stddev/10.0);
> printf("average unmap latency(us):%.1f standard deviation:%.1f\n",
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] selftests/dma: Fix bad array reference.
2025-02-26 1:31 ` liuye
@ 2025-02-26 21:41 ` Shuah Khan
2025-03-03 3:23 ` liuye
0 siblings, 1 reply; 5+ messages in thread
From: Shuah Khan @ 2025-02-26 21:41 UTC (permalink / raw)
To: liuye, shuah; +Cc: zhujun2, iommu, linux-kselftest, linux-kernel, Shuah Khan
On 2/25/25 18:31, liuye wrote:
> Friendly ping.
>
> 在 2025/2/6 10:12, Liu Ye 写道:
>> dir[directions] should be directions[dir] to correctly index the
>> directions array.
>>
>> Signed-off-by: Liu Ye <liuye@kylinos.cn>
>> ---
>> tools/testing/selftests/dma/dma_map_benchmark.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/testing/selftests/dma/dma_map_benchmark.c b/tools/testing/selftests/dma/dma_map_benchmark.c
>> index b12f1f9babf8..b925756373ce 100644
>> --- a/tools/testing/selftests/dma/dma_map_benchmark.c
>> +++ b/tools/testing/selftests/dma/dma_map_benchmark.c
>> @@ -118,7 +118,7 @@ int main(int argc, char **argv)
>> }
>>
>> printf("dma mapping benchmark: threads:%d seconds:%d node:%d dir:%s granule: %d\n",
>> - threads, seconds, node, dir[directions], granule);
>> + threads, seconds, node, directions[dir], granule);
>> printf("average map latency(us):%.1f standard deviation:%.1f\n",
>> map.avg_map_100ns/10.0, map.map_stddev/10.0);
>> printf("average unmap latency(us):%.1f standard deviation:%.1f\n",
How did you find this problem?
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] selftests/dma: Fix bad array reference.
2025-02-26 21:41 ` Shuah Khan
@ 2025-03-03 3:23 ` liuye
0 siblings, 0 replies; 5+ messages in thread
From: liuye @ 2025-03-03 3:23 UTC (permalink / raw)
To: Shuah Khan, shuah; +Cc: zhujun2, iommu, linux-kselftest, linux-kernel
By code observation only.
Thanks,
Liu Ye
在 2025/2/27 05:41, Shuah Khan 写道:
> On 2/25/25 18:31, liuye wrote:
>> Friendly ping.
>>
>> 在 2025/2/6 10:12, Liu Ye 写道:
>>> dir[directions] should be directions[dir] to correctly index the
>>> directions array.
>>>
>>> Signed-off-by: Liu Ye <liuye@kylinos.cn>
>>> ---
>>> tools/testing/selftests/dma/dma_map_benchmark.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/tools/testing/selftests/dma/dma_map_benchmark.c b/tools/testing/selftests/dma/dma_map_benchmark.c
>>> index b12f1f9babf8..b925756373ce 100644
>>> --- a/tools/testing/selftests/dma/dma_map_benchmark.c
>>> +++ b/tools/testing/selftests/dma/dma_map_benchmark.c
>>> @@ -118,7 +118,7 @@ int main(int argc, char **argv)
>>> }
>>> printf("dma mapping benchmark: threads:%d seconds:%d node:%d dir:%s granule: %d\n",
>>> - threads, seconds, node, dir[directions], granule);
>>> + threads, seconds, node, directions[dir], granule);
>>> printf("average map latency(us):%.1f standard deviation:%.1f\n",
>>> map.avg_map_100ns/10.0, map.map_stddev/10.0);
>>> printf("average unmap latency(us):%.1f standard deviation:%.1f\n",
>
> How did you find this problem?
>
> thanks,
> -- Shuah
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] selftests/dma: Fix bad array reference.
@ 2025-02-06 2:08 Liu Ye
0 siblings, 0 replies; 5+ messages in thread
From: Liu Ye @ 2025-02-06 2:08 UTC (permalink / raw)
To: shuah; +Cc: chenxiang66, zhujun2, iommu, linux-kselftest, linux-kernel, Liu Ye
dir[directions] should be directions[dir] to correctly index the
directions array.
Signed-off-by: Liu Ye <liuye@kylinos.cn>
---
tools/testing/selftests/dma/dma_map_benchmark.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/dma/dma_map_benchmark.c b/tools/testing/selftests/dma/dma_map_benchmark.c
index b12f1f9babf8..b925756373ce 100644
--- a/tools/testing/selftests/dma/dma_map_benchmark.c
+++ b/tools/testing/selftests/dma/dma_map_benchmark.c
@@ -118,7 +118,7 @@ int main(int argc, char **argv)
}
printf("dma mapping benchmark: threads:%d seconds:%d node:%d dir:%s granule: %d\n",
- threads, seconds, node, dir[directions], granule);
+ threads, seconds, node, directions[dir], granule);
printf("average map latency(us):%.1f standard deviation:%.1f\n",
map.avg_map_100ns/10.0, map.map_stddev/10.0);
printf("average unmap latency(us):%.1f standard deviation:%.1f\n",
--
2.25.1
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-03-03 3:24 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-02-06 2:12 [PATCH] selftests/dma: Fix bad array reference Liu Ye
2025-02-26 1:31 ` liuye
2025-02-26 21:41 ` Shuah Khan
2025-03-03 3:23 ` liuye
-- strict thread matches above, loose matches on Subject: below --
2025-02-06 2:08 Liu Ye
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®