From: Nick Terrell <terrelln@fb.com>
To: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
Cc: Chris Mason <clm@fb.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH] lib: zstd: bitstream: Mark expected switch fall-throughs
Date: Tue, 28 Nov 2017 21:38:49 +0000 [thread overview]
Message-ID: <0770A301-E322-4F85-A0F6-8448DECBB258@fb.com> (raw)
In-Reply-To: <20171128000059.GA22017@embeddedor.com>
> On Nov 27, 2017, at 4:00 PM, Gustavo A. R. Silva <garsilva@embeddedor.com> wrote:
>
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Looks good to me. We had the same patch in upstream PR#690 [1].
I believe that PR#695 [2] was also necessary to quiet the warning.
[1] https://github.com/facebook/zstd/pull/690/files
[2] https://github.com/facebook/zstd/pull/695/files
Reviewed-by: Nick Terrell <terrelln@fb.com>
prev parent reply other threads:[~2017-11-28 21:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-28 0:00 Gustavo A. R. Silva
2017-11-28 21:38 ` Nick Terrell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0770A301-E322-4F85-A0F6-8448DECBB258@fb.com \
--to=terrelln@fb.com \
--cc=clm@fb.com \
--cc=garsilva@embeddedor.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®