mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH rtw-next v8 0/5] wifi: rtw89: monitor mode and raw frame injection fixes
@ 2026-11-19  8:03 Enver Ikromov
  2026-11-19  8:03 ` [PATCH rtw-next v8 1/5] wifi: rtw89: avoid NULL vif dereference in rtw89_ops_tx() Enver Ikromov
                   ` (4 more replies)
  0 siblings, 5 replies; 7+ messages in thread
From: Enver Ikromov @ 2026-11-19  8:03 UTC (permalink / raw)
  To: Ping-Ke Shih, Zong-Zhe Yang; +Cc: linux-wireless, linux-kernel

This series fixes a NULL vif dereference and a negative radiotap rate
index bug on the TX path, restores the operating channel after monitor
down/up on non-chanctx devices, and fixes control-frame seq_ctrl reads,
sequence preservation, NO_ACK, and retry limits for raw 802.11 frame
injection.

Tested on RTL8852AE (10ec:8852, firmware 0.13.36.2) across 2.4 GHz and
5 GHz.

Changes in v8:
- Patch 1: update Fixes tag to e3ec7017f6a2 ("rtw89: add Realtek
  802.11ax driver").
- Patch 4: add a blank line after setting seq.
- Patch 5: note in the commit message that Wi-Fi 6 chips such as
  RTL8852AE lack a TX descriptor NO_ACK field, and unwrap
  rtw89_build_txwd_body6_v2().
- Collect Acked-by and Reviewed-by tags on patches 1-4.

Changes in v7:
- Patch 3: drop the local no_chanctx variable and check
  IEEE80211_CONF_MONITOR in rtw89_ops_config() so the channel flag is
  not set for non-monitor first interfaces in ieee80211_hw_conf_init().
- Rebase onto latest rtw-next.

Changes in v6:
- Focus the series strictly on the standalone monitor interface case
  (plus the concurrent NULL-vif crash guard in patch 1), dropping former
  patches 3, 4, 5, 6, and 8.
- Shorten commit messages and rebase onto rtw-next.
- Patch 1: use vif_to_rtwvif_safe().
- Patch 2: clamp negative rate indices to 0 with max_t().
- Patch 3 (was 10): move before injection changes, add
  rtwdev->support_chanctx, and reuse IEEE80211_CONF_CHANGE_CHANNEL in
  rtw89_ops_config().
- Patch 4 (was 7): keep control frames on the AC queue and only set
  seq = 0 for control frames.
- Patch 5 (was 9): simplify ASSIGN_SEQ handling and drop dead code.

Changes in v5:
- Split the NULL vif fix and negative rate index fix out as standalone
  patches 1-2 with Fixes: and Cc: stable tags.
- Split monitor injection into focused patches.
- Honor ASSIGN_SEQ, retries, and NO_ACK for injected frames.
- Restore channel on leaving idle for non-chanctx devices.

Changes in v3:
- Split into a patch series and use driver abstractions instead of
  direct register writes.

v7: https://lore.kernel.org/linux-wireless/20261118180435.904-1-owner@ph4ntom-rev.uz/
v6: https://lore.kernel.org/linux-wireless/20261117094135.1772-1-owner@ph4ntom-rev.uz/
v5: https://lore.kernel.org/linux-wireless/20261113235211.1911-1-owner@ph4ntom-rev.uz/
v3: https://lore.kernel.org/linux-wireless/20261104203051.564-1-owner@ph4ntom-rev.uz/
v2: https://lore.kernel.org/linux-wireless/179371849554.20972.16232816164394690660@ph4ntom-rev.uz/
v1 (RFC): https://lore.kernel.org/linux-wireless/1a196d6dfbc.35537d221913104450.3720060455831933789@zoho.com/

Enver Ikromov (5):
  wifi: rtw89: avoid NULL vif dereference in rtw89_ops_tx()
  wifi: rtw89: handle negative rate index for injected frames
  wifi: rtw89: restore channel when leaving idle on non-chanctx devices
  wifi: rtw89: avoid reading seq_ctrl on control frames
  wifi: rtw89: honor ASSIGN_SEQ, retries, and NO_ACK for injected frames

 drivers/net/wireless/realtek/rtw89/core.c     | 27 ++++++++++++++++---
 drivers/net/wireless/realtek/rtw89/core.h     |  3 +++
 drivers/net/wireless/realtek/rtw89/mac.h      |  2 ++
 drivers/net/wireless/realtek/rtw89/mac80211.c | 14 +++++++++-
 4 files changed, 42 insertions(+), 4 deletions(-)


base-commit: 0bdc579dbfc251a6b6838ee9459b6771b948c617
-- 
2.56.0.windows.4


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2026-11-19  8:09 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-19  8:03 [PATCH rtw-next v8 0/5] wifi: rtw89: monitor mode and raw frame injection fixes Enver Ikromov
2026-11-19  8:03 ` [PATCH rtw-next v8 1/5] wifi: rtw89: avoid NULL vif dereference in rtw89_ops_tx() Enver Ikromov
2026-11-19  8:03 ` [PATCH rtw-next v8 2/5] wifi: rtw89: handle negative rate index for injected frames Enver Ikromov
2026-11-19  8:03 ` [PATCH rtw-next v8 3/5] wifi: rtw89: restore channel when leaving idle on non-chanctx devices Enver Ikromov
2026-11-19  8:03 ` [PATCH rtw-next v8 4/5] wifi: rtw89: avoid reading seq_ctrl on control frames Enver Ikromov
2026-11-19  8:03 ` [PATCH rtw-next v8 5/5] wifi: rtw89: honor ASSIGN_SEQ, retries, and NO_ACK for injected frames Enver Ikromov
2026-11-19  8:09   ` Ping-Ke Shih

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®