[PATCH] IB/hns: include linux/of.h to fix build failure

[PATCH] IB/hns: include linux/of.h to fix build failure

[Tobias Regnery]

I see the following build error in an arm64 randconfig build:

drivers/infiniband/hw/hns/hns_roce_hw_v1.c: In function 'hns_roce_v1_reset':
drivers/infiniband/hw/hns/hns_roce_hw_v1.c:1384:15: error: implicit declaration of function 'of_parse_phandle' [-Werror=implicit-function-declaration]

Fix this by including linux/of.h directly.

Signed-off-by: Tobias Regnery <tobias.regnery@gmail.com>
---
This is against next-20170404

 drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v1.c b/drivers/infiniband/hw/hns/hns_roce_hw_v1.c
index ec68f56e8ee5..0f7e85c7b70b 100644
--- a/drivers/infiniband/hw/hns/hns_roce_hw_v1.c
+++ b/drivers/infiniband/hw/hns/hns_roce_hw_v1.c
@@ -33,6 +33,7 @@
 #include <linux/platform_device.h>
 #include <linux/acpi.h>
 #include <linux/etherdevice.h>
+#include <linux/of.h>
 #include <rdma/ib_umem.h>
 #include "hns_roce_common.h"
 #include "hns_roce_device.h"
-- 
2.11.0

Re: [PATCH] IB/hns: include linux/of.h to fix build failure

[Doug Ledford]

[-- Attachment #1.1: Type: text/plain, Size: 1331 bytes --]

On 4/4/2017 9:36 AM, Tobias Regnery wrote:
> I see the following build error in an arm64 randconfig build:
> 
> drivers/infiniband/hw/hns/hns_roce_hw_v1.c: In function 'hns_roce_v1_reset':
> drivers/infiniband/hw/hns/hns_roce_hw_v1.c:1384:15: error: implicit declaration of function 'of_parse_phandle' [-Werror=implicit-function-declaration]
> 
> Fix this by including linux/of.h directly.
> 
> Signed-off-by: Tobias Regnery <tobias.regnery@gmail.com>
> ---
> This is against next-20170404
> 
>  drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v1.c b/drivers/infiniband/hw/hns/hns_roce_hw_v1.c
> index ec68f56e8ee5..0f7e85c7b70b 100644
> --- a/drivers/infiniband/hw/hns/hns_roce_hw_v1.c
> +++ b/drivers/infiniband/hw/hns/hns_roce_hw_v1.c
> @@ -33,6 +33,7 @@
>  #include <linux/platform_device.h>
>  #include <linux/acpi.h>
>  #include <linux/etherdevice.h>
> +#include <linux/of.h>
>  #include <rdma/ib_umem.h>
>  #include "hns_roce_common.h"
>  #include "hns_roce_device.h"
> 

Hi Tobias, I already picked up this same change from another person.
Thanks.

-- 
Doug Ledford <dledford@redhat.com>
    GPG Key ID: B826A3330E572FDD
    Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]