* [PATCH] arm64: dts: qcom: x1e80100-hp-omnibook-x14: Enable SMB2360 0 and 1
@ 2025-03-19 16:05 Juerg Haefliger
2025-03-20 22:20 ` Bryan O'Donoghue
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Juerg Haefliger @ 2025-03-19 16:05 UTC (permalink / raw)
To: andersson, konradybcio, robh, krzk+dt, conor+dt, linux-arm-msm,
devicetree
Cc: linux-kernel, jens.glathe
Commit d37e2646c8a5 ("arm64: dts: qcom: x1e80100-pmics: Enable all SMB2360
separately") disables all SMB2360s and let the board DTS explicitly enable
them. The HP OmniBook DTS is from before this change and is missing the
explicit enabling. Add that to get all USB root ports.
Fixes: 6f18b8d4142c ("arm64: dts: qcom: x1e80100-hp-x14: dt for HP Omnibook X Laptop 14")
Cc: stable@vger.kernel.org # 6.14
Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
---
arch/arm64/boot/dts/qcom/x1e80100-hp-omnibook-x14.dts | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/x1e80100-hp-omnibook-x14.dts b/arch/arm64/boot/dts/qcom/x1e80100-hp-omnibook-x14.dts
index cd860a246c45..c4ac0aaa6f65 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100-hp-omnibook-x14.dts
+++ b/arch/arm64/boot/dts/qcom/x1e80100-hp-omnibook-x14.dts
@@ -1352,18 +1352,22 @@ &remoteproc_cdsp {
status = "okay";
};
+&smb2360_0 {
+ status = "okay";
+};
+
&smb2360_0_eusb2_repeater {
vdd18-supply = <&vreg_l3d_1p8>;
vdd3-supply = <&vreg_l2b_3p0>;
+};
+&smb2360_1 {
status = "okay";
};
&smb2360_1_eusb2_repeater {
vdd18-supply = <&vreg_l3d_1p8>;
vdd3-supply = <&vreg_l14b_3p0>;
-
- status = "okay";
};
&swr0 {
--
2.43.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: qcom: x1e80100-hp-omnibook-x14: Enable SMB2360 0 and 1
2025-03-19 16:05 [PATCH] arm64: dts: qcom: x1e80100-hp-omnibook-x14: Enable SMB2360 0 and 1 Juerg Haefliger
@ 2025-03-20 22:20 ` Bryan O'Donoghue
2025-03-20 22:31 ` Konrad Dybcio
2025-05-14 21:03 ` Bjorn Andersson
2 siblings, 0 replies; 4+ messages in thread
From: Bryan O'Donoghue @ 2025-03-20 22:20 UTC (permalink / raw)
To: Juerg Haefliger, andersson, konradybcio, robh, krzk+dt, conor+dt,
linux-arm-msm, devicetree
Cc: linux-kernel, jens.glathe
On 19/03/2025 16:05, Juerg Haefliger wrote:
> Commit d37e2646c8a5 ("arm64: dts: qcom: x1e80100-pmics: Enable all SMB2360
> separately") disables all SMB2360s and let the board DTS explicitly enable
> them. The HP OmniBook DTS is from before this change and is missing the
> explicit enabling. Add that to get all USB root ports.
>
> Fixes: 6f18b8d4142c ("arm64: dts: qcom: x1e80100-hp-x14: dt for HP Omnibook X Laptop 14")
> Cc: stable@vger.kernel.org # 6.14
> Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
> ---
> arch/arm64/boot/dts/qcom/x1e80100-hp-omnibook-x14.dts | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/x1e80100-hp-omnibook-x14.dts b/arch/arm64/boot/dts/qcom/x1e80100-hp-omnibook-x14.dts
> index cd860a246c45..c4ac0aaa6f65 100644
> --- a/arch/arm64/boot/dts/qcom/x1e80100-hp-omnibook-x14.dts
> +++ b/arch/arm64/boot/dts/qcom/x1e80100-hp-omnibook-x14.dts
> @@ -1352,18 +1352,22 @@ &remoteproc_cdsp {
> status = "okay";
> };
>
> +&smb2360_0 {
> + status = "okay";
> +};
> +
> &smb2360_0_eusb2_repeater {
> vdd18-supply = <&vreg_l3d_1p8>;
> vdd3-supply = <&vreg_l2b_3p0>;
> +};
>
> +&smb2360_1 {
> status = "okay";
> };
>
> &smb2360_1_eusb2_repeater {
> vdd18-supply = <&vreg_l3d_1p8>;
> vdd3-supply = <&vreg_l14b_3p0>;
> -
> - status = "okay";
> };
>
> &swr0 {
> --
> 2.43.0
>
>
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: qcom: x1e80100-hp-omnibook-x14: Enable SMB2360 0 and 1
2025-03-19 16:05 [PATCH] arm64: dts: qcom: x1e80100-hp-omnibook-x14: Enable SMB2360 0 and 1 Juerg Haefliger
2025-03-20 22:20 ` Bryan O'Donoghue
@ 2025-03-20 22:31 ` Konrad Dybcio
2025-05-14 21:03 ` Bjorn Andersson
2 siblings, 0 replies; 4+ messages in thread
From: Konrad Dybcio @ 2025-03-20 22:31 UTC (permalink / raw)
To: Juerg Haefliger, andersson, konradybcio, robh, krzk+dt, conor+dt,
linux-arm-msm, devicetree
Cc: linux-kernel, jens.glathe
On 3/19/25 5:05 PM, Juerg Haefliger wrote:
> Commit d37e2646c8a5 ("arm64: dts: qcom: x1e80100-pmics: Enable all SMB2360
> separately") disables all SMB2360s and let the board DTS explicitly enable
> them. The HP OmniBook DTS is from before this change and is missing the
> explicit enabling. Add that to get all USB root ports.
>
> Fixes: 6f18b8d4142c ("arm64: dts: qcom: x1e80100-hp-x14: dt for HP Omnibook X Laptop 14")
> Cc: stable@vger.kernel.org # 6.14
> Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: qcom: x1e80100-hp-omnibook-x14: Enable SMB2360 0 and 1
2025-03-19 16:05 [PATCH] arm64: dts: qcom: x1e80100-hp-omnibook-x14: Enable SMB2360 0 and 1 Juerg Haefliger
2025-03-20 22:20 ` Bryan O'Donoghue
2025-03-20 22:31 ` Konrad Dybcio
@ 2025-05-14 21:03 ` Bjorn Andersson
2 siblings, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2025-05-14 21:03 UTC (permalink / raw)
To: konradybcio, robh, krzk+dt, conor+dt, linux-arm-msm, devicetree,
Juerg Haefliger
Cc: linux-kernel, jens.glathe
On Wed, 19 Mar 2025 17:05:09 +0100, Juerg Haefliger wrote:
> Commit d37e2646c8a5 ("arm64: dts: qcom: x1e80100-pmics: Enable all SMB2360
> separately") disables all SMB2360s and let the board DTS explicitly enable
> them. The HP OmniBook DTS is from before this change and is missing the
> explicit enabling. Add that to get all USB root ports.
>
>
Applied, thanks!
[1/1] arm64: dts: qcom: x1e80100-hp-omnibook-x14: Enable SMB2360 0 and 1
commit: 48274b40a3719a950b1062f8125c972a2df5c083
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-05-14 21:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-03-19 16:05 [PATCH] arm64: dts: qcom: x1e80100-hp-omnibook-x14: Enable SMB2360 0 and 1 Juerg Haefliger
2025-03-20 22:20 ` Bryan O'Donoghue
2025-03-20 22:31 ` Konrad Dybcio
2025-05-14 21:03 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®